Finish migration of UnitTests target from XCTestCase to Swift Testing (#5129)

* Initial plan

* Migrate 3 test files from XCTest to Swift Testing

- MediaUploadPreviewScreenViewModelTests: @MainActor @Suite struct with init(),
  BundleFinder class for Bundle(for:), mutating test/setup functions,
  [self] capture replacing [weak self] in closures
- NotificationManagerTests: @MainActor @Suite final class with init()/deinit,
  expectation/fulfillment(of:) replaced with confirmation(...), test_ prefix stripped
- NotificationSettingsScreenViewModelTests: @MainActor @Suite struct with
  init() throws, non-optional stored properties, test prefix stripped

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Migrate 3 XCTest files to Swift Testing

- NotificationSettingsEditScreenViewModelTests: @MainActor @Suite struct with init() throws, mutating test methods
- TimelineViewModelTests: @MainActor @Suite final class with init() async throws + deinit
- AttributedStringBuilderTests: @Suite struct with init() async throws

All XCT assertions replaced with #expect/#require/Issue.record

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Migrate 4 test files from XCTest to Swift Testing

- TimelineMediaPreviewViewModelTests: @Suite struct, mutating @Test funcs,
  testLoadingItem renamed to loadingItem (called internally by other tests)
- ServerConfirmationScreenViewModelTests: @Suite final class with init()/deinit
- CompletionSuggestionServiceTests: @Suite struct with init()
- RoomFlowCoordinatorTests: @Suite final class with deinit

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Migrate 4 test files from XCTest to Swift Testing

- VoiceMessageRecorderTests: @Suite struct with init() async throws,
  added BundleFinder class for Bundle lookup, migrated all assertions
- SpaceScreenViewModelTests: @Suite struct, private mutating setupViewModel,
  all test funcs mutating, XCTestExpectation → confirmation
- RoomNotificationSettingsScreenViewModelTests: @Suite struct with
  init() throws, cancellable tests marked mutating
- JoinRoomScreenViewModelTests: @Suite final class with init()/deinit,
  XCTestExpectation → confirmation

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Migrate 6 test files from XCTestCase to Swift Testing

Co-authored-by: pixlwave <6060466+pixlwave@users.noreply.github.com>

* Fix trailing blank line in RoomPollsHistoryScreenViewModelTests

Co-authored-by: pixlwave <6060466+pixlwave@users.noreply.github.com>

* Migrate 3 test files from XCTest to Swift Testing

- MediaUploadingPreprocessorTests: @Suite final class with init()/deinit,
  removed executionTimeAllowance, XCTAssertEqual(accuracy:) → abs(Double)
- SecurityAndPrivacyScreenViewModelTests: @MainActor @Suite final class,
  5 expectation+fulfillment → await confirmation(...)
- CreateRoomViewModelTests: @MainActor @Suite final class,
  4 expectation+fulfillment → await confirmation(...)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Migrate RoomScreenViewModelTests and RoomDetailsScreenViewModelTests to Swift Testing

- Replace XCTest with Testing framework
- RoomScreenViewModelTests: final class with init() async throws + deinit
- RoomDetailsScreenViewModelTests: struct with init() and mutating funcs
- Convert XCT assertions to #expect / Issue.record
- Convert XCTestExpectation patterns to confirmation { confirm in }
- Strip 'test' prefix from all test function names

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Migrate ComposerToolbarViewModelTests from XCTest to Swift Testing

- Replace import XCTest with import Testing
- Convert XCTestCase class to @MainActor @Suite final class
- Replace setUp()/tearDown() with init()/deinit
- Strip 'test' prefix from all 41 test method names and add @Test
- Replace XCTAssert* with #expect()/#require()
- Replace try XCTUnwrap() with try #require()
- Convert expectation+wait patterns to deferFulfillment with PassthroughSubject
- Convert isInverted expectation to boolean flag checked after await
- Use deferFulfillment on $viewState for state-transition tests

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Address comments with Copilot.

* Fix the failing tests.

* Fixed flaky tests (#5137)

resolved flaky tests

* Tweaks and fixes.

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: pixlwave <6060466+pixlwave@users.noreply.github.com>
Co-authored-by: Doug <douglase@element.io>
Co-authored-by: Mauro <34335419+Velin92@users.noreply.github.com>

ElementX/Sources/Mocks/SessionVerificationControllerProxyMock.swift

@@ -26,9 +26,12 @@ extension SessionVerificationControllerProxyMock {
         
         mock.acknowledgeVerificationRequestDetailsReturnValue = .success(())
 
-        mock.requestDeviceVerificationClosure = { [unowned mock] in
+        mock.requestDeviceVerificationClosure = { [weak mock] in
             Task.detached {
+                guard let mock else { return }
+                
                 try await Task.sleep(for: requestDelay)
+                
                 mock.actions.send(.acceptedVerificationRequest)
                 
                 if otherDeviceStartsSasVerification {
@@ -42,8 +45,10 @@ extension SessionVerificationControllerProxyMock {
             return .success(())
         }
 
-        mock.startSasVerificationClosure = { [unowned mock] in
+        mock.startSasVerificationClosure = { [weak mock] in
             Task.detached {
+                guard let mock else { return }
+                
                 try await Task.sleep(for: requestDelay)
                 mock.actions.send(.startedSasVerification)
 
@@ -56,8 +61,10 @@ extension SessionVerificationControllerProxyMock {
             return .success(())
         }
 
-        mock.approveVerificationClosure = { [unowned mock] in
+        mock.approveVerificationClosure = { [weak mock] in
             Task.detached {
+                guard let mock else { return }
+                
                 try await Task.sleep(for: requestDelay)
                 mock.actions.send(.finished)
             }
@@ -65,8 +72,10 @@ extension SessionVerificationControllerProxyMock {
             return .success(())
         }
 
-        mock.declineVerificationClosure = { [unowned mock] in
+        mock.declineVerificationClosure = { [weak mock] in
             Task.detached {
+                guard let mock else { return }
+                
                 try await Task.sleep(for: requestDelay)
                 mock.actions.send(.cancelled)
             }
@@ -74,8 +83,10 @@ extension SessionVerificationControllerProxyMock {
             return .success(())
         }
         
-        mock.cancelVerificationClosure = { [unowned mock] in
+        mock.cancelVerificationClosure = { [weak mock] in
             Task.detached {
+                guard let mock else { return }
+                
                 try await Task.sleep(for: requestDelay)
                 mock.actions.send(.cancelled)
             }

ElementX/Sources/Screens/RoomNotificationSettingsScreen/RoomNotificationSettingsScreenViewModel.swift

@@ -9,7 +9,7 @@
 import Combine
 import SwiftUI
 
-typealias RoomNotificationSettingsScreenViewModelType = StateStoreViewModel<RoomNotificationSettingsScreenViewState, RoomNotificationSettingsScreenViewAction>
+typealias RoomNotificationSettingsScreenViewModelType = StateStoreViewModelV2<RoomNotificationSettingsScreenViewState, RoomNotificationSettingsScreenViewAction>
 
 class RoomNotificationSettingsScreenViewModel: RoomNotificationSettingsScreenViewModelType, RoomNotificationSettingsScreenViewModelProtocol {
     private let actionsSubject: PassthroughSubject<RoomNotificationSettingsScreenViewModelAction, Never> = .init()
@@ -115,7 +115,9 @@ class RoomNotificationSettingsScreenViewModel: RoomNotificationSettingsScreenVie
             } catch {
                 displayError(.restoreDefaultFailed)
             }
-            state.isRestoringDefaultSetting = false
+            await MainActor.run {
+                state.isRestoringDefaultSetting = false
+            }
         }
     }
     
@@ -134,7 +136,9 @@ class RoomNotificationSettingsScreenViewModel: RoomNotificationSettingsScreenVie
             } catch {
                 displayError(.setModeFailed)
             }
-            state.pendingCustomMode = nil
+            await MainActor.run {
+                state.pendingCustomMode = nil
+            }
         }
     }
     

ElementX/Sources/Screens/RoomNotificationSettingsScreen/View/RoomNotificationSettingsCustomSectionView.swift

@@ -10,7 +10,7 @@ import Compound
 import SwiftUI
 
 struct RoomNotificationSettingsCustomSectionView: View {
-    @ObservedObject var context: RoomNotificationSettingsScreenViewModel.Context
+    @Bindable var context: RoomNotificationSettingsScreenViewModel.Context
     
     var body: some View {
         Section {

ElementX/Sources/Screens/RoomNotificationSettingsScreen/View/RoomNotificationSettingsScreen.swift

@@ -10,7 +10,7 @@ import Compound
 import SwiftUI
 
 struct RoomNotificationSettingsScreen: View {
-    @ObservedObject var context: RoomNotificationSettingsScreenViewModel.Context
+    @Bindable var context: RoomNotificationSettingsScreenViewModel.Context
     
     var body: some View {
         Form {

ElementX/Sources/Screens/RoomNotificationSettingsScreen/View/RoomNotificationSettingsUserDefinedScreen.swift

@@ -10,7 +10,7 @@ import Compound
 import SwiftUI
 
 struct RoomNotificationSettingsUserDefinedScreen: View {
-    @ObservedObject var context: RoomNotificationSettingsScreenViewModel.Context
+    @Bindable var context: RoomNotificationSettingsScreenViewModel.Context
     
     var body: some View {
         Form {

ElementX/Sources/Services/NotificationSettings/RoomNotificationModeProxy.swift

@@ -9,7 +9,7 @@
 import Foundation
 import MatrixRustSDK
 
-enum RoomNotificationModeProxy: String, CaseIterable {
+enum RoomNotificationModeProxy: String, CaseIterable, Equatable {
     case allMessages
     case mentionsAndKeywordsOnly
     case mute

ElementX/Sources/Services/SessionVerification/SessionVerificationControllerProxyProtocol.swift

@@ -20,7 +20,7 @@ enum SessionVerificationControllerProxyError: Error {
     case failedCancellingVerification
 }
 
-enum SessionVerificationControllerProxyAction {
+enum SessionVerificationControllerProxyAction: Equatable {
     case receivedVerificationRequest(details: SessionVerificationRequestDetails)
     case acceptedVerificationRequest
     case startedSasVerification
@@ -30,7 +30,7 @@ enum SessionVerificationControllerProxyAction {
     case failed
 }
 
-struct SessionVerificationRequestDetails {
+struct SessionVerificationRequestDetails: Equatable {
     let senderProfile: UserProfileProxy
     let flowID: String
     let deviceID: String