ehealthsolutions/element-x-ios
3
0
Fork 0
mirror of https://github.com/Novaloop-AG/element-x-ios.git synced 2026-11-03 16:10:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Edit poll UX (#2151)

Browse Source 
* Add edit poll on room proxy

* Add CreatePollMode

* Add “edit poll” presentation flow

* Add delete poll section

* Inject editing poll

* Add submit action

* Refactor validation logic

* Add edit/delete actions

* Fix bubble timestamp for polls

* Update localisations

* Refactor CreatePoll -> PollForm

* Refactor tests

* Update rust sdk to 0.0.5-november23

* Update confirmation alerts

* Add edit support in TimelineItem menu

* Refactor a11y id

* Cleanup

* Fix failing tests

* Add tests

* Refine isEditable workaround

* Refactor timestamp in TimelineItemBubbledStylerView
This commit is contained in:
Alfonso Grillo
2023-11-23 12:19:15 +01:00
committed by GitHub
parent 4d011b9116
commit e583f52c65
36 changed files with 670 additions and 335 deletions
Download Patch File Download Diff File Expand all files Collapse all files
UITests/Sources/CreatePollScreenUITests.swift → UITests/Sources/PollFormScreenUITests.swift
+7 -7
View File
@@ -17,7 +17,7 @@
import XCTest
@MainActor
class CreatePollScreenUITests: XCTestCase {
class PollFormScreenUITests: XCTestCase {
func testEmptyScreen() async throws {
let app = Application.launch(.createPoll)
try await app.assertScreenshot(.createPoll)
@@ -25,19 +25,19 @@ class CreatePollScreenUITests: XCTestCase {
func testFilledPoll() async throws {
let app = Application.launch(.createPoll)
let questionTextField = app.textFields[A11yIdentifiers.createPollScreen.question]
let questionTextField = app.textFields[A11yIdentifiers.pollFormScreen.question]
questionTextField.tap()
questionTextField.typeText("Do you like polls?")
let option1TextField = app.textFields[A11yIdentifiers.createPollScreen.optionID(0)]
let option1TextField = app.textFields[A11yIdentifiers.pollFormScreen.optionID(0)]
option1TextField.tap()
option1TextField.typeText("Yes")
let option2TextField = app.textFields[A11yIdentifiers.createPollScreen.optionID(1)]
let option2TextField = app.textFields[A11yIdentifiers.pollFormScreen.optionID(1)]
option2TextField.tap()
option2TextField.typeText("No\n")
let createButton = app.buttons[A11yIdentifiers.createPollScreen.create]
let createButton = app.buttons[A11yIdentifiers.pollFormScreen.create]
XCTAssertTrue(createButton.isEnabled)
try await app.assertScreenshot(.createPoll, step: 1)
@@ -45,8 +45,8 @@ class CreatePollScreenUITests: XCTestCase {
func testMaxOptions() async throws {
let app = Application.launch(.createPoll)
let createButton = app.buttons[A11yIdentifiers.createPollScreen.create]
let addOption = app.buttons[A11yIdentifiers.createPollScreen.addOption]
let createButton = app.buttons[A11yIdentifiers.pollFormScreen.create]
let addOption = app.buttons[A11yIdentifiers.pollFormScreen.addOption]
for _ in 1...18 {
if !addOption.exists {