Invite people in an existing room (#915)

* Handle power levels * Add “invite” button in RoomMembersListScreen * Refactor DI in RoomDetailsScreenCoordinator * Add navigation to “select people” coordinator * Add InviteUsersScreenRoomContext * Add invite user by id api * Updare InviteUsersScreenRoomContext * Support disabled state on FormButtonStyles * Handle membership in UserProfileCell * Fix conflicts * Refactor RoomContext -> RoomType * Refactor UserProfileCell * Add invite action * Setup navigation to user flow coordinator * Add invite logic * Fix test build errors * Address comments * Fix localisations * Update required state * Handle error * Move invite logic in RoomDetailsScreenCoordinator * Add navigation from room’s members list * Fix UTs * Fix missing display name in RoomMemberDetails * Add user indicator * Add feature flag * Add RoomDetailsViewModel UTs * Add room details ui tests * Add InviteUsersViewModelTests UTs * Add UI tests * Update UI tests * Empty commit
2026-11-02 12:07:55 +00:00 · 2023-05-22 16:03:07 +02:00
parent 8ed8cf6f0c
commit d9e0f36aeb
58 changed files with 708 additions and 172 deletions
@@ -25,26 +25,73 @@ class InviteUsersScreenViewModelTests: XCTestCase {
    var clientProxy: MockClientProxy!
    var userDiscoveryService: UserDiscoveryServiceMock!
    
-    private let usersSubject = CurrentValueSubject<[UserProfile], Never>([])
    private var cancellables: Set<AnyCancellable> = []
    
    var context: InviteUsersScreenViewModel.Context {
        viewModel.context
    }
    
-    override func setUpWithError() throws {
+    func testSelectUser() {
+        setupWithRoomType(roomType: .draft)
+        XCTAssertTrue(context.viewState.selectedUsers.isEmpty)
+        context.send(viewAction: .toggleUser(.mockAlice))
+        XCTAssertTrue(context.viewState.selectedUsers.count == 1)
+        XCTAssertEqual(context.viewState.selectedUsers.first?.userID, UserProfile.mockAlice.userID)
+    }
+    
+    func testReselectUser() {
+        setupWithRoomType(roomType: .draft)
+        XCTAssertTrue(context.viewState.selectedUsers.isEmpty)
+        context.send(viewAction: .toggleUser(.mockAlice))
+        XCTAssertEqual(context.viewState.selectedUsers.count, 1)
+        XCTAssertEqual(context.viewState.selectedUsers.first?.userID, UserProfile.mockAlice.userID)
+        context.send(viewAction: .toggleUser(.mockAlice))
+        XCTAssertTrue(context.viewState.selectedUsers.isEmpty)
+    }
+    
+    func testDeselectUser() {
+        setupWithRoomType(roomType: .draft)
+        XCTAssertTrue(context.viewState.selectedUsers.isEmpty)
+        context.send(viewAction: .toggleUser(.mockAlice))
+        XCTAssertEqual(context.viewState.selectedUsers.count, 1)
+        XCTAssertEqual(context.viewState.selectedUsers.first?.userID, UserProfile.mockAlice.userID)
+        context.send(viewAction: .toggleUser(.mockAlice))
+        XCTAssertTrue(context.viewState.selectedUsers.isEmpty)
+    }
+     
+    func testInviteButton() async {
+        let mockedMembers: [RoomMemberProxyMock] = [.mockAlice, .mockBob]
+        setupWithRoomType(roomType: .room(members: mockedMembers, userIndicatorController: MockUserIndicatorController()))
+        _ = await viewModel.context.$viewState.values.first(where: { $0.membershipState.isEmpty == false })
+        context.send(viewAction: .toggleUser(.mockAlice))
+        
+        Task {
+            await Task.yield()
+            context.send(viewAction: .proceed)
+        }
+        
+        let action = await viewModel.actions.values.first()
+        
+        guard case let .invite(members) = action else {
+            XCTFail("Sent action should be 'invite'")
+            return
+        }
+        
+        XCTAssertEqual(members, [RoomMemberProxyMock.mockAlice.userID])
+    }
+    
+    private func setupWithRoomType(roomType: InviteUsersScreenRoomType) {
+        let usersSubject = CurrentValueSubject<[UserProfile], Never>([])
        clientProxy = .init(userID: "")
        userDiscoveryService = UserDiscoveryServiceMock()
        userDiscoveryService.fetchSuggestionsReturnValue = .success([])
        userDiscoveryService.searchProfilesWithReturnValue = .success([])
-        let userSession = MockUserSession(clientProxy: clientProxy, mediaProvider: MockMediaProvider())
        usersSubject.send([])
-        let viewModel = InviteUsersScreenViewModel(selectedUsers: usersSubject.asCurrentValuePublisher(), userSession: userSession, userDiscoveryService: userDiscoveryService)
+        let viewModel = InviteUsersScreenViewModel(selectedUsers: usersSubject.asCurrentValuePublisher(), roomType: roomType, mediaProvider: MockMediaProvider(), userDiscoveryService: userDiscoveryService)
        viewModel.state.usersSection = .init(type: .suggestions, users: [.mockAlice, .mockBob, .mockCharlie])
        self.viewModel = viewModel
        
-        viewModel.actions.sink { [weak self] action in
-            guard let self else { return }
+        viewModel.actions.sink { action in
            switch action {
            case .toggleUser(let user):
                var selectedUsers = usersSubject.value
@@ -60,29 +107,4 @@ class InviteUsersScreenViewModelTests: XCTestCase {
        }
        .store(in: &cancellables)
    }
-    
-    func testSelectUser() {
-        XCTAssertTrue(context.viewState.selectedUsers.isEmpty)
-        context.send(viewAction: .toggleUser(.mockAlice))
-        XCTAssertTrue(context.viewState.selectedUsers.count == 1)
-        XCTAssertEqual(context.viewState.selectedUsers.first?.userID, UserProfile.mockAlice.userID)
-    }
-    
-    func testReselectUser() {
-        XCTAssertTrue(context.viewState.selectedUsers.isEmpty)
-        context.send(viewAction: .toggleUser(.mockAlice))
-        XCTAssertEqual(context.viewState.selectedUsers.count, 1)
-        XCTAssertEqual(context.viewState.selectedUsers.first?.userID, UserProfile.mockAlice.userID)
-        context.send(viewAction: .toggleUser(.mockAlice))
-        XCTAssertTrue(context.viewState.selectedUsers.isEmpty)
-    }
-    
-    func testDeselectUser() {
-        XCTAssertTrue(context.viewState.selectedUsers.isEmpty)
-        context.send(viewAction: .toggleUser(.mockAlice))
-        XCTAssertEqual(context.viewState.selectedUsers.count, 1)
-        XCTAssertEqual(context.viewState.selectedUsers.first?.userID, UserProfile.mockAlice.userID)
-        context.send(viewAction: .toggleUser(.mockAlice))
-        XCTAssertTrue(context.viewState.selectedUsers.isEmpty)
-    }
 }
@@ -180,4 +180,38 @@ class RoomDetailsScreenViewModelTests: XCTestCase {
        XCTAssert(context.viewState.dmRecipient?.isIgnored == true)
        XCTAssertNotNil(context.alertInfo)
    }
+    
+    func testCannotInvitePeople() async {
+        let mockedMembers: [RoomMemberProxyMock] = [.mockBob, .mockAlice]
+        roomProxyMock = RoomProxyMock(with: .init(displayName: "Test", isPublic: true, members: mockedMembers))
+        viewModel = RoomDetailsScreenViewModel(roomProxy: roomProxyMock, mediaProvider: MockMediaProvider())
+        
+        await context.nextViewState()
+        
+        XCTAssertFalse(context.viewState.canInviteUsers)
+    }
+    
+    func testInvitePeople() async {
+        let mockedMembers: [RoomMemberProxyMock] = [.mockMe, .mockBob, .mockAlice]
+        roomProxyMock = RoomProxyMock(with: .init(displayName: "Test", isPublic: true, members: mockedMembers))
+        viewModel = RoomDetailsScreenViewModel(roomProxy: roomProxyMock, mediaProvider: MockMediaProvider())
+        
+        await context.nextViewState()
+        
+        XCTAssertTrue(context.viewState.canInviteUsers)
+        
+        var callbackCorrectlyCalled = false
+        viewModel.callback = { action in
+            switch action {
+            case .requestInvitePeoplePresentation(let members):
+                callbackCorrectlyCalled = members.map(\.userID) == mockedMembers.map(\.userID)
+            default:
+                callbackCorrectlyCalled = false
+            }
+        }
+        
+        context.send(viewAction: .processTapInvite)
+        await Task.yield()
+        XCTAssertTrue(callbackCorrectlyCalled)
+    }
 }