Removing Dead Code part 1 (#2234)

ElementX/Sources/Application/AppCoordinator.swift

@@ -45,6 +45,7 @@ class AppCoordinator: AppCoordinatorProtocol, AuthenticationCoordinatorDelegate,
     
     private var authenticationCoordinator: AuthenticationCoordinator?
     private let appLockFlowCoordinator: AppLockFlowCoordinator
+    // periphery:ignore - used to avoid deallocation
     private var appLockSetupFlowCoordinator: AppLockSetupFlowCoordinator?
     private var userSessionFlowCoordinator: UserSessionFlowCoordinator?
     private var softLogoutCoordinator: SoftLogoutScreenCoordinator?
@@ -90,7 +91,7 @@ class AppCoordinator: AppCoordinatorProtocol, AuthenticationCoordinatorDelegate,
         
         navigationRootCoordinator = NavigationRootCoordinator()
         
-        Self.setupServiceLocator(navigationRootCoordinator: navigationRootCoordinator, appSettings: appSettings)
+        Self.setupServiceLocator(appSettings: appSettings)
         
         ServiceLocator.shared.analytics.startIfEnabled()
 
@@ -209,9 +210,9 @@ class AppCoordinator: AppCoordinatorProtocol, AuthenticationCoordinatorDelegate,
     
     // MARK: - AuthenticationCoordinatorDelegate
     
-    func authenticationCoordinator(_ authenticationCoordinator: AuthenticationCoordinator, didLoginWithSession userSession: UserSessionProtocol) {
+    func authenticationCoordinator(didLoginWithSession userSession: UserSessionProtocol) {
         self.userSession = userSession
-        self.authenticationCoordinator = nil
+        authenticationCoordinator = nil
         stateMachine.processEvent(.createdUserSession)
     }
     
@@ -232,7 +233,7 @@ class AppCoordinator: AppCoordinatorProtocol, AuthenticationCoordinatorDelegate,
         UIApplication.shared.unregisterForRemoteNotifications()
     }
         
-    func shouldDisplayInAppNotification(_ service: NotificationManagerProtocol, content: UNNotificationContent) -> Bool {
+    func shouldDisplayInAppNotification(content: UNNotificationContent) -> Bool {
         guard let roomID = content.roomID else {
             return true
         }
@@ -243,7 +244,7 @@ class AppCoordinator: AppCoordinatorProtocol, AuthenticationCoordinatorDelegate,
         return !userSessionFlowCoordinator.isDisplayingRoomScreen(withRoomID: roomID)
     }
     
-    func notificationTapped(_ service: NotificationManagerProtocol, content: UNNotificationContent) async {
+    func notificationTapped(content: UNNotificationContent) async {
         MXLog.info("[AppCoordinator] tappedNotification")
         
         guard let roomID = content.roomID,
@@ -284,7 +285,7 @@ class AppCoordinator: AppCoordinatorProtocol, AuthenticationCoordinatorDelegate,
         setenv("RUST_BACKTRACE", "1", 1)
     }
     
-    private static func setupServiceLocator(navigationRootCoordinator: NavigationRootCoordinator, appSettings: AppSettings) {
+    private static func setupServiceLocator(appSettings: AppSettings) {
         ServiceLocator.shared.register(userIndicatorController: UserIndicatorController())
         ServiceLocator.shared.register(appSettings: appSettings)
         ServiceLocator.shared.register(networkMonitor: NetworkMonitor())

ElementX/Sources/Application/AppCoordinatorProtocol.swift

@@ -17,7 +17,6 @@
 import Foundation
 
 protocol AppCoordinatorProtocol: CoordinatorProtocol {
-    var notificationManager: NotificationManagerProtocol { get }
     var windowManager: WindowManager { get }
     @discardableResult func handleDeepLink(_ url: URL) -> Bool
 }

ElementX/Sources/Application/AppSettings.swift

@@ -86,8 +86,6 @@ final class AppSettings {
     /// deleted between runs so should clear data in the shared container and keychain.
     @UserPreference(key: UserDefaultsKeys.lastVersionLaunched, storageType: .userDefaults(store))
     var lastVersionLaunched: String?
-
-    let lastLaunchDate = Date()
     
     /// The Set of room identifiers of invites that the user already saw in the invites list.
     /// This Set is being used to implement badges for unread invites.
@@ -180,7 +178,6 @@ final class AppSettings {
     let bugReportSentryURL: URL = "https://f39ac49e97714316965b777d9f3d6cd8@sentry.tools.element.io/44"
     // Use the name allocated by the bug report server
     let bugReportApplicationId = "element-x-ios"
-    let bugReportUISIId = "element-auto-uisi"
     /// The maximum size of the upload request. Default value is just below CloudFlare's max request size.
     let bugReportMaxUploadSize = 50 * 1024 * 1024
     
@@ -257,9 +254,6 @@ final class AppSettings {
     // maptiler api key
     let mapTilerApiKey = InfoPlistReader.main.mapLibreAPIKey
     
-    // maptiler geocoding url
-    let geocodingURLFormatString = "https://api.maptiler.com/geocoding/%f,%f.json"
-    
     // MARK: - Feature Flags
     
     @UserPreference(key: UserDefaultsKeys.userSuggestionsEnabled, defaultValue: false, storageType: .volatile)

ElementX/Sources/Application/FlowCoordinatorProtocol.swift

@@ -16,6 +16,7 @@
 
 import Foundation
 
+// periphery:ignore - markdown protocol
 @MainActor
 protocol FlowCoordinatorProtocol {
     func handleAppRoute(_ appRoute: AppRoute, animated: Bool)