ehealthsolutions/element-x-ios
3
0
Fork 0
mirror of https://github.com/Novaloop-AG/element-x-ios.git synced 2026-11-03 16:10:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Avoid race conditions between the home screen's crash alert and Sentry's onLastRunStatusDetermined

Browse Source 
By converting the `lastCrashEventID` to a publisher that the VM can just listen to instead of relying on start to match a pre-set event
This commit is contained in:
Stefan Ceriu
2026-08-13 09:25:27 +03:00
parent 9f648803f9
commit d4d74dd8f8
14 changed files with 33 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files
UnitTests/Sources/BugReportServiceTests.swift
+4 -4
View File
@@ -21,7 +21,7 @@ final class BugReportServiceTests {
appSettings.bugReportRageshakeURL.reset()
let bugReportServiceMock = BugReportServiceMock()
bugReportServiceMock.crashedLastRun = false
bugReportServiceMock.lastCrashEventIDSubject = .init(nil)
bugReportServiceMock.submitBugReportProgressListenerReturnValue = .success(SubmitBugReportResponse(reportURL: "https://www.example.com/123"))
bugReportService = bugReportServiceMock
}
@@ -32,7 +32,7 @@ final class BugReportServiceTests {
@Test
func initialStateWithMockService() {
#expect(!bugReportService.crashedLastRun)
#expect(bugReportService.lastCrashEventIDSubject.value == nil)
}
@Test
@@ -62,7 +62,7 @@ final class BugReportServiceTests {
session: .mock,
appHooks: AppHooks())
#expect(service.isEnabled)
#expect(!service.crashedLastRun)
#expect(bugReportService.lastCrashEventIDSubject.value == nil)
}
@Test
@@ -74,7 +74,7 @@ final class BugReportServiceTests {
session: .mock,
appHooks: AppHooks())
#expect(!service.isEnabled)
#expect(!service.crashedLastRun)
#expect(bugReportService.lastCrashEventIDSubject.value == nil)
}
@Test
UnitTests/Sources/HomeScreenViewModelTests.swift
+1
View File
@@ -432,6 +432,7 @@ final class HomeScreenViewModelTests {
selectedRoomPublisher: CurrentValueSubject<String?, Never>(nil).asCurrentValuePublisher(),
appSettings: appSettings,
analyticsService: AnalyticsServiceMock(.init()),
bugReportService: BugReportServiceMock(.init()),
notificationManager: notificationManager,
userIndicatorController: UserIndicatorControllerMock())
}