Remove the requiresExtraAccountSetup badge. (#5921)

It is no longer part of the designs, we only badge the item in Settings.

ElementX/Sources/Screens/HomeScreen/HomeScreenModels.swift

@@ -95,8 +95,6 @@ struct HomeScreenViewState: BindableState {
     var securityBannerMode = HomeScreenSecurityBannerMode.none
     var shouldShowNewSoundBanner = false
     
-    var requiresExtraAccountSetup = false
-    
     var rooms: [HomeScreenRoom] = []
     var roomListMode: HomeScreenRoomListMode = .skeletons
     

ElementX/Sources/Screens/HomeScreen/HomeScreenViewModel.swift

@@ -65,16 +65,13 @@ class HomeScreenViewModel: HomeScreenViewModelType, HomeScreenViewModelProtocol
                 
                 switch securityState.recoveryState {
                 case .disabled:
-                    state.requiresExtraAccountSetup = true
                     if !state.securityBannerMode.isDismissed {
                         state.securityBannerMode = .show(.setUpRecovery)
                     }
                 case .incomplete:
-                    state.requiresExtraAccountSetup = true
                     state.securityBannerMode = .show(.recoveryOutOfSync)
                 default:
                     state.securityBannerMode = .none
-                    state.requiresExtraAccountSetup = false
                 }
             }
             .store(in: &cancellables)

ElementX/Sources/Screens/HomeScreen/View/HomeScreen.swift

@@ -86,7 +86,6 @@ struct HomeScreen: View {
             context.send(viewAction: .showSettings)
         } label: {
             AvatarSettingsButtonLabel(userProfile: context.viewState.userProfile,
-                                      requiresExtraAccountSetup: context.viewState.requiresExtraAccountSetup,
                                       mediaProvider: context.mediaProvider)
         }
         .accessibilityLabel(L10n.commonSettings)