Removed unused context menu + some unused code cleaning (#2487)

ElementX/Sources/Screens/ComposerToolbar/ComposerToolbarViewModel.swift

@@ -384,6 +384,7 @@ final class ComposerToolbarViewModel: ComposerToolbarViewModelType, ComposerTool
         #endif
     }
     
+    // periphery:ignore:parameters notification
     @objc private func hardwareKeyboardDidConnect(_ notification: Notification) {
         MXLog.info("Did connect hardware keyboard")
         state.bindings.composerFocused = true

ElementX/Sources/Screens/HomeScreen/HomeScreenModels.swift

@@ -32,17 +32,12 @@ enum HomeScreenViewModelAction {
     case logout
 }
 
-enum HomeScreenViewUserMenuAction {
-    case settings
-    case logout
-}
-
 enum HomeScreenViewAction {
     case selectRoom(roomIdentifier: String)
     case showRoomDetails(roomIdentifier: String)
     case leaveRoom(roomIdentifier: String)
     case confirmLeaveRoom(roomIdentifier: String)
-    case userMenu(action: HomeScreenViewUserMenuAction)
+    case showSettings
     case startChat
     case verifySession
     case confirmRecoveryKey

ElementX/Sources/Screens/HomeScreen/HomeScreenViewModel.swift

@@ -159,13 +159,8 @@ class HomeScreenViewModel: HomeScreenViewModelType, HomeScreenViewModelProtocol
             startLeaveRoomProcess(roomId: roomIdentifier)
         case .confirmLeaveRoom(roomIdentifier: let roomIdentifier):
             leaveRoom(roomId: roomIdentifier)
-        case .userMenu(let action):
-            switch action {
-            case .settings:
-                actionsSubject.send(.presentSettingsScreen)
-            case .logout:
-                actionsSubject.send(.logout)
-            }
+        case .showSettings:
+            actionsSubject.send(.presentSettingsScreen)
         case .verifySession:
             actionsSubject.send(.presentSessionVerificationScreen)
         case .confirmRecoveryKey:

ElementX/Sources/Screens/HomeScreen/View/HomeScreen.swift

@@ -140,7 +140,19 @@ struct HomeScreen: View {
     @ToolbarContentBuilder
     private var toolbar: some ToolbarContent {
         ToolbarItem(placement: .navigationBarLeading) {
-            HomeScreenUserMenuButton(context: context)
+            Button {
+                context.send(viewAction: .showSettings)
+            } label: {
+                LoadableAvatarImage(url: context.viewState.userAvatarURL,
+                                    name: context.viewState.userDisplayName,
+                                    contentID: context.viewState.userID,
+                                    avatarSize: .user(on: .home),
+                                    imageProvider: context.imageProvider)
+                    .accessibilityIdentifier(A11yIdentifiers.homeScreen.userAvatar)
+                    .overlayBadge(10, isBadged: context.viewState.requiresExtraAccountSetup)
+                    .compositingGroup()
+            }
+            .accessibilityLabel(L10n.commonSettings)
         }
         
         ToolbarItem(placement: .primaryAction) {

ElementX/Sources/Screens/HomeScreen/View/HomeScreenUserMenuButton.swift

@@ -1,58 +0,0 @@
-//
-// Copyright 2023 New Vector Ltd
-//
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-// http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-//
-
-import Compound
-import SwiftUI
-
-struct HomeScreenUserMenuButton: View {
-    @ObservedObject var context: HomeScreenViewModel.Context
-    
-    var body: some View {
-        Menu {
-            Section {
-                Button {
-                    context.send(viewAction: .userMenu(action: .settings))
-                } label: {
-                    Label {
-                        Text(L10n.commonSettings)
-                    } icon: {
-                        if context.viewState.requiresExtraAccountSetup {
-                            CompoundIcon(asset: Asset.Images.settingsIconWithBadge)
-                        } else {
-                            CompoundIcon(\.settings)
-                        }
-                    }
-                }
-                .accessibilityIdentifier(A11yIdentifiers.homeScreen.settings)
-                Button(role: .destructive) {
-                    context.send(viewAction: .userMenu(action: .logout))
-                } label: {
-                    Label(L10n.screenSignoutPreferenceItem, icon: \.signOut)
-                }
-            }
-        } label: {
-            LoadableAvatarImage(url: context.viewState.userAvatarURL,
-                                name: context.viewState.userDisplayName,
-                                contentID: context.viewState.userID,
-                                avatarSize: .user(on: .home),
-                                imageProvider: context.imageProvider)
-                .accessibilityIdentifier(A11yIdentifiers.homeScreen.userAvatar)
-                .overlayBadge(10, isBadged: context.viewState.requiresExtraAccountSetup)
-                .compositingGroup()
-        }
-        .accessibilityLabel(L10n.a11yUserMenu)
-    }
-}