Showing the iOS default silhoutte when the user/room avatar is missing (#965)

* fix

* Element X app name

* project update

* improvement

ElementX/Sources/Application/AppCoordinator.swift

@@ -136,7 +136,7 @@ class AppCoordinator: AppCoordinatorProtocol, AuthenticationCoordinatorDelegate,
     }
     
     func shouldDisplayInAppNotification(_ service: NotificationManagerProtocol, content: UNNotificationContent) -> Bool {
-        guard let roomId = content.userInfo[NotificationConstants.UserInfoKey.roomIdentifier] as? String else {
+        guard let roomId = content.roomID else {
             return true
         }
         guard let userSessionFlowCoordinator else {

ElementX/Sources/Other/Extensions/UNNotificationContent.swift

@@ -123,7 +123,7 @@ extension UNMutableNotificationContent {
                        senderID: String,
                        senderName: String,
                        iconType: NotificationIconType) async throws -> UNMutableNotificationContent {
-        var image: INImage?
+        var image = INImage(named: "")
         if let mediaSource = iconType.mediaSource {
             switch await mediaProvider?.loadImageDataFromSource(mediaSource) {
             case .success(let data):
@@ -161,7 +161,7 @@ extension UNMutableNotificationContent {
                                          serviceName: nil,
                                          sender: sender,
                                          attachments: nil)
-        if speakableGroupName != nil, let image {
+        if speakableGroupName != nil {
             intent.setImage(image, forParameterNamed: \.speakableGroupName)
         }
 

ElementX/SupportingFiles/target.yml

@@ -74,7 +74,7 @@ targets:
 
     settings:
       base:
-        PRODUCT_NAME: ElementX
+        PRODUCT_NAME: $(APP_NAME)
         PRODUCT_BUNDLE_IDENTIFIER: $(BASE_BUNDLE_IDENTIFIER)
         MARKETING_VERSION: $(MARKETING_VERSION)
         CURRENT_PROJECT_VERSION: $(CURRENT_PROJECT_VERSION)