mirror of
https://github.com/Novaloop-AG/element-x-ios.git
synced 2026-11-05 20:09:04 +00:00
Clarify product input requirements and how to add translations for contributions. (#4849)
This commit is contained in:
+11
-3
@@ -1,8 +1,14 @@
|
|||||||
# Contributing code to Matrix
|
# Contributing to Element X iOS
|
||||||
|
|
||||||
Please read https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md.
|
Before opening a PR please make sure that there is a well defined issue. When adding a new feature or updating the user interface, the issue **must** have input from our Product team outlining the desired solution.
|
||||||
|
|
||||||
Element X iOS support can be found in this room: [](https://matrix.to/#/#element-x-ios:matrix.org).
|
Please note: [element-meta](https://github.com/element-hq/element-meta) is where we centralise all product level and cross platform requests. If the change you would like to make will create a disparity between platforms then there must also be a meta-issue before contributing.
|
||||||
|
|
||||||
|
Support can be found in [](https://matrix.to/#/#element-x-ios:matrix.org).
|
||||||
|
|
||||||
|
## Contributing code to Matrix
|
||||||
|
|
||||||
|
Please read https://github.com/element-hq/synapse/blob/master/CONTRIBUTING.md.
|
||||||
|
|
||||||
## Setting up a development environment
|
## Setting up a development environment
|
||||||
|
|
||||||
@@ -75,6 +81,8 @@ The project uses Localazy and is sharing its translations with the ElementX Andr
|
|||||||
|
|
||||||
Please read the [Android docs](https://github.com/element-hq/element-x-android/blob/develop/tools/localazy/README.md) for more information about how this works. Note: On iOS we don't have the additional step of filtering strings per module.
|
Please read the [Android docs](https://github.com/element-hq/element-x-android/blob/develop/tools/localazy/README.md) for more information about how this works. Note: On iOS we don't have the additional step of filtering strings per module.
|
||||||
|
|
||||||
|
Please do **not** manually edit the `Localizable.strings`, `Localizable.stringsdict` or `InfoPlist.strings` files! If your PR requires new strings to be added, add the `en` values to `Untranslated.strings`/`Untranslated.stringsdict` and one of the team will transfer them over to Localazy for you.
|
||||||
|
|
||||||
### Continuous Integration
|
### Continuous Integration
|
||||||
|
|
||||||
Element X uses Fastlane for running actions on the CI and tries to keep the configuration confined to either [fastlane](fastlane/Fastfile) or [xcodegen](project.yml).
|
Element X uses Fastlane for running actions on the CI and tries to keep the configuration confined to either [fastlane](fastlane/Fastfile) or [xcodegen](project.yml).
|
||||||
|
|||||||
Reference in New Issue
Block a user