Upgrade the project to use Xcode 15.4 (#3027)

* Update snapshots for Xcode 15.4

* Update CI.

* Fix crashing UI test.

* Fix compile error in Integration Tests.

* Try putting UI tests on GH runners again.

ElementX/Sources/Mocks/ClientProxyMock.swift

@@ -76,6 +76,8 @@ extension ClientProxyMock {
         recentlyVisitedRoomsReturnValue = .success([])
         recentConversationCounterpartsReturnValue = []
         
+        getElementWellKnownReturnValue = .success(nil)
+        
         loadMediaContentForSourceThrowableError = ClientProxyError.sdkError(ClientProxyMockError.generic)
         loadMediaThumbnailForSourceWidthHeightThrowableError = ClientProxyError.sdkError(ClientProxyMockError.generic)
         loadMediaFileForSourceBodyThrowableError = ClientProxyError.sdkError(ClientProxyMockError.generic)

ElementX/Sources/Other/SwiftUI/Styles/FormButtonStyles.swift

@@ -31,6 +31,7 @@ struct FormActionButtonStyle: ButtonStyle {
             Text(title)
                 .foregroundColor(.compound.textPrimary)
                 .font(.compound.bodyLG)
+                .textCase(.none)
         }
         .padding(.horizontal, 4)
         .padding(.vertical, 8)

ElementX/Sources/Screens/CreateRoom/View/CreateRoomScreen.swift

@@ -197,11 +197,11 @@ struct CreateRoom_Previews: PreviewProvider, TestablePreview {
     }()
     
     static var previews: some View {
-        NavigationView {
+        NavigationStack {
             CreateRoomScreen(context: viewModel.context)
         }
         .previewDisplayName("Create Room")
-        NavigationView {
+        NavigationStack {
             CreateRoomScreen(context: emtpyViewModel.context)
         }
         .previewDisplayName("Create Room without users")

ElementX/Sources/Screens/EmojiPickerScreen/View/EmojiPickerScreen.swift

@@ -95,7 +95,14 @@ struct EmojiPickerScreen_Previews: PreviewProvider, TestablePreview {
     static var previews: some View {
         EmojiPickerScreen(context: viewModel.context, selectedEmojis: ["😀", "😄"])
             .previewDisplayName("Screen")
-        
+            .snapshot(delay: 0.5)
+    }
+}
+
+struct EmojiPickerScreenSheet_Previews: PreviewProvider {
+    static let viewModel = EmojiPickerScreenViewModel(emojiProvider: EmojiProvider())
+    
+    static var previews: some View {
         Text("Timeline view")
             .sheet(isPresented: .constant(true)) {
                 EmojiPickerScreen(context: viewModel.context, selectedEmojis: ["😀", "😄"])

ElementX/Sources/Screens/HomeScreen/View/Filters/RoomListFiltersEmptyStateView.swift

@@ -68,6 +68,7 @@ struct RoomListFiltersEmptyStateView_Previews: PreviewProvider, TestablePreview
             }
             RoomListFiltersEmptyStateView(state: .init(activeFilters: [.people, .favourites]))
         }
+        .padding(.bottom)
         .previewLayout(.sizeThatFits)
     }
 }

ElementX/Sources/Screens/InviteUsersScreen/View/InviteUsersScreen.swift

@@ -169,7 +169,7 @@ struct InviteUsersScreen_Previews: PreviewProvider, TestablePreview {
     }()
     
     static var previews: some View {
-        NavigationView {
+        NavigationStack {
             InviteUsersScreen(context: viewModel.context)
         }
     }

ElementX/Sources/Screens/StartChatScreen/View/StartChatScreen.swift

@@ -140,7 +140,7 @@ struct StartChatScreen_Previews: PreviewProvider, TestablePreview {
     }()
     
     static var previews: some View {
-        NavigationView {
+        NavigationStack {
             StartChatScreen(context: viewModel.context)
         }
     }

ElementX/Sources/Services/Analytics/Signposter.swift

@@ -25,7 +25,7 @@ class Signposter {
     private let logger = Logger(subsystem: subsystem, category: category)
     
     /// Signpost name constants.
-    private enum Name {
+    enum Name {
         static let login: StaticString = "Login"
         static let firstSync: StaticString = "FirstSync"
         static let firstRooms: StaticString = "FirstRooms"

ElementX/Sources/UITests/UITestsAppCoordinator.swift

@@ -520,6 +520,9 @@ class MockScreen: Identifiable {
             let clientProxy = ClientProxyMock(.init(userID: "@mock:client.com", roomSummaryProvider: RoomSummaryProviderMock(.init(state: .loaded(.mockRooms)))))
             ServiceLocator.shared.settings.migratedAccounts[clientProxy.userID] = true
             
+            let appMediator = AppMediatorMock.default
+            appMediator.underlyingWindowManager = windowManager
+            
             let flowCoordinator = UserSessionFlowCoordinator(userSession: UserSessionMock(.init(clientProxy: clientProxy)),
                                                              navigationRootCoordinator: navigationRootCoordinator,
                                                              appLockService: AppLockService(keychainController: KeychainControllerMock(),
@@ -527,7 +530,7 @@ class MockScreen: Identifiable {
                                                              bugReportService: BugReportServiceMock(),
                                                              elementCallService: ElementCallServiceMock(.init()),
                                                              roomTimelineControllerFactory: RoomTimelineControllerFactoryMock(configuration: .init()),
-                                                             appMediator: AppMediatorMock.default,
+                                                             appMediator: appMediator,
                                                              appSettings: appSettings,
                                                              analytics: ServiceLocator.shared.analytics,
                                                              notificationManager: NotificationManagerMock(),