Filters, Mark Unread/Read/Favourites FF removals + code and tests clean up (#2541)

UnitTests/Sources/HomeScreenViewModelTests.swift

@@ -28,7 +28,6 @@ class HomeScreenViewModelTests: XCTestCase {
     var roomSummaryProvider: RoomSummaryProviderMock!
     
     override func setUpWithError() throws {
-        ServiceLocator.shared.settings.roomListFiltersEnabled = true
         cancellables.removeAll()
         roomSummaryProvider = RoomSummaryProviderMock(.init(state: .loaded(.mockRooms)))
         clientProxy = ClientProxyMock(.init(userID: "@mock:client.com", roomSummaryProvider: roomSummaryProvider))
@@ -179,7 +178,6 @@ class HomeScreenViewModelTests: XCTestCase {
         try await Task.sleep(for: .milliseconds(100))
         XCTAssertEqual(roomSummaryProvider.roomListPublisher.value.first?.name, "Prelude to Foundation")
         XCTAssertEqual(roomSummaryProvider.roomListPublisher.value.count, 1)
-        XCTAssertFalse(context.viewState.shouldShowFilters)
     }
     
     func testFiltersEmptyState() async throws {

UnitTests/Sources/InviteUsersViewModelTests.swift

@@ -96,13 +96,11 @@ class InviteUsersScreenViewModelTests: XCTestCase {
     private func setupWithRoomType(roomType: InviteUsersScreenRoomType) {
         let usersSubject = CurrentValueSubject<[UserProfileProxy], Never>([])
         userDiscoveryService = UserDiscoveryServiceMock()
-        userDiscoveryService.fetchSuggestionsReturnValue = .success([])
         userDiscoveryService.searchProfilesWithReturnValue = .success([])
         usersSubject.send([])
         let viewModel = InviteUsersScreenViewModel(selectedUsers: usersSubject.asCurrentValuePublisher(),
                                                    roomType: roomType, mediaProvider: MockMediaProvider(),
                                                    userDiscoveryService: userDiscoveryService,
-                                                   appSettings: ServiceLocator.shared.settings,
                                                    userIndicatorController: UserIndicatorControllerMock())
         viewModel.state.usersSection = .init(type: .suggestions, users: [.mockAlice, .mockBob, .mockCharlie])
         self.viewModel = viewModel

UnitTests/Sources/StartChatViewModelTests.swift

@@ -31,13 +31,11 @@ class StartChatScreenViewModelTests: XCTestCase {
     override func setUpWithError() throws {
         clientProxy = .init(.init(userID: ""))
         userDiscoveryService = UserDiscoveryServiceMock()
-        userDiscoveryService.fetchSuggestionsReturnValue = .success([])
         userDiscoveryService.searchProfilesWithReturnValue = .success([])
         let userSession = MockUserSession(clientProxy: clientProxy,
                                           mediaProvider: MockMediaProvider(),
                                           voiceMessageMediaManager: VoiceMessageMediaManagerMock())
         viewModel = StartChatScreenViewModel(userSession: userSession,
-                                             userSuggestionsEnabled: true,
                                              analytics: ServiceLocator.shared.analytics,
                                              userIndicatorController: UserIndicatorControllerMock(),
                                              userDiscoveryService: userDiscoveryService)
@@ -46,7 +44,6 @@ class StartChatScreenViewModelTests: XCTestCase {
     func testQueryShowingNoResults() async throws {
         await search(query: "A")
         XCTAssertEqual(context.viewState.usersSection.type, .suggestions)
-        XCTAssertTrue(userDiscoveryService.fetchSuggestionsCalled)
         
         await search(query: "AA")
         XCTAssertEqual(context.viewState.usersSection.type, .suggestions)