mirror of
https://github.com/Novaloop-AG/element-x-ios.git
synced 2026-11-03 16:10:20 +00:00
Show internet connection warning when uploading keys on log out. (#4027)
* Show the key upload progress when waiting to log out. Add some basic view model tests too. * Show a network suggestion if key upload doesn't report any progress during logout.
This commit is contained in:
@@ -14154,15 +14154,15 @@ class SecureBackupControllerMock: SecureBackupControllerProtocol, @unchecked Sen
|
|||||||
}
|
}
|
||||||
//MARK: - waitForKeyBackupUpload
|
//MARK: - waitForKeyBackupUpload
|
||||||
|
|
||||||
var waitForKeyBackupUploadUnderlyingCallsCount = 0
|
var waitForKeyBackupUploadUploadStateSubjectUnderlyingCallsCount = 0
|
||||||
var waitForKeyBackupUploadCallsCount: Int {
|
var waitForKeyBackupUploadUploadStateSubjectCallsCount: Int {
|
||||||
get {
|
get {
|
||||||
if Thread.isMainThread {
|
if Thread.isMainThread {
|
||||||
return waitForKeyBackupUploadUnderlyingCallsCount
|
return waitForKeyBackupUploadUploadStateSubjectUnderlyingCallsCount
|
||||||
} else {
|
} else {
|
||||||
var returnValue: Int? = nil
|
var returnValue: Int? = nil
|
||||||
DispatchQueue.main.sync {
|
DispatchQueue.main.sync {
|
||||||
returnValue = waitForKeyBackupUploadUnderlyingCallsCount
|
returnValue = waitForKeyBackupUploadUploadStateSubjectUnderlyingCallsCount
|
||||||
}
|
}
|
||||||
|
|
||||||
return returnValue!
|
return returnValue!
|
||||||
@@ -14170,27 +14170,29 @@ class SecureBackupControllerMock: SecureBackupControllerProtocol, @unchecked Sen
|
|||||||
}
|
}
|
||||||
set {
|
set {
|
||||||
if Thread.isMainThread {
|
if Thread.isMainThread {
|
||||||
waitForKeyBackupUploadUnderlyingCallsCount = newValue
|
waitForKeyBackupUploadUploadStateSubjectUnderlyingCallsCount = newValue
|
||||||
} else {
|
} else {
|
||||||
DispatchQueue.main.sync {
|
DispatchQueue.main.sync {
|
||||||
waitForKeyBackupUploadUnderlyingCallsCount = newValue
|
waitForKeyBackupUploadUploadStateSubjectUnderlyingCallsCount = newValue
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
var waitForKeyBackupUploadCalled: Bool {
|
var waitForKeyBackupUploadUploadStateSubjectCalled: Bool {
|
||||||
return waitForKeyBackupUploadCallsCount > 0
|
return waitForKeyBackupUploadUploadStateSubjectCallsCount > 0
|
||||||
}
|
}
|
||||||
|
var waitForKeyBackupUploadUploadStateSubjectReceivedUploadStateSubject: CurrentValueSubject<SecureBackupSteadyState, Never>?
|
||||||
|
var waitForKeyBackupUploadUploadStateSubjectReceivedInvocations: [CurrentValueSubject<SecureBackupSteadyState, Never>] = []
|
||||||
|
|
||||||
var waitForKeyBackupUploadUnderlyingReturnValue: Result<Void, SecureBackupControllerError>!
|
var waitForKeyBackupUploadUploadStateSubjectUnderlyingReturnValue: Result<Void, SecureBackupControllerError>!
|
||||||
var waitForKeyBackupUploadReturnValue: Result<Void, SecureBackupControllerError>! {
|
var waitForKeyBackupUploadUploadStateSubjectReturnValue: Result<Void, SecureBackupControllerError>! {
|
||||||
get {
|
get {
|
||||||
if Thread.isMainThread {
|
if Thread.isMainThread {
|
||||||
return waitForKeyBackupUploadUnderlyingReturnValue
|
return waitForKeyBackupUploadUploadStateSubjectUnderlyingReturnValue
|
||||||
} else {
|
} else {
|
||||||
var returnValue: Result<Void, SecureBackupControllerError>? = nil
|
var returnValue: Result<Void, SecureBackupControllerError>? = nil
|
||||||
DispatchQueue.main.sync {
|
DispatchQueue.main.sync {
|
||||||
returnValue = waitForKeyBackupUploadUnderlyingReturnValue
|
returnValue = waitForKeyBackupUploadUploadStateSubjectUnderlyingReturnValue
|
||||||
}
|
}
|
||||||
|
|
||||||
return returnValue!
|
return returnValue!
|
||||||
@@ -14198,22 +14200,26 @@ class SecureBackupControllerMock: SecureBackupControllerProtocol, @unchecked Sen
|
|||||||
}
|
}
|
||||||
set {
|
set {
|
||||||
if Thread.isMainThread {
|
if Thread.isMainThread {
|
||||||
waitForKeyBackupUploadUnderlyingReturnValue = newValue
|
waitForKeyBackupUploadUploadStateSubjectUnderlyingReturnValue = newValue
|
||||||
} else {
|
} else {
|
||||||
DispatchQueue.main.sync {
|
DispatchQueue.main.sync {
|
||||||
waitForKeyBackupUploadUnderlyingReturnValue = newValue
|
waitForKeyBackupUploadUploadStateSubjectUnderlyingReturnValue = newValue
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
var waitForKeyBackupUploadClosure: (() async -> Result<Void, SecureBackupControllerError>)?
|
var waitForKeyBackupUploadUploadStateSubjectClosure: ((CurrentValueSubject<SecureBackupSteadyState, Never>) async -> Result<Void, SecureBackupControllerError>)?
|
||||||
|
|
||||||
func waitForKeyBackupUpload() async -> Result<Void, SecureBackupControllerError> {
|
func waitForKeyBackupUpload(uploadStateSubject: CurrentValueSubject<SecureBackupSteadyState, Never>) async -> Result<Void, SecureBackupControllerError> {
|
||||||
waitForKeyBackupUploadCallsCount += 1
|
waitForKeyBackupUploadUploadStateSubjectCallsCount += 1
|
||||||
if let waitForKeyBackupUploadClosure = waitForKeyBackupUploadClosure {
|
waitForKeyBackupUploadUploadStateSubjectReceivedUploadStateSubject = uploadStateSubject
|
||||||
return await waitForKeyBackupUploadClosure()
|
DispatchQueue.main.async {
|
||||||
|
self.waitForKeyBackupUploadUploadStateSubjectReceivedInvocations.append(uploadStateSubject)
|
||||||
|
}
|
||||||
|
if let waitForKeyBackupUploadUploadStateSubjectClosure = waitForKeyBackupUploadUploadStateSubjectClosure {
|
||||||
|
return await waitForKeyBackupUploadUploadStateSubjectClosure(uploadStateSubject)
|
||||||
} else {
|
} else {
|
||||||
return waitForKeyBackupUploadReturnValue
|
return waitForKeyBackupUploadUploadStateSubjectReturnValue
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
+3
-2
@@ -13,9 +13,10 @@ enum SecureBackupLogoutConfirmationScreenViewModelAction {
|
|||||||
case logout
|
case logout
|
||||||
}
|
}
|
||||||
|
|
||||||
enum SecureBackupLogoutConfirmationScreenViewMode {
|
enum SecureBackupLogoutConfirmationScreenViewMode: Equatable {
|
||||||
case saveRecoveryKey
|
case saveRecoveryKey
|
||||||
case backupOngoing
|
case waitingToStart(hasStalled: Bool)
|
||||||
|
case backupOngoing(progress: Double)
|
||||||
case offline
|
case offline
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
+41
-18
@@ -14,9 +14,13 @@ class SecureBackupLogoutConfirmationScreenViewModel: SecureBackupLogoutConfirmat
|
|||||||
private let secureBackupController: SecureBackupControllerProtocol
|
private let secureBackupController: SecureBackupControllerProtocol
|
||||||
private let appMediator: AppMediatorProtocol
|
private let appMediator: AppMediatorProtocol
|
||||||
|
|
||||||
|
private let backupUploadStateSubject: CurrentValueSubject<SecureBackupSteadyState, Never> = .init(.waiting)
|
||||||
|
|
||||||
// periphery:ignore - auto cancels when reassigned
|
// periphery:ignore - auto cancels when reassigned
|
||||||
@CancellableTask
|
@CancellableTask
|
||||||
private var keyUploadWaitingTask: Task<Void, Never>?
|
private var keyUploadWaitingTask: Task<Void, Never>?
|
||||||
|
@CancellableTask
|
||||||
|
private var keyUploadStalledTask: Task<Void, Error>?
|
||||||
|
|
||||||
private var actionsSubject: PassthroughSubject<SecureBackupLogoutConfirmationScreenViewModelAction, Never> = .init()
|
private var actionsSubject: PassthroughSubject<SecureBackupLogoutConfirmationScreenViewModelAction, Never> = .init()
|
||||||
var actions: AnyPublisher<SecureBackupLogoutConfirmationScreenViewModelAction, Never> {
|
var actions: AnyPublisher<SecureBackupLogoutConfirmationScreenViewModelAction, Never> {
|
||||||
@@ -29,19 +33,11 @@ class SecureBackupLogoutConfirmationScreenViewModel: SecureBackupLogoutConfirmat
|
|||||||
|
|
||||||
super.init(initialViewState: .init(mode: .saveRecoveryKey))
|
super.init(initialViewState: .init(mode: .saveRecoveryKey))
|
||||||
|
|
||||||
appMediator.networkMonitor.reachabilityPublisher
|
backupUploadStateSubject.combineLatest(appMediator.networkMonitor.reachabilityPublisher)
|
||||||
.receive(on: DispatchQueue.main)
|
.receive(on: DispatchQueue.main)
|
||||||
.sink { [weak self] reachability in
|
.sink { [weak self] backupState, reachability in
|
||||||
guard let self,
|
guard let self, state.mode != .saveRecoveryKey else { return }
|
||||||
state.mode != .saveRecoveryKey else {
|
updateMode(backupState: backupState, reachability: reachability)
|
||||||
return
|
|
||||||
}
|
|
||||||
|
|
||||||
if reachability == .reachable {
|
|
||||||
state.mode = .backupOngoing
|
|
||||||
} else {
|
|
||||||
state.mode = .offline
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
.store(in: &cancellables)
|
.store(in: &cancellables)
|
||||||
}
|
}
|
||||||
@@ -65,29 +61,56 @@ class SecureBackupLogoutConfirmationScreenViewModel: SecureBackupLogoutConfirmat
|
|||||||
// MARK: - Private
|
// MARK: - Private
|
||||||
|
|
||||||
private func attemptLogout() {
|
private func attemptLogout() {
|
||||||
if state.mode == .saveRecoveryKey {
|
if case .saveRecoveryKey = state.mode {
|
||||||
state.mode = appMediator.networkMonitor.reachabilityPublisher.value == .reachable ? .backupOngoing : .offline
|
updateMode(backupState: backupUploadStateSubject.value, reachability: appMediator.networkMonitor.reachabilityPublisher.value)
|
||||||
|
|
||||||
keyUploadWaitingTask = Task {
|
keyUploadWaitingTask = Task {
|
||||||
var result = await secureBackupController.waitForKeyBackupUpload()
|
var result = await secureBackupController.waitForKeyBackupUpload(uploadStateSubject: backupUploadStateSubject)
|
||||||
|
|
||||||
|
guard !Task.isCancelled else { return }
|
||||||
|
|
||||||
if case .failure = result {
|
if case .failure = result {
|
||||||
// Retry the upload first, conditions might have changed.
|
// Retry the upload first, conditions might have changed.
|
||||||
result = await secureBackupController.waitForKeyBackupUpload()
|
result = await secureBackupController.waitForKeyBackupUpload(uploadStateSubject: backupUploadStateSubject)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
guard !Task.isCancelled else { return }
|
||||||
|
|
||||||
guard case .success = result else {
|
guard case .success = result else {
|
||||||
MXLog.error("Aborting logout due to failure waiting for backup upload.")
|
MXLog.error("Aborting logout due to failure waiting for backup upload.")
|
||||||
state.bindings.alertInfo = .init(id: .backupUploadFailed)
|
state.bindings.alertInfo = .init(id: .backupUploadFailed)
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
|
|
||||||
guard !Task.isCancelled else { return }
|
|
||||||
|
|
||||||
actionsSubject.send(.logout)
|
actionsSubject.send(.logout)
|
||||||
}
|
}
|
||||||
} else {
|
} else {
|
||||||
actionsSubject.send(.logout)
|
actionsSubject.send(.logout)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
private func updateMode(backupState: SecureBackupSteadyState, reachability: NetworkMonitorReachability) {
|
||||||
|
switch (backupState, reachability) {
|
||||||
|
case (.waiting, .reachable):
|
||||||
|
state.mode = .waitingToStart(hasStalled: false)
|
||||||
|
showAsStalledAfterTimeout()
|
||||||
|
case (.uploading(let uploadedKeyCount, let totalKeyCount), .reachable):
|
||||||
|
state.mode = .backupOngoing(progress: Double(uploadedKeyCount) / Double(totalKeyCount))
|
||||||
|
case (.error, .reachable):
|
||||||
|
break // Nothing to do here, it will be handled with the result.
|
||||||
|
case (.done, .reachable):
|
||||||
|
state.mode = .backupOngoing(progress: 1.0)
|
||||||
|
case (_, .unreachable):
|
||||||
|
state.mode = .offline
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/// If we stay in the waiting state for more than 2-seconds we ask the user to check their connection.
|
||||||
|
private func showAsStalledAfterTimeout() {
|
||||||
|
keyUploadStalledTask = Task { [weak self] in
|
||||||
|
try await Task.sleep(for: .seconds(2))
|
||||||
|
guard let self, case .waitingToStart(hasStalled: false) = state.mode else { return }
|
||||||
|
state.mode = .waitingToStart(hasStalled: true)
|
||||||
|
}
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
+62
-9
@@ -40,16 +40,25 @@ struct SecureBackupLogoutConfirmationScreen: View {
|
|||||||
.font(.compound.bodyMD)
|
.font(.compound.bodyMD)
|
||||||
.multilineTextAlignment(.center)
|
.multilineTextAlignment(.center)
|
||||||
|
|
||||||
if context.viewState.mode == .backupOngoing {
|
if case let .waitingToStart(hasStalled) = context.viewState.mode {
|
||||||
Spacer()
|
Spacer()
|
||||||
ProgressView()
|
ProgressView()
|
||||||
|
|
||||||
|
if hasStalled {
|
||||||
|
Text(L10n.commonPleaseCheckInternetConnection)
|
||||||
|
.font(.compound.bodySM)
|
||||||
|
.foregroundColor(.compound.textPrimary)
|
||||||
|
}
|
||||||
|
} else if case let .backupOngoing(progress) = context.viewState.mode {
|
||||||
|
Spacer()
|
||||||
|
ProgressView(value: progress)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@ViewBuilder
|
@ViewBuilder
|
||||||
private var footer: some View {
|
private var footer: some View {
|
||||||
VStack(spacing: 16.0) {
|
VStack(spacing: 16.0) {
|
||||||
if context.viewState.mode == .saveRecoveryKey {
|
if case .saveRecoveryKey = context.viewState.mode {
|
||||||
Button {
|
Button {
|
||||||
context.send(viewAction: .settings)
|
context.send(viewAction: .settings)
|
||||||
} label: {
|
} label: {
|
||||||
@@ -80,7 +89,7 @@ struct SecureBackupLogoutConfirmationScreen: View {
|
|||||||
switch context.viewState.mode {
|
switch context.viewState.mode {
|
||||||
case .saveRecoveryKey:
|
case .saveRecoveryKey:
|
||||||
return L10n.screenSignoutSaveRecoveryKeyTitle
|
return L10n.screenSignoutSaveRecoveryKeyTitle
|
||||||
case .backupOngoing:
|
case .waitingToStart, .backupOngoing:
|
||||||
return L10n.screenSignoutKeyBackupOngoingTitle
|
return L10n.screenSignoutKeyBackupOngoingTitle
|
||||||
case .offline:
|
case .offline:
|
||||||
return L10n.screenSignoutKeyBackupOfflineTitle
|
return L10n.screenSignoutKeyBackupOfflineTitle
|
||||||
@@ -91,7 +100,7 @@ struct SecureBackupLogoutConfirmationScreen: View {
|
|||||||
switch context.viewState.mode {
|
switch context.viewState.mode {
|
||||||
case .saveRecoveryKey:
|
case .saveRecoveryKey:
|
||||||
return L10n.screenSignoutSaveRecoveryKeySubtitle
|
return L10n.screenSignoutSaveRecoveryKeySubtitle
|
||||||
case .backupOngoing:
|
case .waitingToStart, .backupOngoing:
|
||||||
return L10n.screenSignoutKeyBackupOngoingSubtitle
|
return L10n.screenSignoutKeyBackupOngoingSubtitle
|
||||||
case .offline:
|
case .offline:
|
||||||
return L10n.screenSignoutKeyBackupOfflineSubtitle
|
return L10n.screenSignoutKeyBackupOfflineSubtitle
|
||||||
@@ -102,25 +111,69 @@ struct SecureBackupLogoutConfirmationScreen: View {
|
|||||||
// MARK: - Previews
|
// MARK: - Previews
|
||||||
|
|
||||||
struct SecureBackupLogoutConfirmationScreen_Previews: PreviewProvider, TestablePreview {
|
struct SecureBackupLogoutConfirmationScreen_Previews: PreviewProvider, TestablePreview {
|
||||||
static let viewModel = buildViewModel()
|
static let viewModel = makeViewModel(mode: .saveRecoveryKey)
|
||||||
|
static let waitingViewModel = makeViewModel(mode: .waitingToStart(hasStalled: false))
|
||||||
|
static let ongoingViewModel = makeViewModel(mode: .backupOngoing(progress: 0.5))
|
||||||
|
static let offlineViewModel = makeViewModel(mode: .offline)
|
||||||
|
|
||||||
static var previews: some View {
|
static var previews: some View {
|
||||||
NavigationStack {
|
NavigationStack {
|
||||||
SecureBackupLogoutConfirmationScreen(context: viewModel.context)
|
SecureBackupLogoutConfirmationScreen(context: viewModel.context)
|
||||||
}
|
}
|
||||||
|
.previewDisplayName("Confirmation")
|
||||||
|
|
||||||
|
NavigationStack {
|
||||||
|
SecureBackupLogoutConfirmationScreen(context: waitingViewModel.context)
|
||||||
|
}
|
||||||
|
.previewDisplayName("Waiting")
|
||||||
|
.snapshotPreferences(expect: waitingViewModel.context.$viewState.map { $0.mode == .waitingToStart(hasStalled: false) })
|
||||||
|
|
||||||
|
NavigationStack {
|
||||||
|
SecureBackupLogoutConfirmationScreen(context: ongoingViewModel.context)
|
||||||
|
}
|
||||||
|
.previewDisplayName("Ongoing")
|
||||||
|
.snapshotPreferences(expect: ongoingViewModel.context.$viewState.map { $0.mode == .backupOngoing(progress: 0.5) })
|
||||||
|
|
||||||
|
// Uses the same view model as Waiting but with a different expectation.
|
||||||
|
NavigationStack {
|
||||||
|
SecureBackupLogoutConfirmationScreen(context: waitingViewModel.context)
|
||||||
|
}
|
||||||
|
.previewDisplayName("Stalled")
|
||||||
|
.snapshotPreferences(expect: waitingViewModel.context.$viewState.map { $0.mode == .waitingToStart(hasStalled: true) })
|
||||||
|
|
||||||
|
NavigationStack {
|
||||||
|
SecureBackupLogoutConfirmationScreen(context: offlineViewModel.context)
|
||||||
|
}
|
||||||
|
.previewDisplayName("Offline")
|
||||||
|
.snapshotPreferences(expect: offlineViewModel.context.$viewState.map { $0.mode == .offline })
|
||||||
}
|
}
|
||||||
|
|
||||||
static func buildViewModel() -> SecureBackupLogoutConfirmationScreenViewModelType {
|
static func makeViewModel(mode: SecureBackupLogoutConfirmationScreenViewMode) -> SecureBackupLogoutConfirmationScreenViewModel {
|
||||||
let secureBackupController = SecureBackupControllerMock()
|
let secureBackupController = SecureBackupControllerMock()
|
||||||
secureBackupController.underlyingKeyBackupState = CurrentValueSubject<SecureBackupKeyBackupState, Never>(.enabled).asCurrentValuePublisher()
|
secureBackupController.underlyingKeyBackupState = CurrentValueSubject<SecureBackupKeyBackupState, Never>(.enabled).asCurrentValuePublisher()
|
||||||
|
|
||||||
|
secureBackupController.waitForKeyBackupUploadUploadStateSubjectClosure = { uploadStateSubject in
|
||||||
|
if case .backupOngoing = mode {
|
||||||
|
uploadStateSubject.send(.uploading(uploadedKeyCount: 50, totalKeyCount: 100))
|
||||||
|
}
|
||||||
|
|
||||||
|
return .success(())
|
||||||
|
}
|
||||||
|
|
||||||
|
let reachability: NetworkMonitorReachability = mode == .offline ? .unreachable : .reachable
|
||||||
let networkMonitor = NetworkMonitorMock()
|
let networkMonitor = NetworkMonitorMock()
|
||||||
networkMonitor.underlyingReachabilityPublisher = CurrentValueSubject<NetworkMonitorReachability, Never>(.reachable).asCurrentValuePublisher()
|
networkMonitor.underlyingReachabilityPublisher = CurrentValueSubject<NetworkMonitorReachability, Never>(reachability).asCurrentValuePublisher()
|
||||||
|
|
||||||
let appMediator = AppMediatorMock()
|
let appMediator = AppMediatorMock()
|
||||||
appMediator.underlyingNetworkMonitor = networkMonitor
|
appMediator.underlyingNetworkMonitor = networkMonitor
|
||||||
|
|
||||||
return SecureBackupLogoutConfirmationScreenViewModel(secureBackupController: secureBackupController,
|
let viewModel = SecureBackupLogoutConfirmationScreenViewModel(secureBackupController: secureBackupController,
|
||||||
appMediator: appMediator)
|
appMediator: appMediator)
|
||||||
|
|
||||||
|
if mode != .saveRecoveryKey {
|
||||||
|
viewModel.context.send(viewAction: .logout)
|
||||||
|
}
|
||||||
|
|
||||||
|
return viewModel
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -35,7 +35,7 @@ class SecureBackupController: SecureBackupControllerProtocol {
|
|||||||
init(encryption: Encryption) {
|
init(encryption: Encryption) {
|
||||||
self.encryption = encryption
|
self.encryption = encryption
|
||||||
|
|
||||||
backupStateListenerTaskHandle = encryption.backupStateListener(listener: SecureBackupControllerBackupStateListener { [weak self] state in
|
backupStateListenerTaskHandle = encryption.backupStateListener(listener: SecureBackupControllerListener { [weak self] state in
|
||||||
guard let self else { return }
|
guard let self else { return }
|
||||||
|
|
||||||
switch state {
|
switch state {
|
||||||
@@ -62,7 +62,7 @@ class SecureBackupController: SecureBackupControllerProtocol {
|
|||||||
}
|
}
|
||||||
})
|
})
|
||||||
|
|
||||||
recoveryStateListenerTaskHandle = encryption.recoveryStateListener(listener: SecureBackupRecoveryStateListener { [weak self] state in
|
recoveryStateListenerTaskHandle = encryption.recoveryStateListener(listener: SecureBackupControllerListener { [weak self] state in
|
||||||
guard let self else { return }
|
guard let self else { return }
|
||||||
|
|
||||||
switch state {
|
switch state {
|
||||||
@@ -121,7 +121,7 @@ class SecureBackupController: SecureBackupControllerProtocol {
|
|||||||
MXLog.info("Enabling recovery")
|
MXLog.info("Enabling recovery")
|
||||||
|
|
||||||
var keyUploadErrored = false
|
var keyUploadErrored = false
|
||||||
let recoveryKey = try await encryption.enableRecovery(waitForBackupsToUpload: false, passphrase: nil, progressListener: SecureBackupEnableRecoveryProgressListener { [weak self] state in
|
let recoveryKey = try await encryption.enableRecovery(waitForBackupsToUpload: false, passphrase: nil, progressListener: SecureBackupControllerListener { [weak self] state in
|
||||||
guard let self else { return }
|
guard let self else { return }
|
||||||
|
|
||||||
switch state {
|
switch state {
|
||||||
@@ -154,10 +154,19 @@ class SecureBackupController: SecureBackupControllerProtocol {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
func waitForKeyBackupUpload() async -> Result<Void, SecureBackupControllerError> {
|
func waitForKeyBackupUpload(uploadStateSubject: CurrentValueSubject<SecureBackupSteadyState, Never>) async -> Result<Void, SecureBackupControllerError> {
|
||||||
do {
|
do {
|
||||||
MXLog.info("Waiting for backup upload steady state")
|
MXLog.info("Waiting for backup upload steady state")
|
||||||
try await encryption.waitForBackupUploadSteadyState(progressListener: nil)
|
try await encryption.waitForBackupUploadSteadyState(progressListener: SecureBackupControllerListener { state in
|
||||||
|
let uploadState: SecureBackupSteadyState = switch state {
|
||||||
|
case .waiting: .waiting
|
||||||
|
case .uploading(let backedUpCount, let totalCount): .uploading(uploadedKeyCount: Int(backedUpCount), totalKeyCount: Int(totalCount))
|
||||||
|
case .error: .error
|
||||||
|
case .done: .done
|
||||||
|
}
|
||||||
|
|
||||||
|
uploadStateSubject.send(uploadState)
|
||||||
|
})
|
||||||
return .success(())
|
return .success(())
|
||||||
} catch let error as SteadyStateError {
|
} catch let error as SteadyStateError {
|
||||||
MXLog.error("Failed waiting for backup upload steady state with error: \(error)")
|
MXLog.error("Failed waiting for backup upload steady state with error: \(error)")
|
||||||
@@ -202,38 +211,19 @@ class SecureBackupController: SecureBackupControllerProtocol {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
private final class SecureBackupControllerBackupStateListener: BackupStateListener {
|
private final class SecureBackupControllerListener<T> {
|
||||||
private let onUpdateClosure: (BackupState) -> Void
|
private let onUpdateClosure: (T) -> Void
|
||||||
|
|
||||||
init(_ onUpdateClosure: @escaping (BackupState) -> Void) {
|
init(_ onUpdateClosure: @escaping (T) -> Void) {
|
||||||
self.onUpdateClosure = onUpdateClosure
|
self.onUpdateClosure = onUpdateClosure
|
||||||
}
|
}
|
||||||
|
|
||||||
func onUpdate(status: BackupState) {
|
func onUpdate(status: T) {
|
||||||
onUpdateClosure(status)
|
onUpdateClosure(status)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
private final class SecureBackupRecoveryStateListener: RecoveryStateListener {
|
extension SecureBackupControllerListener: BackupStateListener where T == BackupState { }
|
||||||
private let onUpdateClosure: (RecoveryState) -> Void
|
extension SecureBackupControllerListener: RecoveryStateListener where T == RecoveryState { }
|
||||||
|
extension SecureBackupControllerListener: EnableRecoveryProgressListener where T == EnableRecoveryProgress { }
|
||||||
init(_ onUpdateClosure: @escaping (RecoveryState) -> Void) {
|
extension SecureBackupControllerListener: BackupSteadyStateListener where T == BackupUploadState { }
|
||||||
self.onUpdateClosure = onUpdateClosure
|
|
||||||
}
|
|
||||||
|
|
||||||
func onUpdate(status: RecoveryState) {
|
|
||||||
onUpdateClosure(status)
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
private final class SecureBackupEnableRecoveryProgressListener: EnableRecoveryProgressListener {
|
|
||||||
private let onUpdateClosure: (EnableRecoveryProgress) -> Void
|
|
||||||
|
|
||||||
init(_ onUpdateClosure: @escaping (EnableRecoveryProgress) -> Void) {
|
|
||||||
self.onUpdateClosure = onUpdateClosure
|
|
||||||
}
|
|
||||||
|
|
||||||
func onUpdate(status: EnableRecoveryProgress) {
|
|
||||||
onUpdateClosure(status)
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|||||||
@@ -27,6 +27,14 @@ enum SecureBackupKeyBackupState {
|
|||||||
case disabling
|
case disabling
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/// Represents the progress towards a complete backup before logging out.
|
||||||
|
enum SecureBackupSteadyState {
|
||||||
|
case waiting
|
||||||
|
case uploading(uploadedKeyCount: Int, totalKeyCount: Int)
|
||||||
|
case error
|
||||||
|
case done
|
||||||
|
}
|
||||||
|
|
||||||
enum SecureBackupControllerError: Error {
|
enum SecureBackupControllerError: Error {
|
||||||
case failedEnablingBackup
|
case failedEnablingBackup
|
||||||
case failedDisablingBackup
|
case failedDisablingBackup
|
||||||
@@ -49,5 +57,5 @@ protocol SecureBackupControllerProtocol {
|
|||||||
func generateRecoveryKey() async -> Result<String, SecureBackupControllerError>
|
func generateRecoveryKey() async -> Result<String, SecureBackupControllerError>
|
||||||
func confirmRecoveryKey(_ key: String) async -> Result<Void, SecureBackupControllerError>
|
func confirmRecoveryKey(_ key: String) async -> Result<Void, SecureBackupControllerError>
|
||||||
|
|
||||||
func waitForKeyBackupUpload() async -> Result<Void, SecureBackupControllerError>
|
func waitForKeyBackupUpload(uploadStateSubject: CurrentValueSubject<SecureBackupSteadyState, Never>) async -> Result<Void, SecureBackupControllerError>
|
||||||
}
|
}
|
||||||
|
|||||||
+3
@@ -0,0 +1,3 @@
|
|||||||
|
version https://git-lfs.github.com/spec/v1
|
||||||
|
oid sha256:e19cfdfafb444821e7257e2af30fe59b51baa88bca0509a7a0f9509a527ca0ec
|
||||||
|
size 108492
|
||||||
+3
@@ -0,0 +1,3 @@
|
|||||||
|
version https://git-lfs.github.com/spec/v1
|
||||||
|
oid sha256:f909de428cb393d3dacecad51ee0d315046a1e81b990f56fc080ffb8d512c498
|
||||||
|
size 134006
|
||||||
+3
@@ -0,0 +1,3 @@
|
|||||||
|
version https://git-lfs.github.com/spec/v1
|
||||||
|
oid sha256:3fd633dfede30f4f1967b339969ecae518b7ff94397f61cb35dd9729afe5db8c
|
||||||
|
size 67692
|
||||||
+3
@@ -0,0 +1,3 @@
|
|||||||
|
version https://git-lfs.github.com/spec/v1
|
||||||
|
oid sha256:af96c6e11b09cb65fed81ee0cdb2499ddc730e009ae49d25ed097d38dfc36906
|
||||||
|
size 95754
|
||||||
+3
@@ -0,0 +1,3 @@
|
|||||||
|
version https://git-lfs.github.com/spec/v1
|
||||||
|
oid sha256:bce3908d36535874d68bc7020fb539c2208e9a8e5546d268dca5cb5fed2f1a07
|
||||||
|
size 98088
|
||||||
+3
@@ -0,0 +1,3 @@
|
|||||||
|
version https://git-lfs.github.com/spec/v1
|
||||||
|
oid sha256:2d265f547358fd98af6366212092955be02cbb625d0fb7a757bb0b128a1db7f1
|
||||||
|
size 115611
|
||||||
+3
@@ -0,0 +1,3 @@
|
|||||||
|
version https://git-lfs.github.com/spec/v1
|
||||||
|
oid sha256:b043c9f56f2428f19a9559fe203494c2173c0668dcedde7170a01bb4821659d7
|
||||||
|
size 56840
|
||||||
+3
@@ -0,0 +1,3 @@
|
|||||||
|
version https://git-lfs.github.com/spec/v1
|
||||||
|
oid sha256:d0b304b1225cfc10709d5aeedb3ff786529f2732ac6175a8c272af204347eb21
|
||||||
|
size 73926
|
||||||
+3
@@ -0,0 +1,3 @@
|
|||||||
|
version https://git-lfs.github.com/spec/v1
|
||||||
|
oid sha256:f7804f4e1e0c90dd67475eceda950491ae4bcf467ba118a3a4007672cd25545a
|
||||||
|
size 104266
|
||||||
+3
@@ -0,0 +1,3 @@
|
|||||||
|
version https://git-lfs.github.com/spec/v1
|
||||||
|
oid sha256:2c34e8096228b99077da79d4caddc8bfec006ba13bf505fb38db0b4dcf1102dc
|
||||||
|
size 124631
|
||||||
+3
@@ -0,0 +1,3 @@
|
|||||||
|
version https://git-lfs.github.com/spec/v1
|
||||||
|
oid sha256:71b2003fc0485fc398312af8677d1b2f29774093ecf1c73ce72c88228cdbd3cb
|
||||||
|
size 62052
|
||||||
+3
@@ -0,0 +1,3 @@
|
|||||||
|
version https://git-lfs.github.com/spec/v1
|
||||||
|
oid sha256:d1563190ef6c353223cafd89cc7a0d735e8e6b9ec69d4f9eccc7e13f4ccd0fe7
|
||||||
|
size 84882
|
||||||
+3
@@ -0,0 +1,3 @@
|
|||||||
|
version https://git-lfs.github.com/spec/v1
|
||||||
|
oid sha256:1ae2a9e810bf4b66db4257c1bf9943a310f7f8ce8142eefb26ecf5c1fd31779f
|
||||||
|
size 98567
|
||||||
+3
@@ -0,0 +1,3 @@
|
|||||||
|
version https://git-lfs.github.com/spec/v1
|
||||||
|
oid sha256:24cc683908aea7c99604abc07537f38e53a46f517fde37e5877df642ab247b87
|
||||||
|
size 115895
|
||||||
+3
@@ -0,0 +1,3 @@
|
|||||||
|
version https://git-lfs.github.com/spec/v1
|
||||||
|
oid sha256:85593f0e9ea14c615c870e3e721b2e0cdc96a9553d294d89702eacb6017d0582
|
||||||
|
size 57151
|
||||||
+3
@@ -0,0 +1,3 @@
|
|||||||
|
version https://git-lfs.github.com/spec/v1
|
||||||
|
oid sha256:9e2827f8d6ec2941e5116cb5bd72dc20b7286e88f639e2013e571991cefbac64
|
||||||
|
size 74117
|
||||||
@@ -5,9 +5,67 @@
|
|||||||
// Please see LICENSE files in the repository root for full details.
|
// Please see LICENSE files in the repository root for full details.
|
||||||
//
|
//
|
||||||
|
|
||||||
|
import Combine
|
||||||
import XCTest
|
import XCTest
|
||||||
|
|
||||||
@testable import ElementX
|
@testable import ElementX
|
||||||
|
|
||||||
@MainActor
|
@MainActor
|
||||||
class SecureBackupLogoutConfirmationScreenViewModelTests: XCTestCase { }
|
class SecureBackupLogoutConfirmationScreenViewModelTests: XCTestCase {
|
||||||
|
var viewModel: SecureBackupLogoutConfirmationScreenViewModel!
|
||||||
|
var context: SecureBackupLogoutConfirmationScreenViewModel.Context { viewModel.context }
|
||||||
|
|
||||||
|
var secureBackupController: SecureBackupControllerMock!
|
||||||
|
var reachabilitySubject: CurrentValueSubject<NetworkMonitorReachability, Never>!
|
||||||
|
|
||||||
|
override func setUp() {
|
||||||
|
secureBackupController = SecureBackupControllerMock()
|
||||||
|
secureBackupController.underlyingKeyBackupState = CurrentValueSubject<SecureBackupKeyBackupState, Never>(.enabled).asCurrentValuePublisher()
|
||||||
|
|
||||||
|
reachabilitySubject = CurrentValueSubject<NetworkMonitorReachability, Never>(.reachable)
|
||||||
|
let networkMonitor = NetworkMonitorMock()
|
||||||
|
networkMonitor.underlyingReachabilityPublisher = reachabilitySubject.asCurrentValuePublisher()
|
||||||
|
|
||||||
|
let appMediator = AppMediatorMock()
|
||||||
|
appMediator.underlyingNetworkMonitor = networkMonitor
|
||||||
|
|
||||||
|
viewModel = SecureBackupLogoutConfirmationScreenViewModel(secureBackupController: secureBackupController,
|
||||||
|
appMediator: appMediator)
|
||||||
|
}
|
||||||
|
|
||||||
|
func testInitialState() {
|
||||||
|
XCTAssertEqual(context.viewState.mode, .saveRecoveryKey)
|
||||||
|
}
|
||||||
|
|
||||||
|
func testOngoingState() async throws {
|
||||||
|
testInitialState()
|
||||||
|
|
||||||
|
let progressExpectation = expectation(description: "The upload progress callback should be called.")
|
||||||
|
secureBackupController.waitForKeyBackupUploadUploadStateSubjectClosure = { stateSubject in
|
||||||
|
try? await Task.sleep(for: .seconds(4))
|
||||||
|
stateSubject.send(.uploading(uploadedKeyCount: 50, totalKeyCount: 100))
|
||||||
|
progressExpectation.fulfill()
|
||||||
|
return .success(())
|
||||||
|
}
|
||||||
|
|
||||||
|
let deferredWaiting = deferFulfillment(context.$viewState) { $0.mode == .waitingToStart(hasStalled: false) }
|
||||||
|
context.send(viewAction: .logout)
|
||||||
|
try await deferredWaiting.fulfill()
|
||||||
|
|
||||||
|
// Wait for the 2-second timeout.
|
||||||
|
let deferredHasStalled = deferFulfillment(context.$viewState) { $0.mode == .waitingToStart(hasStalled: true) }
|
||||||
|
try await deferredHasStalled.fulfill()
|
||||||
|
|
||||||
|
// Wait for the progress to be reported.
|
||||||
|
await fulfillment(of: [progressExpectation])
|
||||||
|
XCTAssertEqual(context.viewState.mode, .backupOngoing(progress: 0.5))
|
||||||
|
}
|
||||||
|
|
||||||
|
func testOfflineState() async throws {
|
||||||
|
try await testOngoingState()
|
||||||
|
|
||||||
|
let deferred = deferFulfillment(context.$viewState) { $0.mode == .offline }
|
||||||
|
reachabilitySubject.send(.unreachable)
|
||||||
|
try await deferred.fulfill()
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user