Inlined Timestamp in bubble style for messages that have a bubble (#947)

* web-like solution

* not super polished but working implementation

* polishing the spacing and sizes

* removing unused code

* code improvements

* adding a test case in the preview for RTL

* addressing some PR comments

* added some tests and polished the code

* better naming

* code improvement

* RTL fix

* Revert "RTL fix"

This reverts commit 14e4468a5358769daa57891f4991e9e32da1c985.

* better RTL fix

* updated UI tests

* separated some files

* addressed some PR comments

* some more tests

UnitTests/Sources/StringTests.swift

@@ -58,4 +58,26 @@ class StringTests: XCTestCase {
     func testStripsTheHeartbreakHotel() {
         XCTAssertEqual("Heartbreak Hotel 🏩".asciified(), "Heartbreak Hotel")
     }
+
+    func testGenerateBreakableWhitespaceEnd() {
+        var count = 5
+        var result = String(repeating: "\u{2004}", count: count) + "\u{2800}"
+        XCTAssertEqual(String.generateBreakableWhitespaceEnd(whitespaceCount: count, isRTL: false), result)
+
+        count = 3
+        result = String(repeating: "\u{2004}", count: count) + "\u{2800}"
+        XCTAssertEqual(String.generateBreakableWhitespaceEnd(whitespaceCount: count, isRTL: false), result)
+
+        count = 0
+        result = ""
+        XCTAssertEqual(String.generateBreakableWhitespaceEnd(whitespaceCount: count, isRTL: false), result)
+
+        count = 4
+        result = "\u{202e}" + String(repeating: "\u{2004}", count: count) + "\u{2800}"
+        XCTAssertEqual(String.generateBreakableWhitespaceEnd(whitespaceCount: count, isRTL: true), result)
+
+        count = 0
+        result = ""
+        XCTAssertEqual(String.generateBreakableWhitespaceEnd(whitespaceCount: count, isRTL: true), result)
+    }
 }

UnitTests/Sources/TextBasedRoomTimelineTests.swift

@@ -0,0 +1,74 @@
+//
+// Copyright 2023 New Vector Ltd
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+//
+
+@testable import ElementX
+import XCTest
+
+final class TextBasedRoomTimelineTests: XCTestCase {
+    func testTextRoomTimelineItemWhitespaceEnd() {
+        let timestamp = "Now"
+        let timelineItem = TextRoomTimelineItem(id: UUID().uuidString, timestamp: timestamp, isOutgoing: true, isEditable: true, sender: .init(id: UUID().uuidString), content: .init(body: "Test"))
+        let view = TextBasedRoomTimelineViewMock<TextRoomTimelineItem>()
+        view.underlyingTimelineItem = timelineItem
+        view.timelineStyle = .bubbles
+
+        XCTAssertEqual(view.additionalWhitespaces, timestamp.count + 1)
+    }
+
+    func testTextRoomTimelineItemWhitespaceEndLonger() {
+        let timestamp = "10:00 AM"
+        let timelineItem = TextRoomTimelineItem(id: UUID().uuidString, timestamp: timestamp, isOutgoing: true, isEditable: true, sender: .init(id: UUID().uuidString), content: .init(body: "Test"))
+        let view = TextBasedRoomTimelineViewMock<TextRoomTimelineItem>()
+        view.underlyingTimelineItem = timelineItem
+        view.timelineStyle = .bubbles
+
+        XCTAssertEqual(view.additionalWhitespaces, timestamp.count + 1)
+    }
+
+    func testTextRoomTimelineItemWhitespaceEndPlain() {
+        let timelineItem = TextRoomTimelineItem(id: UUID().uuidString, timestamp: "Now", isOutgoing: true, isEditable: true, sender: .init(id: UUID().uuidString), content: .init(body: "Test"))
+        let view = TextBasedRoomTimelineViewMock<TextRoomTimelineItem>()
+        view.underlyingTimelineItem = timelineItem
+        view.timelineStyle = .plain
+
+        XCTAssertEqual(view.additionalWhitespaces, 0)
+    }
+
+    func testTextRoomTimelineItemWhitespaceEndWithEdit() {
+        let timestamp = "Now"
+        var timelineItem = TextRoomTimelineItem(id: UUID().uuidString, timestamp: timestamp, isOutgoing: true, isEditable: true, sender: .init(id: UUID().uuidString), content: .init(body: "Test"))
+        timelineItem.properties.isEdited = true
+        let editedCount = L10n.commonEditedSuffix.count
+        let view = TextBasedRoomTimelineViewMock<TextRoomTimelineItem>()
+        view.underlyingTimelineItem = timelineItem
+        view.timelineStyle = .bubbles
+
+        XCTAssertEqual(view.additionalWhitespaces, timestamp.count + editedCount + 2)
+    }
+
+    func testTextRoomTimelineItemWhitespaceEndWithEditAndAlert() {
+        let timestamp = "Now"
+        var timelineItem = TextRoomTimelineItem(id: UUID().uuidString, timestamp: timestamp, isOutgoing: true, isEditable: true, sender: .init(id: UUID().uuidString), content: .init(body: "Test"))
+        timelineItem.properties.isEdited = true
+        timelineItem.properties.deliveryStatus = .sendingFailed
+        let editedCount = L10n.commonEditedSuffix.count
+        let view = TextBasedRoomTimelineViewMock<TextRoomTimelineItem>()
+        view.underlyingTimelineItem = timelineItem
+        view.timelineStyle = .bubbles
+
+        XCTAssertEqual(view.additionalWhitespaces, timestamp.count + editedCount + 5)
+    }
+}