From c4f38cf1b227742f2e2f5126d7d556618bfc0b5c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=BCrgen=20Wischer?= Date: Wed, 15 Jul 2026 23:28:11 +0200 Subject: [PATCH] Use accessibilityValue(_:isEnabled:) instead of an empty-Text fallback Avoids applying an empty accessibility value when there's only one pinned item, per review feedback. --- .../View/PinnedItemsBanner/PinnedItemsBannerView.swift | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ElementX/Sources/Screens/RoomScreen/View/PinnedItemsBanner/PinnedItemsBannerView.swift b/ElementX/Sources/Screens/RoomScreen/View/PinnedItemsBanner/PinnedItemsBannerView.swift index 7ae6650df..d60010571 100644 --- a/ElementX/Sources/Screens/RoomScreen/View/PinnedItemsBanner/PinnedItemsBannerView.swift +++ b/ElementX/Sources/Screens/RoomScreen/View/PinnedItemsBanner/PinnedItemsBannerView.swift @@ -42,7 +42,7 @@ struct PinnedItemsBannerView: View { .disabled(state.isLoading) .accessibilityElement(children: .ignore) .accessibilityLabel(Text(state.displayedMessage)) - .accessibilityValue(state.count > 1 ? Text(state.bannerIndicatorDescription) : Text("")) + .accessibilityValue(String(state.bannerIndicatorDescription.characters), isEnabled: state.count > 1) } private var viewAllButton: some View {