From c352843fa69ec01f5983fb3cf8bbb5946bfb1c4f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jo=C3=ABl?= <joel.poyet@novaloop.ch>
Date: Fri, 17 Jul 2026 16:33:40 +0200
Subject: [PATCH] Skip VoiceMessageCacheTests on the self-hosted runner (#8)

VoiceMessageCacheTests cannot write its URLFileProtection.complete cache file on this
runner's simulator, failing with NSCocoaErrorDomain 513. It is a runner-environment
issue, not a code bug: the suite passes locally and upstream, and neither recreating +
booting the device nor clearing state fixes it (diagnosed via the failing runs).

Add a small CI_SKIP_TESTS hook to the run-tests tool that forwards comma-separated test
identifiers to xcodebuild's -skip-testing, and set it to VoiceMessageCacheTests in
unit-tests.yml. This skips the suite on the runner only; it still runs everywhere the
env var is unset. Drop the CI_SKIP_TESTS line once the runner can write data-protected
files again.

Claude-Session: https://claude.ai/code/session_01PeF4yE5SDZV3zjXWk73osw
---
 .github/workflows/unit-tests.yml         |  7 +++++++
 Tools/Sources/Commands/CI/RunTests.swift | 14 ++++++++++++++
 2 files changed, 21 insertions(+)

diff --git a/.github/workflows/unit-tests.yml b/.github/workflows/unit-tests.yml
index 85f4ab9f3..861533bf8 100644
--- a/.github/workflows/unit-tests.yml
+++ b/.github/workflows/unit-tests.yml
@@ -84,6 +84,13 @@ jobs:
         # on either runner. Unit tests alone take ~16 min here. Upstream skips them the same way in
         # unit-tests-enterprise.yml. Cost: preview snapshot regressions are not caught in CI, so
         # re-record and check them locally when changing UI.
+        env:
+          # HealthChat: VoiceMessageCacheTests cannot write its URLFileProtection.complete cache file on
+          # this runner's simulator (NSCocoaErrorDomain 513) — a runner-environment issue, not a code bug:
+          # the suite passes locally and upstream, and neither recreating+booting the device nor clearing
+          # state fixes it. Skip it here only, via -skip-testing. Drop this once the runner can write
+          # data-protected files again.
+          CI_SKIP_TESTS: VoiceMessageCacheTests
         run: swift run -q tools ci unit-tests --skip-previews
 
       - name: Save compilation cache
diff --git a/Tools/Sources/Commands/CI/RunTests.swift b/Tools/Sources/Commands/CI/RunTests.swift
index 2832b53ed..61fe8787c 100644
--- a/Tools/Sources/Commands/CI/RunTests.swift
+++ b/Tools/Sources/Commands/CI/RunTests.swift
@@ -58,6 +58,16 @@ struct RunTests: AsyncParsableCommand {
         "com.apple.CoreSimulator.SimRuntime.iOS-\(runtime.replacingOccurrences(of: ".", with: "-"))"
     }
     
+    /// Test identifiers to pass to `-skip-testing`, read from the `CI_SKIP_TESTS` environment variable
+    /// (comma-separated, e.g. "VoiceMessageCacheTests"). Lets a workflow exclude a suite that only fails in
+    /// its environment without touching the shared test.
+    private var skippedTests: [String] {
+        (ProcessInfo.processInfo.environment["CI_SKIP_TESTS"] ?? "")
+            .split(separator: ",")
+            .map { $0.trimmingCharacters(in: .whitespaces) }
+            .filter { !$0.isEmpty }
+    }
+    
     func run() async throws {
         if let createName = createSimulatorName {
             guard let createType = createSimulatorType else {
@@ -159,6 +169,10 @@ struct RunTests: AsyncParsableCommand {
             command += " -only-testing:\(scheme)/\(testName)"
         }
         
+        for skippedTest in skippedTests {
+            command += " -skip-testing:\(scheme)/\(skippedTest)"
+        }
+        
         command += " | \(formatter)"
         
         try await CI.run(.path("/bin/zsh"), ["-cu", command])