Some Post-demo Cleanups (#200)

* Remove redundant string

* Use placeholder avatar on home screen

* Add initial home screen ui test

* Fix settings screen PR remarks

* Remove UIKit alert from home screen sign out

* Remove UIKit alert from soft logout clear all data

* Add reference screenshots for home screen UI tests

* Formatting fixes

* Add clearing room method to client proxy

* Clear room proxies on screen dismiss

* Fix retain cycle in room view model

* Do not go into authentication state immediately

* Define sizes for user and room avatars on different screens

* Use defined avatar sizes everywhere

* Disable image disk caching

* Rename rounded corner shape

* Fix text color of placeholder avatars

* Fix PR reviews on formatted body text

* Fix merge conflict

* Remove shouldShowSenderDetails everywhere and just use it from inGroupState

* Remove redundant linter disablings

* Fix PR remarks

* Rename media provider size parameter

ElementX/Sources/Screens/Settings/SettingsCoordinator.swift

@@ -73,7 +73,7 @@ final class SettingsCoordinator: Coordinator, Presentable {
             case .crash:
                 self.parameters.bugReportService.crash()
             case .logout:
-                self.confirmSignOut()
+                self.callback?(.logout)
             }
         }
     }
@@ -118,19 +118,6 @@ final class SettingsCoordinator: Coordinator, Presentable {
         }
     }
 
-    private func confirmSignOut() {
-        let alert = UIAlertController(title: ElementL10n.actionSignOut,
-                                      message: ElementL10n.actionSignOutConfirmationSimple,
-                                      preferredStyle: .alert)
-
-        alert.addAction(UIAlertAction(title: ElementL10n.actionCancel, style: .cancel))
-        alert.addAction(UIAlertAction(title: ElementL10n.actionSignOut, style: .destructive) { [weak self] _ in
-            self?.callback?(.logout)
-        })
-
-        navigationRouter.present(alert, animated: true)
-    }
-    
     /// Show an activity indicator whilst loading.
     /// - Parameters:
     ///   - label: The label to show on the indicator.

ElementX/Sources/Screens/Settings/SettingsViewModel.swift

@@ -40,11 +40,13 @@ class SettingsViewModel: SettingsViewModelType, SettingsViewModelProtocol {
 
         Task {
             if case let .success(userAvatarURLString) = await userSession.clientProxy.loadUserAvatarURLString() {
-                if case let .success(avatar) = await userSession.mediaProvider.loadImageFromURLString(userAvatarURLString, size: MediaProviderDefaultAvatarSize) {
+                if case let .success(avatar) = await userSession.mediaProvider.loadImageFromURLString(userAvatarURLString, avatarSize: .user(on: .settings)) {
                     state.userAvatar = avatar
                 }
             }
+        }
 
+        Task {
             if case let .success(userDisplayName) = await self.userSession.clientProxy.loadUserDisplayName() {
                 state.userDisplayName = userDisplayName
             }

ElementX/Sources/Screens/Settings/View/SettingsScreen.swift

@@ -19,10 +19,11 @@ import SwiftUI
 struct SettingsScreen: View {
     // MARK: Private
 
+    @State private var showingLogoutConfirmation = false
     @Environment(\.colorScheme) private var colorScheme
     @ObservedObject private var settings = ElementSettings.shared
 
-    @ScaledMetric private var avatarSize = 60.0
+    @ScaledMetric private var avatarSize = AvatarSize.user(on: .settings).value
     @ScaledMetric private var menuIconSize = 30.0
     private let listRowInsets = EdgeInsets(top: 8, leading: 16, bottom: 8, trailing: 16)
     
@@ -169,7 +170,7 @@ struct SettingsScreen: View {
     
     private var logoutSection: some View {
         Section {
-            Button(action: logout) {
+            Button { showingLogoutConfirmation = true } label: {
                 HStack {
                     Image(systemName: "rectangle.portrait.and.arrow.right")
                         .foregroundColor(.element.systemGray)
@@ -186,6 +187,14 @@ struct SettingsScreen: View {
             .listRowInsets(listRowInsets)
             .foregroundColor(.element.primaryContent)
             .accessibilityIdentifier("logoutButton")
+            .alert(ElementL10n.actionSignOut,
+                   isPresented: $showingLogoutConfirmation) {
+                Button(ElementL10n.actionSignOut,
+                       role: .destructive,
+                       action: logout)
+            } message: {
+                Text(ElementL10n.actionSignOutConfirmationSimple)
+            }
         } footer: {
             versionText
                 .frame(maxWidth: .infinity)
@@ -194,12 +203,10 @@ struct SettingsScreen: View {
 
     private var closeButton: some View {
         Button(action: close) {
-            HStack {
-                Image(systemName: "xmark")
-                    .font(.title3.bold())
-                    .foregroundColor(.element.secondaryContent)
-                    .padding(4)
-            }
+            Image(systemName: "xmark")
+                .font(.title3.bold())
+                .foregroundColor(.element.secondaryContent)
+                .padding(4)
         }
         .accessibilityIdentifier("closeButton")
     }