Some Post-demo Cleanups (#200)

* Remove redundant string

* Use placeholder avatar on home screen

* Add initial home screen ui test

* Fix settings screen PR remarks

* Remove UIKit alert from home screen sign out

* Remove UIKit alert from soft logout clear all data

* Add reference screenshots for home screen UI tests

* Formatting fixes

* Add clearing room method to client proxy

* Clear room proxies on screen dismiss

* Fix retain cycle in room view model

* Do not go into authentication state immediately

* Define sizes for user and room avatars on different screens

* Use defined avatar sizes everywhere

* Disable image disk caching

* Rename rounded corner shape

* Fix text color of placeholder avatars

* Fix PR reviews on formatted body text

* Fix merge conflict

* Remove shouldShowSenderDetails everywhere and just use it from inGroupState

* Remove redundant linter disablings

* Fix PR remarks

* Rename media provider size parameter

ElementX/Sources/Screens/HomeScreen/HomeScreenModels.swift

@@ -39,6 +39,8 @@ enum HomeScreenViewAction {
 }
 
 struct HomeScreenViewState: BindableState {
+    var userID: String
+    var userDisplayName: String?
     var userAvatar: UIImage?
     
     var showSessionVerificationBanner = false

ElementX/Sources/Screens/HomeScreen/HomeScreenViewModel.swift

@@ -33,7 +33,7 @@ class HomeScreenViewModel: HomeScreenViewModelType, HomeScreenViewModelProtocol
         roomSummaryProvider = userSession.clientProxy.roomSummaryProvider
         self.attributedStringBuilder = attributedStringBuilder
         
-        super.init(initialViewState: HomeScreenViewState())
+        super.init(initialViewState: HomeScreenViewState(userID: userSession.userID))
         
         userSession.callbacks
             .receive(on: DispatchQueue.main)
@@ -61,13 +61,19 @@ class HomeScreenViewModel: HomeScreenViewModelType, HomeScreenViewModelProtocol
         
         Task {
             if case let .success(userAvatarURLString) = await userSession.clientProxy.loadUserAvatarURLString() {
-                if case let .success(avatar) = await userSession.mediaProvider.loadImageFromURLString(userAvatarURLString, size: MediaProviderDefaultAvatarSize) {
+                if case let .success(avatar) = await userSession.mediaProvider.loadImageFromURLString(userAvatarURLString, avatarSize: .user(on: .home)) {
                     state.userAvatar = avatar
                 }
             }
-            
+
             await updateRooms()
         }
+
+        Task {
+            if case let .success(userDisplayName) = await userSession.clientProxy.loadUserDisplayName() {
+                state.userDisplayName = userDisplayName
+            }
+        }
     }
     
     // MARK: - Public
@@ -101,7 +107,7 @@ class HomeScreenViewModel: HomeScreenViewModelType, HomeScreenViewModelProtocol
         
         if let avatarURLString = summary.avatarURLString {
             Task {
-                if case let .success(image) = await userSession.mediaProvider.loadImageFromURLString(avatarURLString, size: MediaProviderDefaultAvatarSize) {
+                if case let .success(image) = await userSession.mediaProvider.loadImageFromURLString(avatarURLString, avatarSize: .room(on: .home)) {
                     if let index = state.rooms.firstIndex(of: room) {
                         room.avatar = image
                         state.rooms[index] = room
@@ -116,7 +122,7 @@ class HomeScreenViewModel: HomeScreenViewModelType, HomeScreenViewModelProtocol
             var rooms = [HomeScreenRoom]()
             
             for summary in self.roomSummaryProvider.roomSummaries {
-                let avatarImage = await self.userSession.mediaProvider.imageFromURLString(summary.avatarURLString, size: MediaProviderDefaultAvatarSize)
+                let avatarImage = await self.userSession.mediaProvider.imageFromURLString(summary.avatarURLString, avatarSize: .room(on: .home))
                 
                 var timestamp: String?
                 if let lastMessageTimestamp = summary.lastMessageTimestamp {

ElementX/Sources/Screens/HomeScreen/View/HomeScreen.swift

@@ -17,6 +17,7 @@
 import SwiftUI
 
 struct HomeScreen: View {
+    @State private var showingLogoutConfirmation = false
     @ObservedObject var context: HomeScreenViewModel.Context
     
     // MARK: Views
@@ -50,7 +51,7 @@ struct HomeScreen: View {
         .transition(.slide)
         .animation(.elementDefault, value: context.viewState.showSessionVerificationBanner)
         .ignoresSafeArea(.all, edges: .bottom)
-        .navigationTitle(ElementL10n.homeScreenAllChats)
+        .navigationTitle(ElementL10n.allChats)
         .toolbar {
             ToolbarItem(placement: .navigationBarLeading) {
                 userMenuButton
@@ -75,7 +76,9 @@ struct HomeScreen: View {
                 }
             }
             Section {
-                Button(role: .destructive, action: signOut) {
+                Button(role: .destructive) {
+                    showingLogoutConfirmation = true
+                } label: {
                     Label(ElementL10n.actionSignOut, systemImage: "rectangle.portrait.and.arrow.right")
                 }
             }
@@ -84,23 +87,33 @@ struct HomeScreen: View {
                 .animation(.elementDefault, value: context.viewState.userAvatar)
                 .transition(.opacity)
         }
+        .alert(ElementL10n.actionSignOut,
+               isPresented: $showingLogoutConfirmation) {
+            Button(ElementL10n.actionSignOut,
+                   role: .destructive,
+                   action: signOut)
+        } message: {
+            Text(ElementL10n.actionSignOutConfirmationSimple)
+        }
     }
 
     @ViewBuilder
     private var userAvatarImageView: some View {
         userAvatarImage
-            .resizable()
-            .scaledToFill()
-            .frame(width: 32, height: 32, alignment: .center)
+            .frame(width: AvatarSize.user(on: .home).value, height: AvatarSize.user(on: .home).value, alignment: .center)
             .clipShape(Circle())
             .accessibilityIdentifier("userAvatarImage")
     }
 
-    private var userAvatarImage: Image {
+    @ViewBuilder
+    private var userAvatarImage: some View {
         if let avatar = context.viewState.userAvatar {
-            return Image(uiImage: avatar)
+            Image(uiImage: avatar)
+                .resizable()
+                .scaledToFill()
         } else {
-            return .empty
+            PlaceholderAvatarImage(text: context.viewState.userDisplayName ?? context.viewState.userID,
+                                   contentId: context.viewState.userID)
         }
     }
     

ElementX/Sources/Screens/HomeScreen/View/HomeScreenRoomCell.swift

@@ -17,7 +17,7 @@
 import SwiftUI
 
 struct HomeScreenRoomCell: View {
-    @ScaledMetric private var avatarSize = 44.0
+    @ScaledMetric private var avatarSize = AvatarSize.room(on: .home).value
     
     let room: HomeScreenRoom
     let context: HomeScreenViewModel.Context