Refactor and redesign Location Sharing Screen (#5155)

* refactored the static location screen to the location sharing screen # Conflicts: # UnitTests/Sources/LocationSharingScreenViewModelTests.swift # Conflicts: # ElementX.xcodeproj/project.pbxproj * implemented a custom pin with an overlayable view * implemented the render of the user when the location is sender instead of the pin type * removed description and body they are not used at all. * reimplemented single button for sharing this or user location + implemented an experimental way to update annotations * removed unnecessary @Suite description * implemented a way to display the alert on top of the sheet and added a spinner to the center user location button * fixed alerts strings * fixed a failing test * improved preview tests
2026-11-02 12:07:55 +00:00 · 2026-03-06 12:51:16 +01:00
parent 0c79b5404d
commit bbbb2e9dee
85 changed files with 917 additions and 626 deletions
@@ -0,0 +1,129 @@
+//
+// Copyright 2025 Element Creations Ltd.
+// Copyright 2023-2025 New Vector Ltd.
+//
+// SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial.
+// Please see LICENSE files in the repository root for full details.
+//
+
+import Combine
+import Foundation
+
+typealias LocationSharingScreenViewModelType = StateStoreViewModelV2<LocationSharingScreenViewState, LocationSharingScreenViewAction>
+
+class LocationSharingScreenViewModel: LocationSharingScreenViewModelType, LocationSharingScreenViewModelProtocol {
+    private let roomProxy: JoinedRoomProxyProtocol
+    private let timelineController: TimelineControllerProtocol
+    private let analytics: AnalyticsService
+    private let userIndicatorController: UserIndicatorControllerProtocol
+    
+    private let actionsSubject: PassthroughSubject<LocationSharingScreenViewModelAction, Never> = .init()
+    var actions: AnyPublisher<LocationSharingScreenViewModelAction, Never> {
+        actionsSubject.eraseToAnyPublisher()
+    }
+    
+    init(interactionMode: LocationSharingInteractionMode,
+         mapURLBuilder: MapTilerURLBuilderProtocol,
+         liveLocationSharingEnabled: Bool,
+         roomProxy: JoinedRoomProxyProtocol,
+         timelineController: TimelineControllerProtocol,
+         analytics: AnalyticsService,
+         userIndicatorController: UserIndicatorControllerProtocol,
+         mediaProvider: MediaProviderProtocol) {
+        self.roomProxy = roomProxy
+        self.timelineController = timelineController
+        self.analytics = analytics
+        self.userIndicatorController = userIndicatorController
+        
+        super.init(initialViewState: .init(interactionMode: interactionMode,
+                                           mapURLBuilder: mapURLBuilder,
+                                           showLiveLocationSharingButton: liveLocationSharingEnabled),
+                   mediaProvider: mediaProvider)
+        
+        if interactionMode.canShowAvatar {
+            updateShownUserProfile(members: roomProxy.membersPublisher.value)
+            setupSubscriptions()
+        }
+    }
+    
+    override func process(viewAction: LocationSharingScreenViewAction) {
+        switch viewAction {
+        case .close:
+            actionsSubject.send(.close)
+        case .selectLocation:
+            guard let coordinate = state.bindings.mapCenterLocation else { return }
+            let uncertainty = state.isSharingUserLocation ? context.geolocationUncertainty : nil
+            Task { await sendLocation(.init(coordinate: coordinate, uncertainty: uncertainty), isUserLocation: state.isSharingUserLocation) }
+        case .userDidPan:
+            state.bindings.showsUserLocationMode = .show
+        case .centerToUser:
+            switch state.bindings.isLocationAuthorized {
+            case .some(true), .none:
+                state.bindings.showsUserLocationMode = .showAndFollow
+            case .some(false):
+                let action: () -> Void = { [weak self] in self?.actionsSubject.send(.openSystemSettings) }
+                state.bindings.alertInfo = .init(locationSharingViewError: .missingAuthorization,
+                                                 primaryButton: .init(title: L10n.actionNotNow, role: .cancel, action: nil),
+                                                 secondaryButton: .init(title: L10n.commonSettings, action: action))
+            }
+        }
+    }
+    
+    // MARK: - Private
+    
+    private func setupSubscriptions() {
+        roomProxy.membersPublisher.sink { [weak self] members in
+            self?.updateShownUserProfile(members: members)
+        }
+        .store(in: &cancellables)
+    }
+    
+    private func updateShownUserProfile(members: [RoomMemberProxyProtocol]) {
+        switch state.interactionMode {
+        case .picker:
+            if let ownUser = members.first(where: { $0.userID == roomProxy.ownUserID }).map(UserProfileProxy.init) {
+                state.userProfile = ownUser
+            } else {
+                state.userProfile = .init(userID: roomProxy.ownUserID)
+            }
+        case .viewStatic(.some(let senderID), _):
+            if let sender = members.first(where: { $0.userID == senderID }).map(UserProfileProxy.init) {
+                state.userProfile = sender
+            } else {
+                state.userProfile = .init(userID: senderID)
+            }
+        default:
+            state.userProfile = nil
+        }
+    }
+    
+    private func sendLocation(_ geoURI: GeoURI, isUserLocation: Bool) async {
+        guard case .success = await timelineController.sendLocation(body: geoURI.bodyMessage,
+                                                                    geoURI: geoURI,
+                                                                    description: nil,
+                                                                    zoomLevel: 15,
+                                                                    assetType: isUserLocation ? .sender : .pin) else {
+            showErrorIndicator()
+            return
+        }
+        
+        actionsSubject.send(.close)
+        
+        analytics.trackComposer(inThread: false,
+                                isEditing: false,
+                                isReply: false,
+                                messageType: isUserLocation ? .LocationUser : .LocationPin,
+                                startsThread: nil)
+    }
+    
+    private func showErrorIndicator() {
+        userIndicatorController.submitIndicator(UserIndicator(id: statusIndicatorID,
+                                                              type: .toast,
+                                                              title: L10n.errorUnknown,
+                                                              iconName: "xmark"))
+    }
+    
+    private var statusIndicatorID: String {
+        "\(Self.self)-Status"
+    }
+}