From b8e6421551f4a49aac6790d25579cd2f98b0d32d Mon Sep 17 00:00:00 2001 From: Stefan Ceriu Date: Fri, 3 Jul 2026 16:01:32 +0300 Subject: [PATCH] Fix various project warnings --- .../LinkNewDeviceScreen/LinkNewDeviceScreenViewModel.swift | 2 +- .../Screens/SearchScreen/SearchScreenViewModel.swift | 3 ++- UnitTests/Sources/ContentScannerServiceTests.swift | 6 +++--- .../Sources/MessageForwardingScreenViewModelTests.swift | 2 +- UnitTests/Sources/RoomChangeRolesScreenViewModelTests.swift | 2 +- compound-ios/Sources/Compound/List/ListRowButtonStyle.swift | 4 ++-- 6 files changed, 10 insertions(+), 9 deletions(-) diff --git a/ElementX/Sources/Screens/LinkNewDeviceScreen/LinkNewDeviceScreenViewModel.swift b/ElementX/Sources/Screens/LinkNewDeviceScreen/LinkNewDeviceScreenViewModel.swift index 1ad200548..e1eeffae8 100644 --- a/ElementX/Sources/Screens/LinkNewDeviceScreen/LinkNewDeviceScreenViewModel.swift +++ b/ElementX/Sources/Screens/LinkNewDeviceScreen/LinkNewDeviceScreenViewModel.swift @@ -80,7 +80,7 @@ class LinkNewDeviceScreenViewModel: LinkNewDeviceScreenViewModelType, LinkNewDev state.mode = .readyToLink(.idle) return case .error: - // TODO: Failure UX is pending product confirmation; using the generic error state for now. + // TODO: @pixlwave Failure UX is pending product confirmation; using the generic error state for now. state.mode = .error(.unknown) return } diff --git a/ElementX/Sources/Screens/SearchScreen/SearchScreenViewModel.swift b/ElementX/Sources/Screens/SearchScreen/SearchScreenViewModel.swift index 76ae4f65a..91bc813f6 100644 --- a/ElementX/Sources/Screens/SearchScreen/SearchScreenViewModel.swift +++ b/ElementX/Sources/Screens/SearchScreen/SearchScreenViewModel.swift @@ -135,7 +135,8 @@ class SearchScreenViewModel: SearchScreenViewModelType, SearchScreenViewModelPro } else { roomSummaryProvider.setFilter(.search(query: searchQuery)) setQueryTask = Task { [weak self] in - await self?.searchService.setQuery(searchQuery) + // TODO: @stefanceriu Surface set query errors + _ = await self?.searchService.setQuery(searchQuery) } } } diff --git a/UnitTests/Sources/ContentScannerServiceTests.swift b/UnitTests/Sources/ContentScannerServiceTests.swift index d1147205b..59fcd5656 100644 --- a/UnitTests/Sources/ContentScannerServiceTests.swift +++ b/UnitTests/Sources/ContentScannerServiceTests.swift @@ -20,7 +20,7 @@ struct ContentScannerServiceTests { #expect(service.scanResultFromSource(source) == nil, "A source should not have a verdict before being scanned.") let result = await service.loadScanResultFromSource(source) - #expect(try result.get() == true) // swiftlint:disable:this force_try + #expect(try result.get() == true) #expect(service.scanResultFromSource(source) == true) @@ -37,7 +37,7 @@ struct ContentScannerServiceTests { let source = makeSource("1") let result = await service.loadScanResultFromSource(source) - #expect(try result.get() == false) // swiftlint:disable:this force_try + #expect(try result.get() == false) #expect(service.scanResultFromSource(source) == false) @@ -79,7 +79,7 @@ struct ContentScannerServiceTests { proxy.scanMediaSourceReturnValue = .success(true) result = await service.loadScanResultFromSource(source) - #expect(try result.get() == true) // swiftlint:disable:this force_try + #expect(try result.get() == true) #expect(proxy.scanMediaSourceCallsCount == 2) } diff --git a/UnitTests/Sources/MessageForwardingScreenViewModelTests.swift b/UnitTests/Sources/MessageForwardingScreenViewModelTests.swift index 52bf61779..e0f7a90b6 100644 --- a/UnitTests/Sources/MessageForwardingScreenViewModelTests.swift +++ b/UnitTests/Sources/MessageForwardingScreenViewModelTests.swift @@ -32,7 +32,7 @@ struct MessageForwardingScreenViewModelTests { @Test func initialState() { - #expect(!context.viewState.rooms.contains(where: { $0.id == forwardingItem.roomID }), "The source room ID shouldn't be shown") + #expect(!context.viewState.rooms.contains { $0.id == forwardingItem.roomID }, "The source room ID shouldn't be shown") } @Test diff --git a/UnitTests/Sources/RoomChangeRolesScreenViewModelTests.swift b/UnitTests/Sources/RoomChangeRolesScreenViewModelTests.swift index 9dfc31506..948c87a95 100644 --- a/UnitTests/Sources/RoomChangeRolesScreenViewModelTests.swift +++ b/UnitTests/Sources/RoomChangeRolesScreenViewModelTests.swift @@ -41,7 +41,7 @@ struct RoomChangeRolesScreenViewModelTests { #expect(context.viewState.moderators == context.viewState.visibleModerators) #expect(context.viewState.users == context.viewState.visibleUsers) #expect(context.viewState.membersWithRole.count == 3) - #expect(context.viewState.membersWithRole.contains(where: { $0.id == RoomMemberProxyMock.mockModerator.userID })) + #expect(context.viewState.membersWithRole.contains { $0.id == RoomMemberProxyMock.mockModerator.userID }) #expect(!context.viewState.hasChanges) #expect(!context.viewState.isSearching) } diff --git a/compound-ios/Sources/Compound/List/ListRowButtonStyle.swift b/compound-ios/Sources/Compound/List/ListRowButtonStyle.swift index c2b640d66..275c2c1e2 100644 --- a/compound-ios/Sources/Compound/List/ListRowButtonStyle.swift +++ b/compound-ios/Sources/Compound/List/ListRowButtonStyle.swift @@ -8,7 +8,7 @@ import SwiftUI -// TODO: Check if the primitive style is actually needed now the insets are part of ListRow. +// TODO: @pixlwave Check if the primitive style is actually needed now the insets are part of ListRow. // It might still be useful for ListRow(kind: .custom) usage? /// Default button styling for list rows. @@ -35,7 +35,7 @@ public struct ListRowButtonStyle: PrimitiveButtonStyle { // MARK: - Previews -// TODO: Fix the previews, either the style should expand the label to fill or +// TODO: @pixlwave Fix the previews, either the style should expand the label to fill or // the previews need to do this manually for demonstration purposes. public struct ListRowButtonStyle_Previews: PreviewProvider, TestablePreview {