ehealthsolutions/element-x-ios
3
0
Fork 0
mirror of https://github.com/Novaloop-AG/element-x-ios.git synced 2026-11-02 12:07:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix for reversed placeholder on notifications on iOS 17 (#1785)

Browse Source 
* fix

* invalidating cached images only for iOS 17

* removed paranthesis

* better code

* fix
This commit is contained in:
Mauro
2023-09-25 09:46:43 +02:00
committed by GitHub
parent e9ce24fd9c
commit b5ff6bb93e
3 changed files with 32 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ElementX/Sources/Other/Extensions/UNNotificationContent.swift
+15 -3
View File
@@ -19,6 +19,8 @@ import Intents
import SwiftUI
import UserNotifications
import Version
struct NotificationIcon {
struct GroupInfo {
let name: String
@@ -185,7 +187,9 @@ extension UNMutableNotificationContent {
private func getPlaceholderAvatarImageData(name: String, id: String) async -> Data? {
// The version value is used in case the design of the placeholder is updated to force a replacement
let fileName = "notification_placeholderV2_\(name)_\(id).png"
let isIOS17Available = isIOS17Available()
let prefix = "notification_placeholder\(isIOS17Available ? "V3" : "V2")"
let fileName = "\(prefix)_\(name)_\(id).png"
if let data = try? Data(contentsOf: URL.temporaryDirectory.appendingPathComponent(fileName)) {
MXLog.info("Found existing notification icon placeholder")
return data
@@ -204,11 +208,11 @@ extension UNMutableNotificationContent {
let data: Data?
// On simulator and macOS the image is rendered correctly
// But on other devices is rendered upside down so we need to flip it
// But on other devices before iOS 17 is rendered upside down so we need to flip it
#if targetEnvironment(simulator)
data = image.pngData()
#else
if ProcessInfo.processInfo.isiOSAppOnMac {
if ProcessInfo.processInfo.isiOSAppOnMac || isIOS17Available {
data = image.pngData()
} else {
data = image.flippedVertically().pngData()
@@ -226,6 +230,14 @@ extension UNMutableNotificationContent {
}
return data
}
private func isIOS17Available() -> Bool {
guard let version = Version(UIDevice.current.systemVersion) else {
return false
}
return version.major >= 17
}
}
private extension UIImage {