Fixes #2414 - Move member loading to the room member detail screen, avoid blocking the whole application

ElementX/Sources/Screens/RoomScreen/RoomScreenCoordinator.swift

@@ -39,7 +39,7 @@ enum RoomScreenCoordinatorAction {
     case presentPollForm(mode: PollFormMode)
     case presentLocationViewer(body: String, geoURI: GeoURI, description: String?)
     case presentEmojiPicker(itemID: TimelineItemIdentifier, selectedEmojis: Set<String>)
-    case presentRoomMemberDetails(member: RoomMemberProxyProtocol)
+    case presentRoomMemberDetails(userID: String)
     case presentMessageForwarding(itemID: TimelineItemIdentifier)
     case presentCallScreen
 }
@@ -105,8 +105,8 @@ final class RoomScreenCoordinator: CoordinatorProtocol {
                     actionsSubject.send(.presentPollForm(mode: mode))
                 case .displayMediaUploadPreviewScreen(let url):
                     actionsSubject.send(.presentMediaUploadPreviewScreen(url))
-                case .displayRoomMemberDetails(let member):
-                    actionsSubject.send(.presentRoomMemberDetails(member: member))
+                case .displayRoomMemberDetails(userID: let userID):
+                    actionsSubject.send(.presentRoomMemberDetails(userID: userID))
                 case .displayMessageForwarding(let itemID):
                     actionsSubject.send(.presentMessageForwarding(itemID: itemID))
                 case .displayLocation(let body, let geoURI, let description):

ElementX/Sources/Screens/RoomScreen/RoomScreenInteractionHandler.swift

@@ -25,7 +25,7 @@ enum RoomScreenInteractionHandlerAction {
     case displayMessageForwarding(itemID: TimelineItemIdentifier)
     case displayMediaUploadPreviewScreen(url: URL)
     case displayPollForm(mode: PollFormMode)
-    case displayRoomMemberDetails(member: RoomMemberProxyProtocol)
+    case displayRoomMemberDetails(userID: String)
     case showActionMenu(TimelineItemActionMenuInfo)
     case showDebugInfo(TimelineItemDebugInfo)
     case showConfirmationAlert(AlertInfo<UUID>)
@@ -579,19 +579,7 @@ class RoomScreenInteractionHandler {
     }
     
     func handleTappedUser(userID: String) async {
-        // This is generally fast but it could take some time for rooms with thousands of users on first load
-        // Show a loader only if it takes more than 0.1 seconds
-        showLoadingIndicator(with: .milliseconds(100))
-        let result = await roomProxy.getMember(userID: userID)
-        hideLoadingIndicator()
-        
-        switch result {
-        case .success(let member):
-            actionsSubject.send(.displayRoomMemberDetails(member: member))
-        case .failure(let error):
-            actionsSubject.send(.displayError(.alert(L10n.screenRoomErrorFailedRetrievingUserDetails)))
-            MXLog.error("Failed retrieving the user given the following id \(userID) with error: \(error)")
-        }
+        actionsSubject.send(.displayRoomMemberDetails(userID: userID))
     }
     
     func processItemTap(_ itemID: TimelineItemIdentifier) async -> RoomTimelineControllerAction {
@@ -660,22 +648,6 @@ class RoomScreenInteractionHandler {
             return .none
         }
     }
-    
-    // MARK: User indicators
-    
-    private static let loadingIndicatorIdentifier = "RoomScreenLoadingIndicator"
-
-    private func showLoadingIndicator(with delay: Duration) {
-        userIndicatorController.submitIndicator(UserIndicator(id: Self.loadingIndicatorIdentifier,
-                                                              type: .modal(progress: .indeterminate, interactiveDismissDisabled: true, allowsInteraction: false),
-                                                              title: L10n.commonLoading,
-                                                              persistent: true),
-                                                delay: delay)
-    }
-
-    private func hideLoadingIndicator() {
-        userIndicatorController.retractIndicatorWithId(Self.loadingIndicatorIdentifier)
-    }
 }
 
 private struct ReplyInfo {

ElementX/Sources/Screens/RoomScreen/RoomScreenModels.swift

@@ -30,7 +30,7 @@ enum RoomScreenViewModelAction {
     case displayLocationPicker
     case displayPollForm(mode: PollFormMode)
     case displayMediaUploadPreviewScreen(url: URL)
-    case displayRoomMemberDetails(member: RoomMemberProxyProtocol)
+    case displayRoomMemberDetails(userID: String)
     case displayMessageForwarding(itemID: TimelineItemIdentifier)
     case displayLocation(body: String, geoURI: GeoURI, description: String?)
     case composer(action: RoomScreenComposerAction)

ElementX/Sources/Screens/RoomScreen/RoomScreenViewModel.swift

@@ -337,8 +337,8 @@ class RoomScreenViewModel: RoomScreenViewModelType, RoomScreenViewModelProtocol
                     actionsSubject.send(.displayReportContent(itemID: itemID, senderID: senderID))
                 case .displayMediaUploadPreviewScreen(let url):
                     actionsSubject.send(.displayMediaUploadPreviewScreen(url: url))
-                case .displayRoomMemberDetails(let member):
-                    actionsSubject.send(.displayRoomMemberDetails(member: member))
+                case .displayRoomMemberDetails(userID: let userID):
+                    actionsSubject.send(.displayRoomMemberDetails(userID: userID))
                 case .showActionMenu(let actionMenuInfo):
                     state.bindings.actionMenuInfo = actionMenuInfo
                 case .showDebugInfo(let debugInfo):