Coordinator stops (#207)

* Add `stop` method to `Coordinator`

* Use new stop method to cleanup room screen

* Call stop implicitly when removing a child coordinator

* Revert placeholder avatar font change

* Fix PR remarks

ElementX/Sources/Screens/RoomScreen/RoomScreenCoordinator.swift

@@ -58,4 +58,8 @@ final class RoomScreenCoordinator: Coordinator, Presentable {
     func toPresentable() -> UIViewController {
         roomScreenHostingController
     }
+
+    func stop() {
+        roomScreenViewModel.stop()
+    }
 }

ElementX/Sources/Screens/RoomScreen/RoomScreenModels.swift

@@ -40,7 +40,6 @@ enum RoomScreenViewAction {
     case sendMessage
     case sendReaction(key: String, eventID: String)
     case cancelReply
-    case viewDisappeared
 }
 
 struct RoomScreenViewState: BindableState {

ElementX/Sources/Screens/RoomScreen/RoomScreenViewModel.swift

@@ -90,12 +90,14 @@ class RoomScreenViewModel: RoomScreenViewModelType, RoomScreenViewModelProtocol
             MXLog.warning("React with \(key) failed. Not implemented.")
         case .cancelReply:
             state.composerMode = .default
-        case .viewDisappeared:
-            cancellables.forEach { $0.cancel() }
-            cancellables.removeAll()
-            state.contextMenuBuilder = nil
         }
     }
+
+    func stop() {
+        cancellables.forEach { $0.cancel() }
+        cancellables.removeAll()
+        state.contextMenuBuilder = nil
+    }
     
     // MARK: - Private
     

ElementX/Sources/Screens/RoomScreen/RoomScreenViewModelProtocol.swift

@@ -19,4 +19,6 @@ import Foundation
 @MainActor
 protocol RoomScreenViewModelProtocol {
     var context: RoomScreenViewModelType.Context { get }
+
+    func stop()
 }

ElementX/Sources/Screens/RoomScreen/View/RoomScreen.swift

@@ -41,9 +41,6 @@ struct RoomScreen: View {
             }
         }
         .alert(item: $context.alertInfo) { $0.alert }
-        .onDisappear {
-            context.send(viewAction: .viewDisappeared)
-        }
     }
     
     private func sendMessage() {

ElementX/Sources/Screens/RoomScreen/View/Timeline/PlaceholderAvatarImage.swift

@@ -26,7 +26,8 @@ struct PlaceholderAvatarImage: View {
             Text(textForImage)
                 .padding(4)
                 .foregroundColor(.white)
-                .font(.title2.bold())
+                .font(.system(size: 200).weight(.semibold))
+                .minimumScaleFactor(0.001)
         }
         .aspectRatio(1, contentMode: .fill)
     }