ehealthsolutions/element-x-ios
3
0
Fork 0
mirror of https://github.com/Novaloop-AG/element-x-ios.git synced 2026-11-02 21:33:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix navigationStackCoordinator getting torn down when being reset on … (#613)

Browse Source 
* Fix navigationStackCoordinator getting torn down when being reset on the navigationSplitCoordinator, added unit tests for it

* Guard against using the same coordinator more than once
This commit is contained in:
Stefan Ceriu
2023-02-23 16:01:48 +02:00
committed by GitHub
parent 99d6caed4e
commit ad06e812bc
4 changed files with 39 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ElementX/Sources/Application/Navigation/NavigationCoordinators.swift
+28
View File
@@ -138,6 +138,10 @@ class NavigationSplitCoordinator: CoordinatorProtocol, ObservableObject, CustomS
return
}
if sidebarModule?.coordinator === coordinator {
fatalError("Cannot use the same coordinator more than once")
}
sidebarModule = NavigationModule(coordinator, dismissalCallback: dismissalCallback)
}
@@ -151,6 +155,10 @@ class NavigationSplitCoordinator: CoordinatorProtocol, ObservableObject, CustomS
return
}
if detailModule?.coordinator === coordinator {
fatalError("Cannot use the same coordinator more than once")
}
detailModule = NavigationModule(coordinator, dismissalCallback: dismissalCallback)
}
@@ -164,6 +172,10 @@ class NavigationSplitCoordinator: CoordinatorProtocol, ObservableObject, CustomS
return
}
if sheetModule?.coordinator === coordinator {
fatalError("Cannot use the same coordinator more than once")
}
sheetModule = NavigationModule(coordinator, dismissalCallback: dismissalCallback)
}
@@ -177,6 +189,10 @@ class NavigationSplitCoordinator: CoordinatorProtocol, ObservableObject, CustomS
return
}
if fullScreenCoverModule?.coordinator === coordinator {
fatalError("Cannot use the same coordinator more than once")
}
fullScreenCoverModule = NavigationModule(coordinator, dismissalCallback: dismissalCallback)
}
@@ -509,6 +525,10 @@ class NavigationStackCoordinator: ObservableObject, CoordinatorProtocol, CustomS
return
}
if rootModule?.coordinator === coordinator {
fatalError("Cannot use the same coordinator more than once")
}
popToRoot(animated: false)
rootModule = NavigationModule(coordinator, dismissalCallback: dismissalCallback)
@@ -565,6 +585,10 @@ class NavigationStackCoordinator: ObservableObject, CoordinatorProtocol, CustomS
return
}
if sheetModule?.coordinator === coordinator {
fatalError("Cannot use the same coordinator more than once")
}
sheetModule = NavigationModule(coordinator, dismissalCallback: dismissalCallback)
}
@@ -584,6 +608,10 @@ class NavigationStackCoordinator: ObservableObject, CoordinatorProtocol, CustomS
return
}
if fullScreenCoverModule?.coordinator === coordinator {
fatalError("Cannot use the same coordinator more than once")
}
fullScreenCoverModule = NavigationModule(coordinator, dismissalCallback: dismissalCallback)
}