#40: Self review for PR

ElementX/Sources/Screens/Authentication/AuthenticationCoordinator.swift

@@ -54,19 +54,21 @@ class AuthenticationCoordinator: Coordinator {
             guard let self = self else { return }
             switch action {
             case .login:
-                self.startNewLoginFlow()
+                self.showLoginScreen()
             case .register:
                 fatalError("Not implemented")
             }
         }
         
-        add(childCoordinator: coordinator)
-        navigationRouter.setRootModule(coordinator)
-        
         coordinator.start()
+        add(childCoordinator: coordinator)
+        
+        navigationRouter.setRootModule(coordinator) { [weak self] in
+            self?.remove(childCoordinator: coordinator)
+        }
     }
     
-    private func startNewLoginFlow() {
+    private func showLoginScreen() {
         let parameters = LoginScreenCoordinatorParameters()
         let coordinator = LoginScreenCoordinator(parameters: parameters)
         
@@ -91,10 +93,12 @@ class AuthenticationCoordinator: Coordinator {
             }
         }
         
-        add(childCoordinator: coordinator)
-        navigationRouter.push(coordinator)
-        
         coordinator.start()
+        add(childCoordinator: coordinator)
+        
+        navigationRouter.push(coordinator) { [weak self] in
+            self?.remove(childCoordinator: coordinator)
+        }
     }
     
     private func login(username: String, password: String) async -> Result<UserSession, AuthenticationCoordinatorError> {

ElementX/Sources/Screens/Authentication/AuthenticationMetrics.swift

@@ -0,0 +1,28 @@
+// 
+// Copyright 2021 New Vector Ltd
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+//
+
+import SwiftUI
+
+/// Metrics used across the entire onboarding flow.
+struct AuthenticationMetrics {
+    static let maxContentWidth: CGFloat = 600
+    static let maxContentHeight: CGFloat = 750
+    
+    /// The padding used between the top of the main content and the navigation bar.
+    static let topPaddingToNavigationBar: CGFloat = 16
+    /// The width/height used for the main icon shown in most of the screens.
+    static let iconSize: CGFloat = 90
+}