ehealthsolutions/element-x-ios
3
0
Fork 0
mirror of https://github.com/Novaloop-AG/element-x-ios.git synced 2026-11-05 11:58:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add some logs to allow debugging of voice messages in rageshake (#1967)

Browse Source
This commit is contained in:
Nicolas Mauri
2023-10-26 17:22:41 +02:00
committed by GitHub
parent 8a5986f9b0
commit aa766f2eac
5 changed files with 26 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ElementX/Sources/Services/Audio/Recorder/AudioRecorder.swift
+14 -7
View File
@@ -144,14 +144,19 @@ class AudioRecorder: NSObject, AudioRecorderProtocol, AVAudioRecorderDelegate {
try AVAudioSession.sharedInstance().setCategory(.playAndRecord, mode: .default)
try AVAudioSession.sharedInstance().setActive(true)
let url = URL.temporaryDirectory.appendingPathComponent("voice-message-\(recordID.identifier).m4a")
audioRecorder = try AVAudioRecorder(url: url, settings: settings)
audioRecorder?.delegate = self
audioRecorder?.isMeteringEnabled = true
audioRecorder?.record()
completion(.success(()))
let audioRecorder = try AVAudioRecorder(url: url, settings: settings)
audioRecorder.delegate = self
audioRecorder.isMeteringEnabled = true
if audioRecorder.record() {
self.audioRecorder = audioRecorder
completion(.success(()))
} else {
MXLog.error("audio recording failed to start")
completion(.failure(.recordingFailed))
}
} catch {
MXLog.error("audio recording failed: \(error)")
completion(.failure(.genericError))
MXLog.error("audio recording failed to start. \(error)")
completion(.failure(.internalError(error: error)))
}
}
}
@@ -187,12 +192,14 @@ class AudioRecorder: NSObject, AudioRecorderProtocol, AVAudioRecorderDelegate {
if success {
actionsSubject.send(.didStopRecording)
} else {
MXLog.error("audio recorder did finish recording with an error.")
actionsSubject.send(.didFailWithError(error: AudioRecorderError.genericError))
}
}
func audioRecorderEncodeErrorDidOccur(_ recorder: AVAudioRecorder, error: Error?) {
try? AVAudioSession.sharedInstance().setActive(false)
MXLog.error("audio recorder encode error did occur. \(error?.localizedDescription ?? "")")
actionsSubject.send(.didFailWithError(error: error ?? AudioRecorderError.genericError))
}
ElementX/Sources/Services/Audio/Recorder/AudioRecorderProtocol.swift
+2
View File
@@ -32,7 +32,9 @@ extension AudioRecordingIdentifier {
enum AudioRecorderError: Error {
case genericError
case internalError(error: Error)
case recordPermissionNotGranted
case recordingFailed
case recordingCancelled
}
ElementX/Sources/Services/VoiceMessage/VoiceMessageCache.swift
+2 -2
View File
@@ -35,7 +35,7 @@ class VoiceMessageCache: VoiceMessageCacheProtocol {
do {
try cacheFile(source: fileURL, destination: url, move: move)
} catch {
MXLog.error("Failed storing file in cache", context: error)
MXLog.error("Failed storing file in cache. \(error)")
return .failure(.failedStoringFileInCache)
}
return .success(url)
@@ -46,7 +46,7 @@ class VoiceMessageCache: VoiceMessageCacheProtocol {
do {
try FileManager.default.removeItem(at: temporaryFilesFolderURL)
} catch {
MXLog.error("Failed clearing cached disk files", context: error)
MXLog.error("Failed clearing cached disk files. \(error)")
}
}
}
ElementX/Sources/Services/VoiceMessage/VoiceMessageRecorder.swift
+3 -3
View File
@@ -130,7 +130,7 @@ class VoiceMessageRecorder: VoiceMessageRecorderProtocol {
// linearly normalized to [0, 1] (1 -> -50 dB)
waveformData = samples.map { UInt16(max(0, (1 - $0) * 1024)) }
} catch {
MXLog.error("Waveform analysis failed: \(error)")
MXLog.error("Waveform analysis failed. \(error)")
}
return .success(waveformData)
}
@@ -154,7 +154,7 @@ class VoiceMessageRecorder: VoiceMessageRecorderProtocol {
do {
size = try UInt64(FileManager.default.sizeForItem(at: oggFile))
} catch {
MXLog.error("Failed to get the recording file size", context: error)
MXLog.error("Failed to get the recording file size. \(error)")
return .failure(.failedSendingVoiceMessage)
}
let audioInfo = AudioInfo(duration: recordingDuration, size: size, mimetype: "audio/ogg")
@@ -170,7 +170,7 @@ class VoiceMessageRecorder: VoiceMessageRecorderProtocol {
try? FileManager.default.removeItem(at: oggFile)
if case .failure(let error) = result {
MXLog.error("Failed to send the voice message.", context: error)
MXLog.error("Failed to send the voice message. \(error)")
return .failure(.failedSendingVoiceMessage)
}