ehealthsolutions/element-x-ios
3
0
Fork 0
mirror of https://github.com/Novaloop-AG/element-x-ios.git synced 2026-11-06 12:28:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix message composer presendCallback warnings

Browse Source
This commit is contained in:
Stefan Ceriu
2024-09-06 12:05:29 +03:00
committed by Stefan Ceriu
parent 37ed7addf5
commit a5fe629790
4 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ElementX/Sources/Other/MapLibre/MapLibreMapView.swift
+1 -1
View File
@@ -173,7 +173,7 @@ extension MapLibreMapView {
} }
func mapView(_ mapView: MGLMapView, regionDidChangeAnimated animated: Bool) { func mapView(_ mapView: MGLMapView, regionDidChangeAnimated animated: Bool) {
// Fixes: "Publishing changes from within view updates is not allowed, this will cause undefined behavior." // Avoid `Publishing changes from within view update` warnings
DispatchQueue.main.async { [mapLibreView] in DispatchQueue.main.async { [mapLibreView] in
mapLibreView.mapCenterCoordinate = mapView.centerCoordinate mapLibreView.mapCenterCoordinate = mapView.centerCoordinate
} }
ElementX/Sources/Screens/CallScreen/View/CallScreen.swift
+1 -1
View File
@@ -89,7 +89,7 @@ private struct CallView: UIViewRepresentable {
super.init() super.init()
DispatchQueue.main.async { // Avoid `Publishing changes from within view update warnings` DispatchQueue.main.async { // Avoid `Publishing changes from within view update` warnings
viewModelContext.javaScriptEvaluator = self.evaluateJavaScript viewModelContext.javaScriptEvaluator = self.evaluateJavaScript
viewModelContext.requestPictureInPictureHandler = self.requestPictureInPicture viewModelContext.requestPictureInPictureHandler = self.requestPictureInPicture
} }
ElementX/Sources/Screens/RoomScreen/ComposerToolbar/View/MessageComposerTextField.swift
+5 -2
View File
@@ -189,8 +189,11 @@ private class ElementTextView: UITextView, PillAttachmentViewProviderDelegate {
super.init(frame: .zero, textContainer: nil) super.init(frame: .zero, textContainer: nil)
presendCallback.wrappedValue = { [weak self] in // Avoid `Publishing changes from within view update` warnings
self?.acceptCurrentSuggestion() DispatchQueue.main.async {
presendCallback.wrappedValue = { [weak self] in
self?.acceptCurrentSuggestion()
}
} }
} }
ElementX/Sources/Screens/Timeline/TimelineTableViewController.swift
+1 -1
View File
@@ -131,7 +131,7 @@ class TimelineTableViewController: UIViewController {
/// Updates the typing members but also updates table view items /// Updates the typing members but also updates table view items
func setTypingMembers(_ members: [String]) { func setTypingMembers(_ members: [String]) {
DispatchQueue.main.async { DispatchQueue.main.async {
// Avoid `Publishing changes from within view update warnings` // Avoid `Publishing changes from within view update` warnings
self.typingMembers.members = members self.typingMembers.members = members
} }
} }