From a4eeb6652730ac9897bca70211c84c0878999021 Mon Sep 17 00:00:00 2001 From: Mauro Romito Date: Thu, 27 Mar 2025 16:34:33 +0100 Subject: [PATCH] a11y: add profile picture accessibility label --- .../Resources/Localizations/en-US.lproj/Localizable.strings | 1 + ElementX/Resources/Localizations/en.lproj/Localizable.strings | 1 + ElementX/Sources/Generated/Strings.swift | 2 ++ ElementX/Sources/Other/SwiftUI/Views/AvatarHeaderView.swift | 2 ++ 4 files changed, 6 insertions(+) diff --git a/ElementX/Resources/Localizations/en-US.lproj/Localizable.strings b/ElementX/Resources/Localizations/en-US.lproj/Localizable.strings index 2e971b752..fe9d516ef 100644 --- a/ElementX/Resources/Localizations/en-US.lproj/Localizable.strings +++ b/ElementX/Resources/Localizations/en-US.lproj/Localizable.strings @@ -1,4 +1,5 @@ "Notification" = "Notification"; +"a11y_avatar" = "Avatar"; "a11y_delete" = "Delete"; "a11y_hide_password" = "Hide password"; "a11y_join_call" = "Join call"; diff --git a/ElementX/Resources/Localizations/en.lproj/Localizable.strings b/ElementX/Resources/Localizations/en.lproj/Localizable.strings index 3751f2f0f..db6b8abd8 100644 --- a/ElementX/Resources/Localizations/en.lproj/Localizable.strings +++ b/ElementX/Resources/Localizations/en.lproj/Localizable.strings @@ -1,4 +1,5 @@ "Notification" = "Notification"; +"a11y_avatar" = "Avatar"; "a11y_delete" = "Delete"; "a11y_hide_password" = "Hide password"; "a11y_join_call" = "Join call"; diff --git a/ElementX/Sources/Generated/Strings.swift b/ElementX/Sources/Generated/Strings.swift index 3ae7c5a7d..fbc044230 100644 --- a/ElementX/Sources/Generated/Strings.swift +++ b/ElementX/Sources/Generated/Strings.swift @@ -10,6 +10,8 @@ import Foundation // swiftlint:disable explicit_type_interface function_parameter_count identifier_name line_length // swiftlint:disable nesting type_body_length type_name vertical_whitespace_opening_braces internal enum L10n { + /// Avatar + internal static var a11yAvatar: String { return L10n.tr("Localizable", "a11y_avatar") } /// Delete internal static var a11yDelete: String { return L10n.tr("Localizable", "a11y_delete") } /// Plural format key: "%#@COUNT@" diff --git a/ElementX/Sources/Other/SwiftUI/Views/AvatarHeaderView.swift b/ElementX/Sources/Other/SwiftUI/Views/AvatarHeaderView.swift index 91103af0d..25ec8e1b4 100644 --- a/ElementX/Sources/Other/SwiftUI/Views/AvatarHeaderView.swift +++ b/ElementX/Sources/Other/SwiftUI/Views/AvatarHeaderView.swift @@ -143,6 +143,7 @@ struct AvatarHeaderView: View { avatarSize: avatarSize, mediaProvider: mediaProvider, onAvatarTap: onAvatarTap) + .accessibilityLabel(L10n.a11yAvatar) case .user(let userProfile): LoadableAvatarImage(url: userProfile.avatarURL, @@ -151,6 +152,7 @@ struct AvatarHeaderView: View { avatarSize: avatarSize, mediaProvider: mediaProvider, onTap: onAvatarTap) + .accessibilityLabel(L10n.a11yAvatar) } }