Show a verification badge on the Room Member/User Profile screens. (#3427)

* Add a badge for verified users/room members.

* Reorder subviews.

* Add a (disabled) button to verify other users.

* PR comments.

* Update the SDK.

* Adopt the SDK changes introduced in matrix-rust-sdk/pull/4100

---------

Co-authored-by: Stefan Ceriu <stefan.ceriu@gmail.com>

ElementX/Sources/Screens/RoomMemberDetailsScreen/RoomMemberDetailsScreenModels.swift

@@ -16,11 +16,24 @@ enum RoomMemberDetailsScreenViewModelAction {
 struct RoomMemberDetailsScreenViewState: BindableState {
     let userID: String
     var memberDetails: RoomMemberDetails?
+    var isVerified: Bool?
     var isOwnMemberDetails = false
     var isProcessingIgnoreRequest = false
     var dmRoomID: String?
 
     var bindings: RoomMemberDetailsScreenViewStateBindings
+    
+    var showVerifiedBadge: Bool {
+        isVerified == true // We purposely show the badge on your own account for consistency with Web.
+    }
+    
+    var showVerificationSection: Bool {
+        isVerified == false && !isOwnMemberDetails
+    }
+    
+    var verifyButtonTitle: String {
+        L10n.screenRoomMemberDetailsVerifyButtonTitle(memberDetails?.name ?? "")
+    }
 }
 
 struct RoomMemberDetailsScreenViewStateBindings {

ElementX/Sources/Screens/RoomMemberDetailsScreen/RoomMemberDetailsScreenViewModel.swift

@@ -43,25 +43,8 @@ class RoomMemberDetailsScreenViewModel: RoomMemberDetailsScreenViewModelType, Ro
         
         showMemberLoadingIndicator()
         Task {
-            defer {
-                hideMemberLoadingIndicator()
-            }
-            
-            switch await roomProxy.getMember(userID: userID) {
-            case .success(let member):
-                roomMemberProxy = member
-                state.memberDetails = RoomMemberDetails(withProxy: member)
-                state.isOwnMemberDetails = member.userID == roomProxy.ownUserID
-                switch await clientProxy.directRoomForUserID(member.userID) {
-                case .success(let roomID):
-                    state.dmRoomID = roomID
-                case .failure:
-                    break
-                }
-            case .failure(let error):
-                MXLog.warning("Failed to find member: \(error)")
-                actionsSubject.send(.openUserProfile)
-            }
+            await loadMember()
+            hideMemberLoadingIndicator()
         }
     }
     
@@ -94,8 +77,37 @@ class RoomMemberDetailsScreenViewModel: RoomMemberDetailsScreenViewModelType, Ro
     }
 
     // MARK: - Private
-
-    @MainActor
+    
+    private func loadMember() async {
+        async let memberResult = roomProxy.getMember(userID: state.userID)
+        async let identityResult = clientProxy.userIdentity(for: state.userID)
+        
+        switch await memberResult {
+        case .success(let member):
+            roomMemberProxy = member
+            state.memberDetails = RoomMemberDetails(withProxy: member)
+            state.isOwnMemberDetails = member.userID == roomProxy.ownUserID
+            switch await clientProxy.directRoomForUserID(member.userID) {
+            case .success(let roomID):
+                state.dmRoomID = roomID
+            case .failure:
+                break
+            }
+        case .failure(let error):
+            MXLog.warning("Failed to find member: \(error)")
+            // As we didn't find a member with the specified user ID in this room we instead
+            // fall back to showing a generic user profile screen as the source is likely
+            // a message containing a permalink to someone who's not in this room.
+            actionsSubject.send(.openUserProfile)
+        }
+        
+        if case let .success(.some(identity)) = await identityResult {
+            state.isVerified = identity.isVerified()
+        } else {
+            MXLog.error("Failed to find the member's identity.")
+        }
+    }
+    
     private func ignoreUser() async {
         guard let roomMemberProxy else {
             fatalError()

ElementX/Sources/Screens/RoomMemberDetailsScreen/View/RoomMemberDetailsScreen.swift

@@ -15,6 +15,8 @@ struct RoomMemberDetailsScreen: View {
         Form {
             headerSection
             
+            verificationSection
+            
             if context.viewState.memberDetails != nil, !context.viewState.isOwnMemberDetails {
                 blockUserSection
             }
@@ -30,6 +32,25 @@ struct RoomMemberDetailsScreen: View {
     // MARK: - Private
     
     @ViewBuilder
+    private var headerSection: some View {
+        if let memberDetails = context.viewState.memberDetails {
+            AvatarHeaderView(member: memberDetails,
+                             isVerified: context.viewState.showVerifiedBadge,
+                             avatarSize: .user(on: .memberDetails),
+                             mediaProvider: context.mediaProvider) { url in
+                context.send(viewAction: .displayAvatar(url))
+            } footer: {
+                otherUserFooter
+            }
+        } else {
+            AvatarHeaderView(user: UserProfileProxy(userID: context.viewState.userID),
+                             isVerified: context.viewState.showVerifiedBadge,
+                             avatarSize: .user(on: .memberDetails),
+                             mediaProvider: context.mediaProvider,
+                             footer: { })
+        }
+    }
+    
     private var otherUserFooter: some View {
         HStack(spacing: 8) {
             if context.viewState.memberDetails != nil, !context.viewState.isOwnMemberDetails {
@@ -62,20 +83,15 @@ struct RoomMemberDetailsScreen: View {
     }
     
     @ViewBuilder
-    private var headerSection: some View {
-        if let memberDetails = context.viewState.memberDetails {
-            AvatarHeaderView(member: memberDetails,
-                             avatarSize: .user(on: .memberDetails),
-                             mediaProvider: context.mediaProvider) { url in
-                context.send(viewAction: .displayAvatar(url))
-            } footer: {
-                otherUserFooter
+    var verificationSection: some View {
+        if context.viewState.showVerificationSection {
+            Section {
+                ListRow(label: .default(title: context.viewState.verifyButtonTitle,
+                                        description: L10n.screenRoomMemberDetailsVerifyButtonSubtitle,
+                                        icon: \.lock),
+                        kind: .button { })
+                    .disabled(true)
             }
-        } else {
-            AvatarHeaderView(user: UserProfileProxy(userID: context.viewState.userID),
-                             avatarSize: .user(on: .memberDetails),
-                             mediaProvider: context.mediaProvider,
-                             footer: { })
         }
     }
     
@@ -117,11 +133,15 @@ struct RoomMemberDetailsScreen: View {
 // MARK: - Previews
 
 struct RoomMemberDetailsScreen_Previews: PreviewProvider, TestablePreview {
-    static let otherUserViewModel = makeViewModel(member: .mockDan)
+    static let verifiedUserViewModel = makeViewModel(member: .mockDan)
+    static let otherUserViewModel = makeViewModel(member: .mockAlice)
     static let accountOwnerViewModel = makeViewModel(member: .mockMe)
     static let ignoredUserViewModel = makeViewModel(member: .mockIgnored)
     
     static var previews: some View {
+        RoomMemberDetailsScreen(context: verifiedUserViewModel.context)
+            .previewDisplayName("Verified User")
+            .snapshotPreferences(delay: 0.25)
         RoomMemberDetailsScreen(context: otherUserViewModel.context)
             .previewDisplayName("Other User")
             .snapshotPreferences(delay: 0.25)
@@ -136,9 +156,12 @@ struct RoomMemberDetailsScreen_Previews: PreviewProvider, TestablePreview {
     static func makeViewModel(member: RoomMemberProxyMock) -> RoomMemberDetailsScreenViewModel {
         let roomProxyMock = JoinedRoomProxyMock(.init(name: ""))
         roomProxyMock.getMemberUserIDReturnValue = .success(member)
-        
         let clientProxyMock = ClientProxyMock(.init())
         
+        clientProxyMock.userIdentityForClosure = { userID in
+            let isVerified = userID == RoomMemberProxyMock.mockDan.userID
+            return .success(UserIdentitySDKMock(configuration: .init(isVerified: isVerified)))
+        }
         // to avoid mock the call state for the account owner test case
         if member.userID != RoomMemberProxyMock.mockMe.userID {
             clientProxyMock.directRoomForUserIDReturnValue = .success("roomID")