Switch callbacks to combine (#1710)

* #750 - Convert the SoftLogoutScreen to combine

* #750 - Convert the UserSessionFlowCoordinator to Combine

* #750 - Convert the AnalyticsPromptScreen to Combine

* #750 - Convert the LoginScreen to Combine

* #750 - Convert the ServerSelectionScreen to Combine

* #750 - Convert the EmojiPickerScreen to Combine

* #750 - Convert the HomeScreen to Combine

* #750 - Convert the MediaUploadPreviewScreen to Combine

* #750 - Convert the OnboardingScreen to Combine

* Rename `Onboarding` to `OnboardingScreen`

* #750 - Convert the ReportContentScreen to Combine

* #750 - Convert the RoomDetailsSscreen to Combine

* #750 - Convert the RoomMemberDetailsScreen to Combine

* #750 - Convert the RoomMembersListScreen to Combine

* #750 - Convert the SessionVerificationScreen to Combine

* #750 - Convert the SettingsScreen to Combine

* #750 - Convert the AdvancedSettingsScreen to Combine

* #750 - Convert the DeveloperOptionsScreen to Combine

* Fix the unit tests

* Use .sink action and the same cancellables constructor everywhere

* Cleanup cancellables when setting up tests

ElementX/Sources/Screens/Settings/DeveloperOptionsScreen/DeveloperOptionsScreenCoordinator.swift

@@ -14,6 +14,7 @@
 // limitations under the License.
 //
 
+import Combine
 import SwiftUI
 
 enum DeveloperOptionsScreenCoordinatorAction {
@@ -23,18 +24,28 @@ enum DeveloperOptionsScreenCoordinatorAction {
 final class DeveloperOptionsScreenCoordinator: CoordinatorProtocol {
     private var viewModel: DeveloperOptionsScreenViewModelProtocol
     
-    var callback: ((DeveloperOptionsScreenCoordinatorAction) -> Void)?
+    private let actionsSubject: PassthroughSubject<DeveloperOptionsScreenCoordinatorAction, Never> = .init()
+    private var cancellables = Set<AnyCancellable>()
+    
+    var actions: AnyPublisher<DeveloperOptionsScreenCoordinatorAction, Never> {
+        actionsSubject.eraseToAnyPublisher()
+    }
     
     init() {
         viewModel = DeveloperOptionsScreenViewModel(developerOptions: ServiceLocator.shared.settings)
-        viewModel.callback = { [weak self] action in
-            switch action {
-            case .clearCache:
-                self?.callback?(.clearCache)
+        
+        viewModel.actions
+            .sink { [weak self] action in
+                guard let self else { return }
+                
+                switch action {
+                case .clearCache:
+                    actionsSubject.send(.clearCache)
+                }
             }
-        }
+            .store(in: &cancellables)
     }
-            
+    
     func toPresentable() -> AnyView {
         AnyView(DeveloperOptionsScreen(context: viewModel.context))
     }

ElementX/Sources/Screens/Settings/DeveloperOptionsScreen/DeveloperOptionsScreenViewModel.swift

@@ -14,12 +14,17 @@
 // limitations under the License.
 //
 
+import Combine
 import SwiftUI
 
 typealias DeveloperOptionsScreenViewModelType = StateStoreViewModel<DeveloperOptionsScreenViewState, DeveloperOptionsScreenViewAction>
 
 class DeveloperOptionsScreenViewModel: DeveloperOptionsScreenViewModelType, DeveloperOptionsScreenViewModelProtocol {
-    var callback: ((DeveloperOptionsScreenViewModelAction) -> Void)?
+    private var actionsSubject: PassthroughSubject<DeveloperOptionsScreenViewModelAction, Never> = .init()
+    
+    var actions: AnyPublisher<DeveloperOptionsScreenViewModelAction, Never> {
+        actionsSubject.eraseToAnyPublisher()
+    }
     
     init(developerOptions: DeveloperOptionsProtocol) {
         let bindings = DeveloperOptionsScreenViewStateBindings(developerOptions: developerOptions)
@@ -31,7 +36,7 @@ class DeveloperOptionsScreenViewModel: DeveloperOptionsScreenViewModelType, Deve
     override func process(viewAction: DeveloperOptionsScreenViewAction) {
         switch viewAction {
         case .clearCache:
-            callback?(.clearCache)
+            actionsSubject.send(.clearCache)
         }
     }
 }

ElementX/Sources/Screens/Settings/DeveloperOptionsScreen/DeveloperOptionsScreenViewModelProtocol.swift

@@ -14,10 +14,10 @@
 // limitations under the License.
 //
 
-import Foundation
+import Combine
 
 @MainActor
 protocol DeveloperOptionsScreenViewModelProtocol {
-    var callback: ((DeveloperOptionsScreenViewModelAction) -> Void)? { get set }
+    var actions: AnyPublisher<DeveloperOptionsScreenViewModelAction, Never> { get }
     var context: DeveloperOptionsScreenViewModelType.Context { get }
 }