Switch callbacks to combine (#1710)

* #750 - Convert the SoftLogoutScreen to combine

* #750 - Convert the UserSessionFlowCoordinator to Combine

* #750 - Convert the AnalyticsPromptScreen to Combine

* #750 - Convert the LoginScreen to Combine

* #750 - Convert the ServerSelectionScreen to Combine

* #750 - Convert the EmojiPickerScreen to Combine

* #750 - Convert the HomeScreen to Combine

* #750 - Convert the MediaUploadPreviewScreen to Combine

* #750 - Convert the OnboardingScreen to Combine

* Rename `Onboarding` to `OnboardingScreen`

* #750 - Convert the ReportContentScreen to Combine

* #750 - Convert the RoomDetailsSscreen to Combine

* #750 - Convert the RoomMemberDetailsScreen to Combine

* #750 - Convert the RoomMembersListScreen to Combine

* #750 - Convert the SessionVerificationScreen to Combine

* #750 - Convert the SettingsScreen to Combine

* #750 - Convert the AdvancedSettingsScreen to Combine

* #750 - Convert the DeveloperOptionsScreen to Combine

* Fix the unit tests

* Use .sink action and the same cancellables constructor everywhere

* Cleanup cancellables when setting up tests

ElementX/Sources/Screens/RoomMemberListScreen/RoomMembersListScreenCoordinator.swift

@@ -14,6 +14,7 @@
 // limitations under the License.
 //
 
+import Combine
 import SwiftUI
 
 struct RoomMembersListScreenCoordinatorParameters {
@@ -33,7 +34,12 @@ final class RoomMembersListScreenCoordinator: CoordinatorProtocol {
         parameters.navigationStackCoordinator
     }
     
-    var callback: ((RoomMembersListScreenCoordinatorAction) -> Void)?
+    private let actionsSubject: PassthroughSubject<RoomMembersListScreenCoordinatorAction, Never> = .init()
+    private var cancellables = Set<AnyCancellable>()
+    
+    var actions: AnyPublisher<RoomMembersListScreenCoordinatorAction, Never> {
+        actionsSubject.eraseToAnyPublisher()
+    }
     
     init(parameters: RoomMembersListScreenCoordinatorParameters) {
         self.parameters = parameters
@@ -44,16 +50,18 @@ final class RoomMembersListScreenCoordinator: CoordinatorProtocol {
     }
     
     func start() {
-        viewModel.callback = { [weak self] action in
-            guard let self else { return }
-            
-            switch action {
-            case let .selectMember(member):
-                self.selectMember(member)
-            case .invite:
-                callback?(.invite)
+        viewModel.actions
+            .sink { [weak self] action in
+                guard let self else { return }
+                
+                switch action {
+                case let .selectMember(member):
+                    selectMember(member)
+                case .invite:
+                    actionsSubject.send(.invite)
+                }
             }
-        }
+            .store(in: &cancellables)
     }
         
     func toPresentable() -> AnyView {

ElementX/Sources/Screens/RoomMemberListScreen/RoomMembersListScreenViewModel.swift

@@ -14,6 +14,7 @@
 // limitations under the License.
 //
 
+import Combine
 import SwiftUI
 
 typealias RoomMembersListScreenViewModelType = StateStoreViewModel<RoomMembersListScreenViewState, RoomMembersListScreenViewAction>
@@ -24,7 +25,11 @@ class RoomMembersListScreenViewModel: RoomMembersListScreenViewModelType, RoomMe
     
     private var members: [RoomMemberProxyProtocol] = []
     
-    var callback: ((RoomMembersListScreenViewModelAction) -> Void)?
+    private var actionsSubject: PassthroughSubject<RoomMembersListScreenViewModelAction, Never> = .init()
+    
+    var actions: AnyPublisher<RoomMembersListScreenViewModelAction, Never> {
+        actionsSubject.eraseToAnyPublisher()
+    }
 
     init(roomProxy: RoomProxyProtocol,
          mediaProvider: MediaProviderProtocol,
@@ -47,9 +52,9 @@ class RoomMembersListScreenViewModel: RoomMembersListScreenViewModelType, RoomMe
                 MXLog.error("Selected member \(id) not found")
                 return
             }
-            callback?(.selectMember(member))
+            actionsSubject.send(.selectMember(member))
         case .invite:
-            callback?(.invite)
+            actionsSubject.send(.invite)
         }
     }
     

ElementX/Sources/Screens/RoomMemberListScreen/RoomMembersListScreenViewModelProtocol.swift

@@ -14,10 +14,10 @@
 // limitations under the License.
 //
 
-import Foundation
+import Combine
 
 @MainActor
 protocol RoomMembersListScreenViewModelProtocol {
-    var callback: ((RoomMembersListScreenViewModelAction) -> Void)? { get set }
+    var actions: AnyPublisher<RoomMembersListScreenViewModelAction, Never> { get }
     var context: RoomMembersListScreenViewModelType.Context { get }
 }