Switch callbacks to combine (#1710)

* #750 - Convert the SoftLogoutScreen to combine

* #750 - Convert the UserSessionFlowCoordinator to Combine

* #750 - Convert the AnalyticsPromptScreen to Combine

* #750 - Convert the LoginScreen to Combine

* #750 - Convert the ServerSelectionScreen to Combine

* #750 - Convert the EmojiPickerScreen to Combine

* #750 - Convert the HomeScreen to Combine

* #750 - Convert the MediaUploadPreviewScreen to Combine

* #750 - Convert the OnboardingScreen to Combine

* Rename `Onboarding` to `OnboardingScreen`

* #750 - Convert the ReportContentScreen to Combine

* #750 - Convert the RoomDetailsSscreen to Combine

* #750 - Convert the RoomMemberDetailsScreen to Combine

* #750 - Convert the RoomMembersListScreen to Combine

* #750 - Convert the SessionVerificationScreen to Combine

* #750 - Convert the SettingsScreen to Combine

* #750 - Convert the AdvancedSettingsScreen to Combine

* #750 - Convert the DeveloperOptionsScreen to Combine

* Fix the unit tests

* Use .sink action and the same cancellables constructor everywhere

* Cleanup cancellables when setting up tests

ElementX/Sources/Screens/MediaUploadPreviewScreen/MediaUploadPreviewScreenCoordinator.swift

@@ -14,6 +14,7 @@
 // limitations under the License.
 //
 
+import Combine
 import SwiftUI
 
 struct MediaUploadPreviewScreenCoordinatorParameters {
@@ -30,11 +31,14 @@ enum MediaUploadPreviewScreenCoordinatorAction {
 
 final class MediaUploadPreviewScreenCoordinator: CoordinatorProtocol {
     private var viewModel: MediaUploadPreviewScreenViewModelProtocol
-    private let callback: (MediaUploadPreviewScreenCoordinatorAction) -> Void
+    private let actionsSubject: PassthroughSubject<MediaUploadPreviewScreenCoordinatorAction, Never> = .init()
+    private var cancellables = Set<AnyCancellable>()
     
-    init(parameters: MediaUploadPreviewScreenCoordinatorParameters, callback: @escaping (MediaUploadPreviewScreenCoordinatorAction) -> Void) {
-        self.callback = callback
-        
+    var actions: AnyPublisher<MediaUploadPreviewScreenCoordinatorAction, Never> {
+        actionsSubject.eraseToAnyPublisher()
+    }
+    
+    init(parameters: MediaUploadPreviewScreenCoordinatorParameters) {
         viewModel = MediaUploadPreviewScreenViewModel(userIndicatorController: parameters.userIndicatorController,
                                                       roomProxy: parameters.roomProxy,
                                                       mediaUploadingPreprocessor: parameters.mediaUploadingPreprocessor,
@@ -43,14 +47,18 @@ final class MediaUploadPreviewScreenCoordinator: CoordinatorProtocol {
     }
     
     func start() {
-        viewModel.callback = { [weak self] action in
-            switch action {
-            case .dismiss:
-                self?.callback(.dismiss)
+        viewModel.actions
+            .sink { [weak self] action in
+                guard let self else { return }
+                
+                switch action {
+                case .dismiss:
+                    actionsSubject.send(.dismiss)
+                }
             }
-        }
+            .store(in: &cancellables)
     }
-        
+    
     func toPresentable() -> AnyView {
         AnyView(MediaUploadPreviewScreen(context: viewModel.context))
     }

ElementX/Sources/Screens/MediaUploadPreviewScreen/MediaUploadPreviewScreenViewModel.swift

@@ -31,7 +31,11 @@ class MediaUploadPreviewScreenViewModel: MediaUploadPreviewScreenViewModelType,
         }
     }
     
-    var callback: ((MediaUploadPreviewScreenViewModelAction) -> Void)?
+    private var actionsSubject: PassthroughSubject<MediaUploadPreviewScreenViewModelAction, Never> = .init()
+    
+    var actions: AnyPublisher<MediaUploadPreviewScreenViewModelAction, Never> {
+        actionsSubject.eraseToAnyPublisher()
+    }
 
     init(userIndicatorController: UserIndicatorControllerProtocol?,
          roomProxy: RoomProxyProtocol,
@@ -58,7 +62,7 @@ class MediaUploadPreviewScreenViewModel: MediaUploadPreviewScreenViewModelType,
                 case .success(let mediaInfo):
                     switch await sendAttachment(mediaInfo: mediaInfo, progressSubject: progressSubject) {
                     case .success:
-                        callback?(.dismiss)
+                        actionsSubject.send(.dismiss)
                     case .failure(let error):
                         MXLog.error("Failed sending attachment with error: \(error)")
                         showError(label: L10n.screenMediaUploadPreviewErrorFailedSending)
@@ -74,7 +78,7 @@ class MediaUploadPreviewScreenViewModel: MediaUploadPreviewScreenViewModelType,
             
         case .cancel:
             requestHandle?.cancel()
-            callback?(.dismiss)
+            actionsSubject.send(.dismiss)
         }
     }
     

ElementX/Sources/Screens/MediaUploadPreviewScreen/MediaUploadPreviewScreenViewModelProtocol.swift

@@ -14,10 +14,10 @@
 // limitations under the License.
 //
 
-import Foundation
+import Combine
 
 @MainActor
 protocol MediaUploadPreviewScreenViewModelProtocol {
-    var callback: ((MediaUploadPreviewScreenViewModelAction) -> Void)? { get set }
+    var actions: AnyPublisher<MediaUploadPreviewScreenViewModelAction, Never> { get }
     var context: MediaUploadPreviewScreenViewModelType.Context { get }
 }