Switch callbacks to combine (#1710)

* #750 - Convert the SoftLogoutScreen to combine

* #750 - Convert the UserSessionFlowCoordinator to Combine

* #750 - Convert the AnalyticsPromptScreen to Combine

* #750 - Convert the LoginScreen to Combine

* #750 - Convert the ServerSelectionScreen to Combine

* #750 - Convert the EmojiPickerScreen to Combine

* #750 - Convert the HomeScreen to Combine

* #750 - Convert the MediaUploadPreviewScreen to Combine

* #750 - Convert the OnboardingScreen to Combine

* Rename `Onboarding` to `OnboardingScreen`

* #750 - Convert the ReportContentScreen to Combine

* #750 - Convert the RoomDetailsSscreen to Combine

* #750 - Convert the RoomMemberDetailsScreen to Combine

* #750 - Convert the RoomMembersListScreen to Combine

* #750 - Convert the SessionVerificationScreen to Combine

* #750 - Convert the SettingsScreen to Combine

* #750 - Convert the AdvancedSettingsScreen to Combine

* #750 - Convert the DeveloperOptionsScreen to Combine

* Fix the unit tests

* Use .sink action and the same cancellables constructor everywhere

* Cleanup cancellables when setting up tests

ElementX/Sources/Screens/EmojiPickerScreen/EmojiPickerScreenCoordinator.swift

@@ -14,6 +14,7 @@
 // limitations under the License.
 //
 
+import Combine
 import SwiftUI
 
 struct EmojiPickerScreenCoordinatorParameters {
@@ -31,7 +32,12 @@ final class EmojiPickerScreenCoordinator: CoordinatorProtocol {
     private let parameters: EmojiPickerScreenCoordinatorParameters
     private var viewModel: EmojiPickerScreenViewModelProtocol
     
-    var callback: ((EmojiPickerScreenCoordinatorAction) -> Void)?
+    private let actionsSubject: PassthroughSubject<EmojiPickerScreenCoordinatorAction, Never> = .init()
+    private var cancellables = Set<AnyCancellable>()
+    
+    var actions: AnyPublisher<EmojiPickerScreenCoordinatorAction, Never> {
+        actionsSubject.eraseToAnyPublisher()
+    }
     
     init(parameters: EmojiPickerScreenCoordinatorParameters) {
         self.parameters = parameters
@@ -40,16 +46,18 @@ final class EmojiPickerScreenCoordinator: CoordinatorProtocol {
     }
     
     func start() {
-        viewModel.callback = { [weak self] action in
-            guard let self else { return }
-            
-            switch action {
-            case let .emojiSelected(emoji: emoji):
-                self.callback?(.emojiSelected(emoji: emoji, itemID: self.parameters.itemID))
-            case .dismiss:
-                self.callback?(.dismiss)
+        viewModel.actions
+            .sink { [weak self] action in
+                guard let self else { return }
+                
+                switch action {
+                case let .emojiSelected(emoji: emoji):
+                    actionsSubject.send(.emojiSelected(emoji: emoji, itemID: self.parameters.itemID))
+                case .dismiss:
+                    actionsSubject.send(.dismiss)
+                }
             }
-        }
+            .store(in: &cancellables)
     }
     
     func toPresentable() -> AnyView {

ElementX/Sources/Screens/EmojiPickerScreen/EmojiPickerScreenViewModel.swift

@@ -14,12 +14,17 @@
 // limitations under the License.
 //
 
+import Combine
 import SwiftUI
 
 typealias EmojiPickerScreenViewModelType = StateStoreViewModel<EmojiPickerScreenViewState, EmojiPickerScreenViewAction>
 
 class EmojiPickerScreenViewModel: EmojiPickerScreenViewModelType, EmojiPickerScreenViewModelProtocol {
-    var callback: ((EmojiPickerScreenViewModelAction) -> Void)?
+    private var actionsSubject: PassthroughSubject<EmojiPickerScreenViewModelAction, Never> = .init()
+    
+    var actions: AnyPublisher<EmojiPickerScreenViewModelAction, Never> {
+        actionsSubject.eraseToAnyPublisher()
+    }
     
     private let emojiProvider: EmojiProviderProtocol
     
@@ -40,9 +45,9 @@ class EmojiPickerScreenViewModel: EmojiPickerScreenViewModelType, EmojiPickerScr
                 state.categories = convert(emojiCategories: categories)
             }
         case let .emojiTapped(emoji: emoji):
-            callback?(.emojiSelected(emoji: emoji.value))
+            actionsSubject.send(.emojiSelected(emoji: emoji.value))
         case .dismiss:
-            callback?(.dismiss)
+            actionsSubject.send(.dismiss)
         }
     }
     

ElementX/Sources/Screens/EmojiPickerScreen/EmojiPickerScreenViewModelProtocol.swift

@@ -14,10 +14,10 @@
 // limitations under the License.
 //
 
-import Foundation
+import Combine
 
 @MainActor
 protocol EmojiPickerScreenViewModelProtocol {
-    var callback: ((EmojiPickerScreenViewModelAction) -> Void)? { get set }
+    var actions: AnyPublisher<EmojiPickerScreenViewModelAction, Never> { get }
     var context: EmojiPickerScreenViewModelType.Context { get }
 }