Update the "remove avatar" logic in edit room details (#1032)

* Refactor remove avatar logic

* Add test

ElementX/Sources/Screens/RoomDetailsEditScreen/RoomDetailsEditScreenViewModel.swift

@@ -66,11 +66,8 @@ class RoomDetailsEditScreenViewModel: RoomDetailsEditScreenViewModelType, RoomDe
         case .displayMediaPicker:
             actionsSubject.send(.displayMediaPicker)
         case .removeImage:
-            if state.localMedia != nil {
-                state.localMedia = nil
-            } else {
             state.avatarURL = nil
-            }
+            state.localMedia = nil
         }
     }
     

UnitTests/Sources/RoomDetailsEditScreenViewModelTests.swift

@@ -108,6 +108,14 @@ class RoomDetailsEditScreenViewModelTests: XCTestCase {
         XCTAssertNotNil(userIndicatorController.alertInfo)
     }
     
+    func testDeleteAvatar() {
+        setupViewModel(accountOwner: .mockOwner(allowedStateEvents: [.roomAvatar, .roomName, .roomTopic]),
+                       roomProxyConfiguration: .init(name: "Some room", displayName: "Some room", avatarURL: .picturesDirectory))
+        XCTAssertNotNil(context.viewState.avatarURL)
+        context.send(viewAction: .removeImage)
+        XCTAssertNil(context.viewState.avatarURL)
+    }
+    
     // MARK: - Private
     
     private func setupViewModel(accountOwner: RoomMemberProxyMock, roomProxyConfiguration: RoomProxyMockConfiguration) {