Promote "history sharing on invite" out of developer options (#5480)

* Enable key-share-on-invite irrespective of feature flag

* Remove feature-flag dep: warning on starting chat with new people

* Remove feature-flag dep: invite from room member details

* Remove feature-flag dep: warning on new users in invite screen

* Remove feature-flag dep: from room details screen

* Remove feature-flag dep: starting chat from user profile screen

* Remove feature-flag dep: timeline info on forwarded keys

* Remove feature-flag dep: RoomScreenModel

* Remove `enableKeyShareOnInvite` from AppSettings

* Remove `enableKeyShareOnInvite` feature flag

* Remove outdated comments

* Update preview test room snapshots as their header now includes the history sharing icon

ElementX/Sources/Services/Authentication/AuthenticationClientFactory.swift

@@ -38,7 +38,6 @@ struct AuthenticationClientFactory: AuthenticationClientFactoryProtocol {
                          sessionDelegate: clientSessionDelegate,
                          appHooks: appHooks,
                          enableOnlySignedDeviceIsolationMode: appSettings.enableOnlySignedDeviceIsolationMode,
-                         enableKeyShareOnInvite: appSettings.enableKeyShareOnInvite,
                          threadsEnabled: appSettings.threadsEnabled)
             .sqliteStore(config: .init(dataPath: sessionDirectories.dataPath, cachePath: sessionDirectories.cachePath)
                 .passphrase(passphrase: passphrase))
@@ -56,7 +55,6 @@ struct AuthenticationClientFactory: AuthenticationClientFactoryProtocol {
                          sessionDelegate: clientSessionDelegate,
                          appHooks: appHooks,
                          enableOnlySignedDeviceIsolationMode: appSettings.enableOnlySignedDeviceIsolationMode,
-                         enableKeyShareOnInvite: appSettings.enableKeyShareOnInvite,
                          threadsEnabled: appSettings.threadsEnabled)
             .inMemoryStore()
             .serverNameOrHomeserverUrl(serverNameOrUrl: homeserverAddress)

ElementX/Sources/Services/Room/RoomHistorySharingState.swift

@@ -5,8 +5,7 @@
 // Please see LICENSE files in the repository root for full details.
 //
 
-/// Enumeration of the two possible cases in which history sharing under MSC4268 is enabled. These
-/// variants implicitly assume that the feature flag, `enableKeyShareOnInvite`, is set.
+/// Enumeration of the two possible cases in which history sharing under MSC4268 is enabled.
 enum RoomHistorySharingState: Equatable {
     /// The feature flag is set, and the room history visibility is either `invited` or `joined`. New
     /// members of the room cannot read the room history.

ElementX/Sources/Services/Room/RoomInfoProxyProtocol.swift

@@ -136,8 +136,7 @@ extension RoomInfoProxyProtocol {
         return alternativeAliases.first
     }
     
-    /// If present, the state of history sharing in this room. This *does not* consider the `enableKeyShareOnInvite`
-    /// feature flag, so consumers should be careful to check the flag is true before utilising this property.
+    /// If present, the state of history sharing in this room.
     var historySharingState: RoomHistorySharingState? {
         guard isEncrypted else {
             return nil

ElementX/Sources/Services/UserSession/UserSessionStore.swift

@@ -136,7 +136,6 @@ class UserSessionStore: UserSessionStoreProtocol {
                          sessionDelegate: keychainController,
                          appHooks: appHooks,
                          enableOnlySignedDeviceIsolationMode: appSettings.enableOnlySignedDeviceIsolationMode,
-                         enableKeyShareOnInvite: appSettings.enableKeyShareOnInvite,
                          threadsEnabled: appSettings.threadsEnabled)
             .sqliteStore(config: .init(dataPath: credentials.restorationToken.sessionDirectories.dataPath,
                                        cachePath: credentials.restorationToken.sessionDirectories.cachePath)