Promote "history sharing on invite" out of developer options (#5480)

* Enable key-share-on-invite irrespective of feature flag

* Remove feature-flag dep: warning on starting chat with new people

* Remove feature-flag dep: invite from room member details

* Remove feature-flag dep: warning on new users in invite screen

* Remove feature-flag dep: from room details screen

* Remove feature-flag dep: starting chat from user profile screen

* Remove feature-flag dep: timeline info on forwarded keys

* Remove feature-flag dep: RoomScreenModel

* Remove `enableKeyShareOnInvite` from AppSettings

* Remove `enableKeyShareOnInvite` feature flag

* Remove outdated comments

* Update preview test room snapshots as their header now includes the history sharing icon

ElementX/Sources/Screens/StartChatScreen/StartChatScreenViewModel.swift

@@ -67,20 +67,15 @@ class StartChatScreenViewModel: StartChatScreenViewModelType, StartChatScreenVie
                 hideLoadingIndicator()
                 actionsSubject.send(.showRoom(roomID: roomId))
             case .success:
-                if appSettings.enableKeyShareOnInvite {
-                    Task {
-                        // If an error occured while fetching the identity, assume they are unknown.
-                        let isUnknown = if case .success(let identity) = await self.userSession.clientProxy.userIdentity(for: user.userID, fallBackToServer: false) {
-                            identity == nil
-                        } else {
-                            true
-                        }
-                        self.state.bindings.selectedUserToInvite = UserToInvite(user: user, isUnknown: isUnknown)
-                        hideLoadingIndicator()
+                Task {
+                    // If an error occured while fetching the identity, assume they are unknown.
+                    let isUnknown = if case .success(let identity) = await self.userSession.clientProxy.userIdentity(for: user.userID, fallBackToServer: false) {
+                        identity == nil
+                    } else {
+                        true
                     }
-                } else {
+                    self.state.bindings.selectedUserToInvite = UserToInvite(user: user, isUnknown: isUnknown)
                     hideLoadingIndicator()
-                    state.bindings.selectedUserToInvite = UserToInvite(user: user, isUnknown: false)
                 }
             case .failure:
                 hideLoadingIndicator()