TimelineKind refactor (#3193)

ElementX/Sources/Screens/RoomScreen/View/PinnedItemsBanner/PinnedItemsBannerView.swift

@@ -54,19 +54,20 @@ struct PinnedItemsBannerView: View {
     
     @ViewBuilder
     private var viewAllButton: some View {
-        switch state {
-        case .loaded:
-            Button { onViewAllButtonTap() } label: {
-                Text(L10n.screenRoomPinnedBannerViewAllButtonTitle)
-                    .font(.compound.bodyMDSemibold)
-                    .foregroundStyle(Color.compound.textPrimary)
-                    .padding(.horizontal, 16)
-                    .padding(.vertical, 5)
-            }
-        case .loading:
-            ProgressView()
+        Button { onViewAllButtonTap() } label: {
+            Text(state.isLoading ? "" : L10n.screenRoomPinnedBannerViewAllButtonTitle)
+                .font(.compound.bodyMDSemibold)
+                .foregroundStyle(Color.compound.textPrimary)
+                .opacity(state.isLoading ? 0 : 1)
+                // Use overlay instead otherwise the sliding animation would not work
+                .overlay(alignment: .trailing) {
+                    ProgressView()
+                        .opacity(state.isLoading ? 1 : 0)
+                }
                 .padding(.horizontal, 16)
+                .padding(.vertical, 5)
         }
+        .disabled(state.isLoading)
     }
     
     private var content: some View {

ElementX/Sources/Screens/RoomScreen/View/RoomScreen.swift

@@ -220,7 +220,6 @@ struct RoomScreen_Previews: PreviewProvider, TestablePreview {
     static let roomViewModel = RoomScreenViewModel.mock(roomProxyMock: roomProxyMock)
     static let timelineViewModel = TimelineViewModel(roomProxy: roomProxyMock,
                                                      timelineController: MockRoomTimelineController(),
-                                                     isPinnedEventsTimeline: false,
                                                      mediaProvider: MockMediaProvider(),
                                                      mediaPlayerProvider: MediaPlayerProviderMock(),
                                                      voiceMessageMediaManager: VoiceMessageMediaManagerMock(),