ehealthsolutions/element-x-ios
3
0
Fork 0
mirror of https://github.com/Novaloop-AG/element-x-ios.git synced 2026-11-05 20:09:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix unit tests after the introduction of canBeRepliedTo on timeline items

Browse Source
This commit is contained in:
Stefan Ceriu
2023-09-27 12:22:23 +03:00
parent 61968cb3fb
commit 8e43e66115
3 changed files with 48 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
UnitTests/Sources/LoggingTests.swift
+6
View File
@@ -257,6 +257,7 @@ class LoggingTests: XCTestCase {
timestamp: "", timestamp: "",
isOutgoing: false, isOutgoing: false,
isEditable: false, isEditable: false,
canBeRepliedTo: true,
isThreaded: false, isThreaded: false,
sender: .init(id: "sender"), sender: .init(id: "sender"),
content: .init(body: "TextString", formattedBody: AttributedString(textAttributedString))) content: .init(body: "TextString", formattedBody: AttributedString(textAttributedString)))
@@ -265,6 +266,7 @@ class LoggingTests: XCTestCase {
timestamp: "", timestamp: "",
isOutgoing: false, isOutgoing: false,
isEditable: false, isEditable: false,
canBeRepliedTo: true,
isThreaded: false, isThreaded: false,
sender: .init(id: "sender"), sender: .init(id: "sender"),
content: .init(body: "NoticeString", formattedBody: AttributedString(noticeAttributedString))) content: .init(body: "NoticeString", formattedBody: AttributedString(noticeAttributedString)))
@@ -273,6 +275,7 @@ class LoggingTests: XCTestCase {
timestamp: "", timestamp: "",
isOutgoing: false, isOutgoing: false,
isEditable: false, isEditable: false,
canBeRepliedTo: true,
isThreaded: false, isThreaded: false,
sender: .init(id: "sender"), sender: .init(id: "sender"),
content: .init(body: "EmoteString", formattedBody: AttributedString(emoteAttributedString))) content: .init(body: "EmoteString", formattedBody: AttributedString(emoteAttributedString)))
@@ -280,6 +283,7 @@ class LoggingTests: XCTestCase {
timestamp: "", timestamp: "",
isOutgoing: false, isOutgoing: false,
isEditable: false, isEditable: false,
canBeRepliedTo: true,
isThreaded: false, isThreaded: false,
sender: .init(id: "sender"), sender: .init(id: "sender"),
content: .init(body: "ImageString", source: MediaSourceProxy(url: .picturesDirectory, mimeType: "image/gif"), thumbnailSource: nil)) content: .init(body: "ImageString", source: MediaSourceProxy(url: .picturesDirectory, mimeType: "image/gif"), thumbnailSource: nil))
@@ -287,6 +291,7 @@ class LoggingTests: XCTestCase {
timestamp: "", timestamp: "",
isOutgoing: false, isOutgoing: false,
isEditable: false, isEditable: false,
canBeRepliedTo: true,
isThreaded: false, isThreaded: false,
sender: .init(id: "sender"), sender: .init(id: "sender"),
content: .init(body: "VideoString", duration: 0, source: nil, thumbnailSource: nil)) content: .init(body: "VideoString", duration: 0, source: nil, thumbnailSource: nil))
@@ -294,6 +299,7 @@ class LoggingTests: XCTestCase {
timestamp: "", timestamp: "",
isOutgoing: false, isOutgoing: false,
isEditable: false, isEditable: false,
canBeRepliedTo: true,
isThreaded: false, isThreaded: false,
sender: .init(id: "sender"), sender: .init(id: "sender"),
content: .init(body: "FileString", source: nil, thumbnailSource: nil, contentType: nil)) content: .init(body: "FileString", source: nil, thumbnailSource: nil, contentType: nil))
UnitTests/Sources/RoomScreenViewModelTests.swift
+2
View File
@@ -512,6 +512,7 @@ private extension TextRoomTimelineItem {
timestamp: "10:47 am", timestamp: "10:47 am",
isOutgoing: sender == "bob", isOutgoing: sender == "bob",
isEditable: sender == "bob", isEditable: sender == "bob",
canBeRepliedTo: true,
isThreaded: false, isThreaded: false,
sender: .init(id: "@\(sender):server.com", displayName: sender), sender: .init(id: "@\(sender):server.com", displayName: sender),
content: .init(body: text), content: .init(body: text),
@@ -531,6 +532,7 @@ private extension TextRoomTimelineItem {
timestamp: "", timestamp: "",
isOutgoing: false, isOutgoing: false,
isEditable: false, isEditable: false,
canBeRepliedTo: true,
isThreaded: false, isThreaded: false,
sender: .init(id: ""), sender: .init(id: ""),
content: .init(body: "Hello, World!")) content: .init(body: "Hello, World!"))
UnitTests/Sources/TextBasedRoomTimelineTests.swift
+40 -5
View File
@@ -20,24 +20,52 @@ import XCTest
final class TextBasedRoomTimelineTests: XCTestCase { final class TextBasedRoomTimelineTests: XCTestCase {
func testTextRoomTimelineItemWhitespaceEnd() { func testTextRoomTimelineItemWhitespaceEnd() {
let timestamp = "Now" let timestamp = "Now"
let timelineItem = TextRoomTimelineItem(id: .random, timestamp: timestamp, isOutgoing: true, isEditable: true, isThreaded: false, sender: .init(id: UUID().uuidString), content: .init(body: "Test")) let timelineItem = TextRoomTimelineItem(id: .random,
timestamp: timestamp,
isOutgoing: true,
isEditable: true,
canBeRepliedTo: true,
isThreaded: false,
sender: .init(id: UUID().uuidString),
content: .init(body: "Test"))
XCTAssertEqual(timelineItem.additionalWhitespaces(timelineStyle: .bubbles), timestamp.count + 1) XCTAssertEqual(timelineItem.additionalWhitespaces(timelineStyle: .bubbles), timestamp.count + 1)
} }
func testTextRoomTimelineItemWhitespaceEndLonger() { func testTextRoomTimelineItemWhitespaceEndLonger() {
let timestamp = "10:00 AM" let timestamp = "10:00 AM"
let timelineItem = TextRoomTimelineItem(id: .random, timestamp: timestamp, isOutgoing: true, isEditable: true, isThreaded: false, sender: .init(id: UUID().uuidString), content: .init(body: "Test")) let timelineItem = TextRoomTimelineItem(id: .random,
timestamp: timestamp,
isOutgoing: true,
isEditable: true,
canBeRepliedTo: true,
isThreaded: false,
sender: .init(id: UUID().uuidString),
content: .init(body: "Test"))
XCTAssertEqual(timelineItem.additionalWhitespaces(timelineStyle: .bubbles), timestamp.count + 1) XCTAssertEqual(timelineItem.additionalWhitespaces(timelineStyle: .bubbles), timestamp.count + 1)
} }
func testTextRoomTimelineItemWhitespaceEndPlain() { func testTextRoomTimelineItemWhitespaceEndPlain() {
let timelineItem = TextRoomTimelineItem(id: .random, timestamp: "Now", isOutgoing: true, isEditable: true, isThreaded: false, sender: .init(id: UUID().uuidString), content: .init(body: "Test")) let timelineItem = TextRoomTimelineItem(id: .random,
timestamp: "Now",
isOutgoing: true,
isEditable: true,
canBeRepliedTo: true,
isThreaded: false,
sender: .init(id: UUID().uuidString),
content: .init(body: "Test"))
XCTAssertEqual(timelineItem.additionalWhitespaces(timelineStyle: .plain), 0) XCTAssertEqual(timelineItem.additionalWhitespaces(timelineStyle: .plain), 0)
} }
func testTextRoomTimelineItemWhitespaceEndWithEdit() { func testTextRoomTimelineItemWhitespaceEndWithEdit() {
let timestamp = "Now" let timestamp = "Now"
var timelineItem = TextRoomTimelineItem(id: .random, timestamp: timestamp, isOutgoing: true, isEditable: true, isThreaded: false, sender: .init(id: UUID().uuidString), content: .init(body: "Test")) var timelineItem = TextRoomTimelineItem(id: .random,
timestamp: timestamp,
isOutgoing: true,
isEditable: true,
canBeRepliedTo: true,
isThreaded: false,
sender: .init(id: UUID().uuidString),
content: .init(body: "Test"))
timelineItem.properties.isEdited = true timelineItem.properties.isEdited = true
let editedCount = L10n.commonEditedSuffix.count let editedCount = L10n.commonEditedSuffix.count
XCTAssertEqual(timelineItem.additionalWhitespaces(timelineStyle: .bubbles), timestamp.count + editedCount + 2) XCTAssertEqual(timelineItem.additionalWhitespaces(timelineStyle: .bubbles), timestamp.count + editedCount + 2)
@@ -45,7 +73,14 @@ final class TextBasedRoomTimelineTests: XCTestCase {
func testTextRoomTimelineItemWhitespaceEndWithEditAndAlert() { func testTextRoomTimelineItemWhitespaceEndWithEditAndAlert() {
let timestamp = "Now" let timestamp = "Now"
var timelineItem = TextRoomTimelineItem(id: .random, timestamp: timestamp, isOutgoing: true, isEditable: true, isThreaded: false, sender: .init(id: UUID().uuidString), content: .init(body: "Test")) var timelineItem = TextRoomTimelineItem(id: .random,
timestamp: timestamp,
isOutgoing: true,
isEditable: true,
canBeRepliedTo: true,
isThreaded: false,
sender: .init(id: UUID().uuidString),
content: .init(body: "Test"))
timelineItem.properties.isEdited = true timelineItem.properties.isEdited = true
timelineItem.properties.deliveryStatus = .sendingFailed timelineItem.properties.deliveryStatus = .sendingFailed
let editedCount = L10n.commonEditedSuffix.count let editedCount = L10n.commonEditedSuffix.count