Encryption Flow Coordinators. (#3471)

* Manage the secure backup screens with flow coordinators.

* Add UI tests for the EncryptionSettingsFlowCoordinator.

* Realise that the settings flow can't reset anymore and remove the sub-flow 🤦‍♂️

* Add UI tests for the EncryptionResetFlowCoordinator.

ElementX/Sources/Screens/EncryptionReset/EncryptionResetPasswordScreen/EncryptionResetPasswordScreenCoordinator.swift

@@ -8,17 +8,12 @@
 import Combine
 import SwiftUI
 
-struct EncryptionResetPasswordScreenCoordinatorParameters { }
+struct EncryptionResetPasswordScreenCoordinatorParameters {
+    let passwordPublisher: PassthroughSubject<String, Never>
+}
 
-enum EncryptionResetPasswordScreenCoordinatorAction: CustomStringConvertible {
-    case resetIdentity(String)
-    
-    var description: String {
-        switch self {
-        case .resetIdentity:
-            "resetIdentity"
-        }
-    }
+enum EncryptionResetPasswordScreenCoordinatorAction {
+    case passwordEntered
 }
 
 final class EncryptionResetPasswordScreenCoordinator: CoordinatorProtocol {
@@ -35,7 +30,7 @@ final class EncryptionResetPasswordScreenCoordinator: CoordinatorProtocol {
     init(parameters: EncryptionResetPasswordScreenCoordinatorParameters) {
         self.parameters = parameters
         
-        viewModel = EncryptionResetPasswordScreenViewModel()
+        viewModel = EncryptionResetPasswordScreenViewModel(passwordPublisher: parameters.passwordPublisher)
     }
     
     func start() {
@@ -44,8 +39,8 @@ final class EncryptionResetPasswordScreenCoordinator: CoordinatorProtocol {
             
             guard let self else { return }
             switch action {
-            case .resetIdentity(let password):
-                self.actionsSubject.send(.resetIdentity(password))
+            case .passwordEntered:
+                self.actionsSubject.send(.passwordEntered)
             }
         }
         .store(in: &cancellables)

ElementX/Sources/Screens/EncryptionReset/EncryptionResetPasswordScreen/EncryptionResetPasswordScreenModels.swift

@@ -7,15 +7,8 @@
 
 import Foundation
 
-enum EncryptionResetPasswordScreenViewModelAction: CustomStringConvertible {
-    case resetIdentity(String)
-    
-    var description: String {
-        switch self {
-        case .resetIdentity:
-            "resetIdentity"
-        }
-    }
+enum EncryptionResetPasswordScreenViewModelAction {
+    case passwordEntered
 }
 
 struct EncryptionResetPasswordScreenViewState: BindableState {
@@ -28,5 +21,5 @@ struct EncryptionResetPasswordScreenViewStateBindings {
 }
 
 enum EncryptionResetPasswordScreenViewAction {
-    case resetIdentity
+    case submit
 }

ElementX/Sources/Screens/EncryptionReset/EncryptionResetPasswordScreen/EncryptionResetPasswordScreenViewModel.swift

@@ -11,12 +11,16 @@ import SwiftUI
 typealias EncryptionResetPasswordScreenViewModelType = StateStoreViewModel<EncryptionResetPasswordScreenViewState, EncryptionResetPasswordScreenViewAction>
 
 class EncryptionResetPasswordScreenViewModel: EncryptionResetPasswordScreenViewModelType, EncryptionResetPasswordScreenViewModelProtocol {
+    private let passwordPublisher: PassthroughSubject<String, Never>
+    
     private let actionsSubject: PassthroughSubject<EncryptionResetPasswordScreenViewModelAction, Never> = .init()
     var actionsPublisher: AnyPublisher<EncryptionResetPasswordScreenViewModelAction, Never> {
         actionsSubject.eraseToAnyPublisher()
     }
 
-    init() {
+    init(passwordPublisher: PassthroughSubject<String, Never>) {
+        self.passwordPublisher = passwordPublisher
+        
         super.init(initialViewState: .init(bindings: .init(password: "")))
     }
     
@@ -26,8 +30,9 @@ class EncryptionResetPasswordScreenViewModel: EncryptionResetPasswordScreenViewM
         MXLog.info("View model: received view action: \(viewAction)")
         
         switch viewAction {
-        case .resetIdentity:
-            actionsSubject.send(.resetIdentity(state.bindings.password))
+        case .submit:
+            passwordPublisher.send(state.bindings.password)
+            actionsSubject.send(.passwordEntered)
         }
     }
 }

ElementX/Sources/Screens/EncryptionReset/EncryptionResetPasswordScreen/View/EncryptionResetPasswordScreen.swift

@@ -5,6 +5,7 @@
 // Please see LICENSE in the repository root for full details.
 //
 
+import Combine
 import Compound
 import SwiftUI
 
@@ -32,9 +33,10 @@ struct EncryptionResetPasswordScreen: View {
             .padding(16)
         } bottomContent: {
             Button(L10n.actionResetIdentity, role: .destructive) {
-                context.send(viewAction: .resetIdentity)
+                context.send(viewAction: .submit)
             }
             .buttonStyle(.compound(.primary))
+            .accessibilityIdentifier(A11yIdentifiers.encryptionResetPasswordScreen.submit)
         }
         .background()
         .backgroundStyle(.compound.bgCanvasDefault)
@@ -58,8 +60,9 @@ struct EncryptionResetPasswordScreen: View {
                 .focused($textFieldFocus)
                 .submitLabel(.done)
                 .onSubmit {
-                    context.send(viewAction: .resetIdentity)
+                    context.send(viewAction: .submit)
                 }
+                .accessibilityIdentifier(A11yIdentifiers.encryptionResetPasswordScreen.passwordField)
         }
     }
 }
@@ -67,7 +70,8 @@ struct EncryptionResetPasswordScreen: View {
 // MARK: - Previews
 
 struct EncryptionResetPasswordScreen_Previews: PreviewProvider, TestablePreview {
-    static let viewModel = EncryptionResetPasswordScreenViewModel()
+    static let passwordPublisher = PassthroughSubject<String, Never>()
+    static let viewModel = EncryptionResetPasswordScreenViewModel(passwordPublisher: passwordPublisher)
     static var previews: some View {
         NavigationStack {
             EncryptionResetPasswordScreen(context: viewModel.context)