Address PR comments

This commit is contained in:
Stefan Ceriu
2026-08-21 11:40:10 +03:00
parent 72d55e485a
commit 8a3468658b
5 changed files with 15 additions and 27 deletions
@@ -399,9 +399,9 @@ final class HomeScreenViewModelTests {
#expect(context.viewState.roomListMode == .skeletons)
// The provider reports loaded before the first summaries have been published.
let failure = deferFailure(context.$viewState, timeout: .seconds(1)) { $0.roomListMode != .skeletons }
stateSubject.send(.loaded(totalNumberOfRooms: 8))
try await Task.sleep(for: .milliseconds(100))
#expect(context.viewState.roomListMode == .skeletons)
try await failure.fulfill()
let deferred = deferFulfillment(context.$viewState) { $0.roomListMode == .rooms }
roomListSubject.send(.mockRooms)
@@ -418,10 +418,10 @@ final class HomeScreenViewModelTests {
try await deferred.fulfill()
// A filter or a search without matches empties the list, the mode must not regress.
let failure = deferFailure(context.$viewState, timeout: .seconds(1)) { $0.roomListMode != .rooms }
roomListSubject.send([])
stateSubject.send(.loaded(totalNumberOfRooms: 9))
try await Task.sleep(for: .milliseconds(100))
#expect(context.viewState.roomListMode == .rooms)
try await failure.fulfill()
}
private func setupViewModelWithManualProvider() -> (CurrentValueSubject<[RoomSummary], Never>, CurrentValueSubject<RoomSummaryProviderState, Never>) {
@@ -271,8 +271,6 @@ struct RoomDetailsScreenViewModelTests {
#expect(context.viewState.dmRecipientInfo?.member == RoomMemberDetails(withProxy: recipient))
#expect(!context.viewState.isProcessingIgnoreRequest)
// Waiting on the transient isProcessingIgnoreRequest transition races the view model's task,
// which can complete before the observation starts. Wait on the alert instead.
let deferredAlert = deferFulfillment(context.observe(\.alertInfo)) { $0 != nil }
context.send(viewAction: .unignoreConfirmed)