Remove delivered notifications for rooms that have meantime become fully read and have messages newer than what's delivered

- this is a best effort solution to cleanup outdated notifications when using multiple clients and reading them elsewhere

ElementX/Sources/Services/Notification/Manager/NotificationManager.swift

@@ -128,6 +128,28 @@ final class NotificationManager: NSObject, NotificationManagerProtocol {
             .map(\.request.identifier)
         notificationCenter.removeDeliveredNotifications(withIdentifiers: notificationsIdentifiers)
     }
+    
+    func removeDeliveredNotificationsForFullyReadRooms(_ rooms: [RoomSummary]) async {
+        let roomsToLastMessageDates = rooms
+            .filter { $0.hasUnreadMessages == false }
+            .reduce(into: [:]) { partialResult, roomSummary in
+                partialResult[roomSummary.id] = roomSummary.lastMessageDate
+            }
+        
+        let notificationsIdentifiers = await notificationCenter
+            .deliveredNotifications()
+            .filter { notification in
+                guard let roomID = notification.request.content.roomID,
+                      let lastMessageDate = roomsToLastMessageDates[roomID] else {
+                    return false
+                }
+                    
+                return notification.date <= lastMessageDate
+            }
+            .map(\.request.identifier)
+        
+        notificationCenter.removeDeliveredNotifications(withIdentifiers: notificationsIdentifiers)
+    }
 
     private func setPusher(with deviceToken: Data, clientProxy: ClientProxyProtocol) async -> Bool {
         do {

ElementX/Sources/Services/Notification/Manager/NotificationManagerProtocol.swift

@@ -33,4 +33,6 @@ protocol NotificationManagerProtocol: AnyObject {
     func requestAuthorization()
     
     func removeDeliveredMessageNotifications(for roomID: String) async
+    
+    func removeDeliveredNotificationsForFullyReadRooms(_ rooms: [RoomSummary]) async
 }