Stop storing the openURL action to fix a retain cycle.

Uses the existing timeline action instead.
This commit is contained in:
Doug
2025-09-03 12:32:11 +01:00
committed by Doug
parent af5ebf8cae
commit 86f978a439
3 changed files with 5 additions and 16 deletions
@@ -202,8 +202,6 @@ class TimelineViewModel: TimelineViewModelType, TimelineViewModelProtocol {
Task { state.timelineState.isSwitchingTimelines = false }
case let .hasScrolled(direction):
actionsSubject.send(.hasScrolled(direction: direction))
case .setOpenURLAction(let action):
state.openURL = action
case .displayPredecessorRoom:
guard let predecessorID = roomProxy.predecessorRoom?.roomId else {
fatalError("Predecessor room should exist if this action is triggered.")
@@ -656,15 +654,15 @@ class TimelineViewModel: TimelineViewModelType, TimelineViewModelProtocol {
return nil
}
private func handleJoinCommand(message: String) {
private func handleJoinCommand(message: String) async {
guard let alias = String(message.dropFirst(SlashCommand.join.rawValue.count))
.components(separatedBy: .whitespacesAndNewlines)
.first,
let urlString = try? matrixToRoomAliasPermalink(roomAlias: alias),
let url = URL(string: urlString) else {
case let .success(resolvedAlias) = await userSession.clientProxy.resolveRoomAlias(alias) else {
return
}
state.openURL?(url)
actionsSubject.send(.displayRoom(roomID: resolvedAlias.roomId, via: resolvedAlias.servers))
}
private func sendCurrentMessage(_ message: String, html: String?, mode: ComposerMode, intentionalMentions: IntentionalMentions) async {
@@ -694,7 +692,7 @@ class TimelineViewModel: TimelineViewModelType, TimelineViewModelProtocol {
case .default:
switch slashCommand(message: message) {
case .join:
handleJoinCommand(message: message)
await handleJoinCommand(message: message)
case .none:
await timelineController.sendMessage(message,
html: html,