ehealthsolutions/element-x-ios
3
0
Fork 0
mirror of https://github.com/Novaloop-AG/element-x-ios.git synced 2026-11-04 19:44:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use a plain view for reactions instead of a TabView. (#3328)

Browse Source 
We don't use any of the TabView features and it shows a tab bar at the bottom when the list is long.
This commit is contained in:
Doug
2024-09-25 11:00:18 +01:00
committed by GitHub
parent 6faa26eade
commit 864bd23d35
5 changed files with 19 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ElementX/Sources/Screens/Timeline/View/Supplementary/ReactionsSummaryView.swift
+11 -10
View File
@@ -13,6 +13,9 @@ struct ReactionsSummaryView: View {
let mediaProvider: MediaProviderProtocol? let mediaProvider: MediaProviderProtocol?
@State var selectedReactionKey: String @State var selectedReactionKey: String
private var selectedReaction: AggregatedReaction? {
reactions.first { $0.key == selectedReactionKey }
}
var body: some View { var body: some View {
VStack(alignment: .leading, spacing: 0) { VStack(alignment: .leading, spacing: 0) {
@@ -49,19 +52,17 @@ struct ReactionsSummaryView: View {
.padding(.bottom, 12) .padding(.bottom, 12)
} }
@ViewBuilder
private var sendersList: some View { private var sendersList: some View {
TabView(selection: $selectedReactionKey) { if let selectedReaction {
ForEach(reactions) { reaction in ScrollView {
ScrollView { VStack(alignment: .leading, spacing: 8) {
VStack(alignment: .leading, spacing: 8) { ForEach(selectedReaction.senders) { sender in
ForEach(reaction.senders) { sender in ReactionSummarySenderView(sender: sender, member: members[sender.id], mediaProvider: mediaProvider)
ReactionSummarySenderView(sender: sender, member: members[sender.id], mediaProvider: mediaProvider) .padding(.horizontal, 16)
.padding(.horizontal, 16)
}
} }
.frame(maxWidth: .infinity)
} }
.tag(reaction.key) .frame(maxWidth: .infinity)
} }
} }
} }
PreviewTests/Sources/__Snapshots__/PreviewTests/test_reactionsSummaryView-iPad-en-GB.1.png
+2 -2
View File
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1 version https://git-lfs.github.com/spec/v1
oid sha256:b1421a726565df2dad3ab8f0febd352f23489ac4ca583905740ffffeb5931660 oid sha256:0a525081a32f80cdb362055bf1fb85bb94e36ee4f8eda0fed3348a66c31863bd
size 157682 size 156020
PreviewTests/Sources/__Snapshots__/PreviewTests/test_reactionsSummaryView-iPad-pseudo.1.png
+2 -2
View File
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1 version https://git-lfs.github.com/spec/v1
oid sha256:28768fa226f7387ef2e1c257364af742d0b201c3b1e2200d5bf9c5b6cd7a5ede oid sha256:17732eaf6452abe88755241d6c08304f1732d0bfd5545d580112ab9f23531071
size 158659 size 156140
PreviewTests/Sources/__Snapshots__/PreviewTests/test_reactionsSummaryView-iPhone-16-en-GB.1.png
+2 -2
View File
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1 version https://git-lfs.github.com/spec/v1
oid sha256:7e4ee2d0a1b36a89d157d405a42124c399b48b6d63ecad48c8e529532e7a61fa oid sha256:190f8ea7d63ff14e77714718feafc1e6d777f5eb2abcaa65849ec1c78d763776
size 65270 size 64131
PreviewTests/Sources/__Snapshots__/PreviewTests/test_reactionsSummaryView-iPhone-16-pseudo.1.png
+2 -2
View File
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1 version https://git-lfs.github.com/spec/v1
oid sha256:2a6a9a8bd8535ba80b94570c01e299999dd63d268e55b30e76edade00316d606 oid sha256:ccf83508eff98903ae25de15107818345cef052868b1b5854ab4379e470d0c68
size 65983 size 64217