ehealthsolutions/element-x-ios
3
0
Fork 0
mirror of https://github.com/Novaloop-AG/element-x-ios.git synced 2026-11-02 12:07:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Rename snapshots (#4756)

Browse Source 
* renaming snapshots so that it's easier to diff them when an upgrade happens.

* fix macOS runner version for the compound tests

* os version update in the yml

* possible fix to run compound-ios tests
This commit is contained in:
Mauro
2025-11-17 17:46:51 +01:00
committed by GitHub
parent 013637bdab
commit 7fe67f000e
1130 changed files with 127 additions and 119 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compound-ios/Tests/CompoundTests/PreviewTests.swift
+16 -8
View File
@@ -15,10 +15,18 @@ import XCTest
@MainActor
class PreviewTests: XCTestCase {
private struct SnapshotDevice {
let name: String
let device: String
}
private let deviceConfig: ViewImageConfig = .iPhoneX
private let simulatorDevice: String? = "iPhone14,6" // iPhone SE 3rd Generation
private let requiredOSVersion = (major: 26, minor: 0)
private let snapshotDevices = ["iPhone 16", "iPad"]
private let requiredOSVersion = (major: 26, minor: 1)
// The key is the name we will give to the snapshot
// The value is the actual device that will be used to render the preview
private let snapshotDevices: [SnapshotDevice] = [.init(name: "iPhone", device: "iPhone 17"),
.init(name: "iPad", device: "iPad")]
private var recordMode: SnapshotTestingConfiguration.Record = .missing
override func setUp() {
@@ -66,9 +74,9 @@ class PreviewTests: XCTestCase {
var sanitizedSuiteName = String(testName.suffix(testName.count - "test".count).dropLast(2))
sanitizedSuiteName = sanitizedSuiteName.prefix(1).lowercased() + sanitizedSuiteName.dropFirst()
for deviceName in snapshotDevices {
guard var device = PreviewDevice(rawValue: deviceName).snapshotDevice() else {
fatalError("Unknown device name: \(deviceName)")
for snapshotDevice in snapshotDevices {
guard var device = PreviewDevice(rawValue: snapshotDevice.device).snapshotDevice() else {
fatalError("Unknown device name: \(snapshotDevice.device)")
}
// Ignore specific device safe area (using the workaround value to fix rendering issues).
device.safeArea = .one
@@ -77,9 +85,9 @@ class PreviewTests: XCTestCase {
var testName = ""
if let displayName = preview.displayName {
testName = "\(displayName)-\(deviceName)-\(localeCode)"
testName = "\(displayName)-\(snapshotDevice.name)-\(localeCode)"
} else {
testName = "\(deviceName)-\(localeCode)-\(step)"
testName = "\(snapshotDevice.name)-\(localeCode)-\(step)"
}
let isScreen = switch preview.layout {
@@ -155,7 +163,7 @@ private class SnapshotPreferences: @unchecked Sendable {
private extension PreviewDevice {
func snapshotDevice() -> ViewImageConfig? {
switch rawValue {
case "iPhone 16", "iPhone 15", "iPhone 14", "iPhone 13", "iPhone 12", "iPhone 11", "iPhone 10":
case "iPhone 17", "iPhone 16", "iPhone 15", "iPhone 14", "iPhone 13", "iPhone 12", "iPhone 11", "iPhone 10":
return .iPhoneX
case "iPhone 6", "iPhone 6s", "iPhone 7", "iPhone 8":
return .iPhone8
compound-ios/Tests/CompoundTests/__Snapshots__/PreviewTests/compoundButtonStyle.iPad-en-US-0.png
+2 -2
View File
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:92d42eae08c834c1eebbcdcf516295094c4e7b739247ceed55739903cfe5dfd8
size 363963
oid sha256:479fe4ddb6a6fabaabc2e55494fdbb866ff91fe6170d451121183843102b1085
size 365602
compound-ios/Tests/CompoundTests/__Snapshots__/PreviewTests/compoundButtonStyle.iPhone-16-en-US-0.png
-3
View File
@@ -1,3 +0,0 @@
version https://git-lfs.github.com/spec/v1
oid sha256:6a535b429cb142ff9f0604d0241185e85ddf98b8ec5e2fe275f8316ed0ea1813
size 245520
compound-ios/Tests/CompoundTests/__Snapshots__/PreviewTests/compoundButtonStyle.iPhone-en-US-0.png
+3
View File
@@ -0,0 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:319f94d9727fcd4ca5e2402e88f3adca09977fd190c1ac7b2f42e4037ac774f4
size 246298
compound-ios/Tests/CompoundTests/__Snapshots__/PreviewTests/compoundIcon.Accessibility-Icons-Only-iPhone-16-en-US.png → compound-ios/Tests/CompoundTests/__Snapshots__/PreviewTests/compoundIcon.Accessibility-Icons-Only-iPhone-en-US.png
View File
compound-ios/Tests/CompoundTests/__Snapshots__/PreviewTests/compoundIcon.Accessibility-Labels-iPhone-16-en-US.png → compound-ios/Tests/CompoundTests/__Snapshots__/PreviewTests/compoundIcon.Accessibility-Labels-iPhone-en-US.png
View File
compound-ios/Tests/CompoundTests/__Snapshots__/PreviewTests/compoundIcon.Buttons-iPhone-16-en-US.png → compound-ios/Tests/CompoundTests/__Snapshots__/PreviewTests/compoundIcon.Buttons-iPhone-en-US.png
View File
compound-ios/Tests/CompoundTests/__Snapshots__/PreviewTests/compoundIcon.Form-iPad-en-US.png
+2 -2
View File
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:6d4c75e6fb3110ff56c00740de3cf4d1b686cbd72dbd6450c814a2845009235d
size 100347
oid sha256:0ee44e47bddf3eef7bb5596623adf613e929dd2a7ba30b31ad8b0b3110126a75
size 97423
compound-ios/Tests/CompoundTests/__Snapshots__/PreviewTests/compoundIcon.Form-iPhone-16-en-US.png
-3
View File
@@ -1,3 +0,0 @@
version https://git-lfs.github.com/spec/v1
oid sha256:8667eeaaba9b5bc7abad960c457f386b2f7df4ef8ee8237725b41e8fc7566f91
size 52794
compound-ios/Tests/CompoundTests/__Snapshots__/PreviewTests/compoundIcon.Form-iPhone-en-US.png
+3
View File
@@ -0,0 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:bcd094069e63b3facd6550d2f0d0db99aa6cdd4735ccc2d15861eb7eb9c9d25e
size 50658
compound-ios/Tests/CompoundTests/__Snapshots__/PreviewTests/compoundToggleStyle.iPhone-16-en-US-0.png → compound-ios/Tests/CompoundTests/__Snapshots__/PreviewTests/compoundToggleStyle.iPhone-en-US-0.png
View File
compound-ios/Tests/CompoundTests/__Snapshots__/PreviewTests/listInlinePicker.iPad-en-US-0.png
+2 -2
View File
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:71c1c17fd959d8fa9afdeaf808a386680c9f6e05aaebd5c7544cd3c507b4627e
size 116937
oid sha256:6a42fb2b64b6a5c583aa0b95d7dbf4fc10a17494baf1e3da8348297aa1d727ec
size 110005
compound-ios/Tests/CompoundTests/__Snapshots__/PreviewTests/listInlinePicker.iPhone-16-en-US-0.png
-3
View File
@@ -1,3 +0,0 @@
version https://git-lfs.github.com/spec/v1
oid sha256:29b9d46a50018c833c5d34ac140f1f189f5aa926c82f67f75ca76a5f0c4ffb44
size 67634
compound-ios/Tests/CompoundTests/__Snapshots__/PreviewTests/listInlinePicker.iPhone-en-US-0.png
+3
View File
@@ -0,0 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:73b01af5cf919295729ef6ab86a418d23eed8bfc7578922fecb3e51d12562aa1
size 60233
compound-ios/Tests/CompoundTests/__Snapshots__/PreviewTests/listRow.iPad-en-US-0.png
+2 -2
View File
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:c68720e4d3b40dfc6003220405af729c2bc67ca6f4bef3af7d44625e70c51e01
size 437038
oid sha256:56eeb69cb930a4a8768b9e965cb1b107d9e2d6e767284b20c720cbd026318977
size 397819
compound-ios/Tests/CompoundTests/__Snapshots__/PreviewTests/listRow.iPhone-16-en-US-0.png
-3
View File
@@ -1,3 +0,0 @@
version https://git-lfs.github.com/spec/v1
oid sha256:fd72899333242a49b483a9d31b59e6601943f099a10c6269d4b889c38ff8ad75
size 298633
compound-ios/Tests/CompoundTests/__Snapshots__/PreviewTests/listRow.iPhone-en-US-0.png
+3
View File
@@ -0,0 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:b92722ff5a722dcf2f3815311d99149bf70ed8c146350a5ff83caab4ed63cb93
size 266194
compound-ios/Tests/CompoundTests/__Snapshots__/PreviewTests/listRowAccessory.Accessories-iPhone-16-en-US.png → compound-ios/Tests/CompoundTests/__Snapshots__/PreviewTests/listRowAccessory.Accessories-iPhone-en-US.png
View File
compound-ios/Tests/CompoundTests/__Snapshots__/PreviewTests/listRowButtonStyle.iPad-en-US-0.png
+2 -2
View File
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:59aafe6e5b98db613736839970a02d728840717adc2ddfd0dddf9a949955bbdd
size 90861
oid sha256:8ea2558e30ef8b5a54c151f8c3d00cea0eec863d89cfe4b2f5c8beb572bd022c
size 86943
compound-ios/Tests/CompoundTests/__Snapshots__/PreviewTests/listRowButtonStyle.iPhone-16-en-US-0.png
-3
View File
@@ -1,3 +0,0 @@
version https://git-lfs.github.com/spec/v1
oid sha256:90b881fd9796efb27b617dd88e4740d34763279aadc1ff341be4a2ae7a93cef2
size 44699
compound-ios/Tests/CompoundTests/__Snapshots__/PreviewTests/listRowButtonStyle.iPhone-en-US-0.png
+3
View File
@@ -0,0 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:d24f028c3e51c4480cbff7a22d14f556d1c6b3dd070160ee27789126b222c9a2
size 41537
compound-ios/Tests/CompoundTests/__Snapshots__/PreviewTests/listRowLabel.iPad-en-US-0.png
+2 -2
View File
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:208f242925fecd91f86e9b8afe79478b2253a252f6e3ea6583e57b6b4c7a44d3
size 208392
oid sha256:5f78bedc262cac32ac78a88aa97389efb3feffe971c829a198dd4382e2d2ef26
size 191878
compound-ios/Tests/CompoundTests/__Snapshots__/PreviewTests/listRowLabel.iPhone-16-en-US-0.png
-3
View File
@@ -1,3 +0,0 @@
version https://git-lfs.github.com/spec/v1
oid sha256:f6b1251f8070d93eae2e41e4c4c58ce03d4d5947b9e63ca3824aaaef35aa4899
size 149137
compound-ios/Tests/CompoundTests/__Snapshots__/PreviewTests/listRowLabel.iPhone-en-US-0.png
+3
View File
@@ -0,0 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:902dc2ba25af3501bab1533a20c7b07f798345424dffde546d3f1784f0c87fb8
size 131625
compound-ios/Tests/CompoundTests/__Snapshots__/PreviewTests/listRowLoadingSelection.iPad-en-US-0.png
+2 -2
View File
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:8d9c705c66ea08a16f70c60874f5bbcb97c30b3f9f6a7f4a69913149a3b60413
size 135959
oid sha256:3e41ba9ae022a7aaddaa6f9311d9d0d84e82b5775d884c10108f72681a8246d9
size 133248
compound-ios/Tests/CompoundTests/__Snapshots__/PreviewTests/listRowLoadingSelection.iPhone-16-en-US-0.png
-3
View File
@@ -1,3 +0,0 @@
version https://git-lfs.github.com/spec/v1
oid sha256:120cf8492a676297433bc52e6d9a7c8b90b749245b190d6de3d9d6ab3ff8a06b
size 103398
compound-ios/Tests/CompoundTests/__Snapshots__/PreviewTests/listRowLoadingSelection.iPhone-en-US-0.png
+3
View File
@@ -0,0 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:52f87baed151e6e980d9c86b7e626537a9c72319a759482281720e3980e0bf70
size 99945
compound-ios/Tests/CompoundTests/__Snapshots__/PreviewTests/listRowTrailingSection.iPhone-16-en-US-0.png → compound-ios/Tests/CompoundTests/__Snapshots__/PreviewTests/listRowTrailingSection.iPhone-en-US-0.png
View File
compound-ios/Tests/CompoundTests/__Snapshots__/PreviewTests/listTextStyles.Form-iPad-en-US.png
+2 -2
View File
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:ac5ed5a5063401dbf7387a5b5f117ce8fb4bab99441edaf7c253a25a57a8692f
size 108001
oid sha256:2f1656e9b8e951ef999b31940dace699ef28b0322ca119dc19bf9a47e1fe1933
size 106642
compound-ios/Tests/CompoundTests/__Snapshots__/PreviewTests/listTextStyles.Form-iPhone-16-en-US.png
-3
View File
@@ -1,3 +0,0 @@
version https://git-lfs.github.com/spec/v1
oid sha256:a93babf81fe639ff816d53e00800d4d86a03f5827710859ef248da3df0e13a62
size 60480
compound-ios/Tests/CompoundTests/__Snapshots__/PreviewTests/listTextStyles.Form-iPhone-en-US.png
+3
View File
@@ -0,0 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:65c27529b9aa1a5eb7a0f0da9e053a8f09af50019428e040d6ee27a91b1e08ad
size 59424
compound-ios/Tests/CompoundTests/__Snapshots__/PreviewTests/listTextStyles.List-iPad-en-US.png
+2 -2
View File
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:947d5b5e1bfe119d8a6d2c347188cdbcb62e8b8f88507526663165ee733d7bbb
size 88969
oid sha256:bc4527662ef00800d2fe644b4d02c8af4b3fd95ea68139309c9dc8e18a5dd2b1
size 87597
compound-ios/Tests/CompoundTests/__Snapshots__/PreviewTests/listTextStyles.List-iPhone-16-en-US.png
-3
View File
@@ -1,3 +0,0 @@
version https://git-lfs.github.com/spec/v1
oid sha256:3353c5b59c8eb902dc1b4fa62cb93460206c60d007a4a4f4db8293e808e24950
size 42436
compound-ios/Tests/CompoundTests/__Snapshots__/PreviewTests/listTextStyles.List-iPhone-en-US.png
+3
View File
@@ -0,0 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:92da62ffd1476a1d795db7462c16c3f52f4aa5615fd1517ae91225bf6710ffaf
size 40986
compound-ios/Tests/CompoundTests/__Snapshots__/PreviewTests/scaledFrameModifier.iPhone-16-en-US-0.png → compound-ios/Tests/CompoundTests/__Snapshots__/PreviewTests/scaledFrameModifier.iPhone-en-US-0.png
View File
compound-ios/Tests/CompoundTests/__Snapshots__/PreviewTests/scaledOffsetModifier.iPhone-16-en-US-0.png → compound-ios/Tests/CompoundTests/__Snapshots__/PreviewTests/scaledOffsetModifier.iPhone-en-US-0.png
View File
compound-ios/Tests/CompoundTests/__Snapshots__/PreviewTests/scaledPaddingModifier.iPhone-16-en-US-0.png → compound-ios/Tests/CompoundTests/__Snapshots__/PreviewTests/scaledPaddingModifier.iPhone-en-US-0.png
View File
compound-ios/Tests/CompoundTests/__Snapshots__/PreviewTests/searchStyle.Form-iPad-en-US.png
+2 -2
View File
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:0e9a7d9a8b67d377ad3cf576eac03cf69c3cb815902b8a0a913deb1aeb813dc6
size 97512
oid sha256:72d36ddf21854d317e87a7285299b5b75652e53e6c09e1c62d1dcd6dd00bc9ef
size 96821
compound-ios/Tests/CompoundTests/__Snapshots__/PreviewTests/searchStyle.Form-iPhone-16-en-US.png
-3
View File
@@ -1,3 +0,0 @@
version https://git-lfs.github.com/spec/v1
oid sha256:91b051f02d7734e7f1ac3330efe8887829ed06370e105bd2e51793cd59dc4397
size 49549
compound-ios/Tests/CompoundTests/__Snapshots__/PreviewTests/searchStyle.Form-iPhone-en-US.png
+3
View File
@@ -0,0 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:7b34a1ae4c75e0fbf789ccd2c7abc84a59679e39e975fb128814bcce12f492c6
size 48821
compound-ios/Tests/CompoundTests/__Snapshots__/PreviewTests/searchStyle.List-iPhone-16-en-US.png → compound-ios/Tests/CompoundTests/__Snapshots__/PreviewTests/searchStyle.List-iPhone-en-US.png
View File
compound-ios/Tests/CompoundTests/__Snapshots__/PreviewTests/sendButton.iPhone-16-en-US-0.png → compound-ios/Tests/CompoundTests/__Snapshots__/PreviewTests/sendButton.iPhone-en-US-0.png
View File