mirror of
https://github.com/Novaloop-AG/element-x-ios.git
synced 2026-11-03 16:10:20 +00:00
Use the new notification sound. (#4572)
* Use the new notification sound. * Add a banner informing the user of the new notification sound.
This commit is contained in:
@@ -437,6 +437,11 @@ class AppCoordinator: AppCoordinatorProtocol, AuthenticationFlowCoordinatorDeleg
|
||||
await userSession.clientProxy.expireSyncSessions()
|
||||
}
|
||||
|
||||
if oldVersion < Version(25, 10, 0) {
|
||||
MXLog.info("Migrating to version 25.10.0, showing new sound banner to existing user.")
|
||||
appSettings.hasSeenNewSoundBanner = false
|
||||
}
|
||||
|
||||
userSessionMigrationsOldVersion = nil
|
||||
}
|
||||
|
||||
|
||||
@@ -29,6 +29,7 @@ final class AppSettings {
|
||||
private enum UserDefaultsKeys: String {
|
||||
case lastVersionLaunched
|
||||
case seenInvites
|
||||
case hasSeenNewSoundBanner
|
||||
case appLockNumberOfPINAttempts
|
||||
case appLockNumberOfBiometricAttempts
|
||||
case timelineStyle
|
||||
@@ -161,6 +162,10 @@ final class AppSettings {
|
||||
@UserPreference(key: UserDefaultsKeys.seenInvites, defaultValue: [], storageType: .userDefaults(store))
|
||||
var seenInvites: Set<String>
|
||||
|
||||
/// Defaults to `true` for new users, and we use a migration to set it to `false` for existing users.
|
||||
@UserPreference(key: UserDefaultsKeys.hasSeenNewSoundBanner, defaultValue: true, storageType: .userDefaults(store))
|
||||
var hasSeenNewSoundBanner
|
||||
|
||||
/// The initial set of account providers shown to the user in the authentication flow.
|
||||
///
|
||||
/// Account provider is the friendly term for the server name. It should not contain an `https` prefix and should
|
||||
|
||||
@@ -360,6 +360,10 @@ internal enum L10n {
|
||||
internal static var bannerMigrateToNativeSlidingSyncForceLogoutTitle: String { return L10n.tr("Localizable", "banner_migrate_to_native_sliding_sync_force_logout_title") }
|
||||
/// Upgrade available
|
||||
internal static var bannerMigrateToNativeSlidingSyncTitle: String { return L10n.tr("Localizable", "banner_migrate_to_native_sliding_sync_title") }
|
||||
/// Your notification ping has been updated—clearer, quicker, and less disruptive.
|
||||
internal static var bannerNewSoundMessage: String { return L10n.tr("Localizable", "banner_new_sound_message") }
|
||||
/// We’ve refreshed your sounds
|
||||
internal static var bannerNewSoundTitle: String { return L10n.tr("Localizable", "banner_new_sound_title") }
|
||||
/// Recover your cryptographic identity and message history with a recovery key if you have lost all your existing devices.
|
||||
internal static var bannerSetUpRecoveryContent: String { return L10n.tr("Localizable", "banner_set_up_recovery_content") }
|
||||
/// Set up recovery
|
||||
|
||||
@@ -53,6 +53,7 @@ enum TestablePreviewsDictionary {
|
||||
"HomeScreenEmptyStateView_Previews" : HomeScreenEmptyStateView_Previews.self,
|
||||
"HomeScreenInviteCell_Previews" : HomeScreenInviteCell_Previews.self,
|
||||
"HomeScreenKnockedCell_Previews" : HomeScreenKnockedCell_Previews.self,
|
||||
"HomeScreenNewSoundBanner_Previews" : HomeScreenNewSoundBanner_Previews.self,
|
||||
"HomeScreenRecoveryKeyConfirmationBanner_Previews" : HomeScreenRecoveryKeyConfirmationBanner_Previews.self,
|
||||
"HomeScreenRoomCell_Previews" : HomeScreenRoomCell_Previews.self,
|
||||
"HomeScreen_Previews" : HomeScreen_Previews.self,
|
||||
|
||||
@@ -39,6 +39,7 @@ enum HomeScreenViewAction {
|
||||
case confirmRecoveryKey
|
||||
case resetEncryption
|
||||
case skipRecoveryKeyConfirmation
|
||||
case dismissNewSoundBanner
|
||||
case updateVisibleItemRange(Range<Int>)
|
||||
case globalSearch
|
||||
case markRoomAsUnread(roomIdentifier: String)
|
||||
@@ -92,6 +93,7 @@ struct HomeScreenViewState: BindableState {
|
||||
var userAvatarURL: URL?
|
||||
|
||||
var securityBannerMode = HomeScreenSecurityBannerMode.none
|
||||
var shouldShowNewSoundBanner = false
|
||||
|
||||
var requiresExtraAccountSetup = false
|
||||
|
||||
@@ -134,6 +136,10 @@ struct HomeScreenViewState: BindableState {
|
||||
var shouldShowFilters: Bool {
|
||||
!bindings.isSearchFieldFocused && roomListMode == .rooms
|
||||
}
|
||||
|
||||
var shouldShowBanner: Bool {
|
||||
securityBannerMode.isShown || shouldShowNewSoundBanner
|
||||
}
|
||||
}
|
||||
|
||||
struct HomeScreenViewStateBindings {
|
||||
|
||||
@@ -105,6 +105,12 @@ class HomeScreenViewModel: HomeScreenViewModelType, HomeScreenViewModelProtocol
|
||||
}
|
||||
.store(in: &cancellables)
|
||||
|
||||
appSettings.$hasSeenNewSoundBanner
|
||||
.sink { [weak self] hasSeenNewSoundBanner in
|
||||
self?.state.shouldShowNewSoundBanner = !hasSeenNewSoundBanner
|
||||
}
|
||||
.store(in: &cancellables)
|
||||
|
||||
userSession.clientProxy.hideInviteAvatarsPublisher
|
||||
.removeDuplicates()
|
||||
.receive(on: DispatchQueue.main)
|
||||
@@ -160,6 +166,8 @@ class HomeScreenViewModel: HomeScreenViewModelType, HomeScreenViewModelProtocol
|
||||
actionsSubject.send(.presentEncryptionResetScreen)
|
||||
case .skipRecoveryKeyConfirmation:
|
||||
state.securityBannerMode = .dismissed
|
||||
case .dismissNewSoundBanner:
|
||||
appSettings.hasSeenNewSoundBanner = true
|
||||
case .updateVisibleItemRange(let range):
|
||||
roomSummaryProvider?.updateVisibleRange(range)
|
||||
case .startChat:
|
||||
|
||||
@@ -122,14 +122,16 @@ struct HomeScreenContent: View {
|
||||
@ViewBuilder
|
||||
private var topSection: some View {
|
||||
// An empty VStack causes glitches within the room list
|
||||
if context.viewState.shouldShowFilters || context.viewState.securityBannerMode.isShown {
|
||||
if context.viewState.shouldShowFilters || context.viewState.shouldShowBanner {
|
||||
VStack(spacing: 0) {
|
||||
if context.viewState.shouldShowFilters {
|
||||
RoomListFiltersView(state: $context.filtersState)
|
||||
}
|
||||
|
||||
|
||||
if case let .show(state) = context.viewState.securityBannerMode {
|
||||
HomeScreenRecoveryKeyConfirmationBanner(state: state, context: context)
|
||||
} else if context.viewState.shouldShowNewSoundBanner {
|
||||
HomeScreenNewSoundBanner { context.send(viewAction: .dismissNewSoundBanner) }
|
||||
}
|
||||
}
|
||||
.background(Color.compound.bgCanvasDefault)
|
||||
|
||||
@@ -0,0 +1,59 @@
|
||||
//
|
||||
// Copyright 2025 New Vector Ltd.
|
||||
//
|
||||
// SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial
|
||||
// Please see LICENSE files in the repository root for full details.
|
||||
//
|
||||
|
||||
import Compound
|
||||
import SwiftUI
|
||||
|
||||
struct HomeScreenNewSoundBanner: View {
|
||||
let dismissAction: () -> Void
|
||||
|
||||
var body: some View {
|
||||
VStack(spacing: 16) {
|
||||
content
|
||||
buttons
|
||||
}
|
||||
.padding(16)
|
||||
.background(Color.compound.bgSubtleSecondary)
|
||||
.cornerRadius(14)
|
||||
.padding(.horizontal, 16)
|
||||
}
|
||||
|
||||
var content: some View {
|
||||
VStack(alignment: .leading, spacing: 4) {
|
||||
HStack(alignment: .firstTextBaseline, spacing: 16) {
|
||||
Text(L10n.bannerNewSoundTitle)
|
||||
.font(.compound.bodyLGSemibold)
|
||||
.foregroundColor(.compound.textPrimary)
|
||||
.frame(maxWidth: .infinity, alignment: .leading)
|
||||
|
||||
Button(action: dismissAction) {
|
||||
Image(systemName: "xmark")
|
||||
.foregroundColor(.compound.iconSecondary)
|
||||
.frame(width: 12, height: 12)
|
||||
}
|
||||
}
|
||||
|
||||
Text(L10n.bannerNewSoundMessage)
|
||||
.font(.compound.bodyMD)
|
||||
.foregroundColor(.compound.textSecondary)
|
||||
}
|
||||
}
|
||||
|
||||
var buttons: some View {
|
||||
Button(action: dismissAction) {
|
||||
Text(L10n.actionOk)
|
||||
.frame(maxWidth: .infinity)
|
||||
}
|
||||
.buttonStyle(.compound(.primary, size: .medium))
|
||||
}
|
||||
}
|
||||
|
||||
struct HomeScreenNewSoundBanner_Previews: PreviewProvider, TestablePreview {
|
||||
static var previews: some View {
|
||||
HomeScreenNewSoundBanner { }
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user