ehealthsolutions/element-x-ios
3
0
Fork 0
mirror of https://github.com/Novaloop-AG/element-x-ios.git synced 2026-10-31 16:24:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

Cleaned up unneccesary code, hid some warnings.

Browse Source
This commit is contained in:
Stefan Ceriu
2022-02-22 09:21:31 +02:00
parent b53efb4869
commit 7a4be39e7e
9 changed files with 13 additions and 63 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ElementX/Sources/Modules/Authentication/LoginScreen/LoginScreenCoordinator.swift
-1
View File
@@ -38,7 +38,6 @@ final class LoginScreenCoordinator: Coordinator, Presentable {
// MARK: - Setup
@available(iOS 14.0, *)
init(parameters: LoginScreenCoordinatorParameters) {
self.parameters = parameters
ElementX/Sources/Modules/Authentication/LoginScreen/Test/UI/LoginScreenUITests.swift
-28
View File
@@ -15,31 +15,3 @@
//
import XCTest
import RiotSwiftUI
@available(iOS 14.0, *)
class LoginScreenUITests: MockScreenTest {
override class var screenType: MockScreenState.Type {
return MockLoginScreenScreenState.self
}
override class func createTest() -> MockScreenTest {
return LoginScreenUITests(selector: #selector(verifyLoginScreenScreen))
}
func verifyLoginScreenScreen() throws {
guard let screenState = screenState as? MockLoginScreenScreenState else { fatalError("no screen") }
switch screenState {
case .promptType(let promptType):
verifyLoginScreenPromptType(promptType: promptType)
}
}
func verifyLoginScreenPromptType(promptType: LoginScreenPromptType) {
let title = app.staticTexts["title"]
XCTAssert(title.exists)
XCTAssertEqual(title.label, promptType.title)
}
}
ElementX/Sources/Modules/Authentication/LoginScreen/Test/Unit/LoginScreenViewModelTests.swift
-1
View File
@@ -18,7 +18,6 @@ import XCTest
@testable import ElementX
@available(iOS 14.0, *)
class LoginScreenViewModelTests: XCTestCase {
override func setUpWithError() throws {
ElementX/Sources/Modules/Authentication/LoginScreen/View/LoginScreen.swift
-1
View File
@@ -16,7 +16,6 @@
import SwiftUI
@available(iOS 14.0, *)
struct LoginScreen: View {
@ObservedObject var context: LoginScreenViewModel.Context
ElementX/Sources/Modules/HomeScreen/Test/UI/HomeScreenUITests.swift
-28
View File
@@ -15,31 +15,3 @@
//
import XCTest
import ElementX
@available(iOS 14.0, *)
class HomeScreenUITests: MockScreenTest {
override class var screenType: MockScreenState.Type {
return MockHomeScreenScreenState.self
}
override class func createTest() -> MockScreenTest {
return HomeScreenUITests(selector: #selector(verifyHomeScreenScreen))
}
func verifyHomeScreenScreen() throws {
guard let screenState = screenState as? MockHomeScreenScreenState else { fatalError("no screen") }
switch screenState {
case .promptType(let promptType):
verifyHomeScreenPromptType(promptType: promptType)
}
}
func verifyHomeScreenPromptType(promptType: HomeScreenPromptType) {
let title = app.staticTexts["title"]
XCTAssert(title.exists)
XCTAssertEqual(title.label, promptType.title)
}
}
ElementX/Sources/Modules/HomeScreen/Test/Unit/HomeScreenViewModelTests.swift
-1
View File
@@ -18,7 +18,6 @@ import XCTest
@testable import ElementX
@available(iOS 14.0, *)
class HomeScreenViewModelTests: XCTestCase {
override func setUpWithError() throws {
ElementX/Sources/Modules/Routers/NavigationRouter.swift
+1 -1
View File
@@ -356,7 +356,7 @@ extension NavigationRouter: UINavigationControllerDelegate {
func navigationController(_ navigationController: UINavigationController, willShow viewController: UIViewController, animated: Bool) {
// TODO: Try to post `NavigationRouter.willPopModule` notification here
// Try to post `NavigationRouter.willPopModule` notification here
}
func navigationController(_ navigationController: UINavigationController, didShow viewController: UIViewController, animated: Bool) {
ElementX/Sources/Modules/Routers/NavigationRouterStore.swift
+2 -2
View File
@@ -25,7 +25,7 @@ class NavigationRouterStore: NavigationRouterStoreProtocol {
// MARK: - Properties
// FIXME: WeakDictionary does not work with protocol
// WeakDictionary does not work with protocol
// Find a way to use NavigationRouterType as value
private var navigationRouters = WeakDictionary<UINavigationController, NavigationRouter>()
@@ -74,7 +74,7 @@ class NavigationRouterStore: NavigationRouterStoreProtocol {
if let existingNavigationRouter = self.findNavigationRouter(for: navigationController) {
fatalError("\(existingNavigationRouter) is already tied to the same navigation controller as \(navigationRouter). We should have only one NavigationRouter per navigation controller")
} else {
// FIXME: WeakDictionary does not work with protocol
// WeakDictionary does not work with protocol
// Find a way to avoid this cast
self.navigationRouters[navigationController] = navigationRouter as? NavigationRouter
}