ehealthsolutions/element-x-ios
3
0
Fork 0
mirror of https://github.com/Novaloop-AG/element-x-ios.git synced 2026-11-03 06:55:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update errorMissingLocationAuth (#1341)

Browse Source
This commit is contained in:
Alfonso Grillo
2023-07-17 15:19:28 +02:00
committed by GitHub
parent 18b4a3a51a
commit 79fcfcd61b
5 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ElementX.xcodeproj/project.pbxproj
+1 -1
View File
@@ -3618,7 +3618,7 @@
path = Timeline; path = Timeline;
sourceTree = "<group>"; sourceTree = "<group>";
}; };
"TEMP_C02F1FDA-4B9F-4174-8DD3-76A7A4DE4CCB" /* element-x-ios */ = { "TEMP_BABAC1E3-4AC2-4E05-A4A7-2CB82B6F7C7E" /* element-x-ios */ = {
isa = PBXGroup; isa = PBXGroup;
children = ( children = (
41553551C55AD59885840F0E /* secrets.xcconfig */, 41553551C55AD59885840F0E /* secrets.xcconfig */,
ElementX/Resources/Localizations/en.lproj/Localizable.strings
+1 -1
View File
@@ -142,7 +142,7 @@
"error_failed_loading_map" = "%1$@ could not load the map. Please try again later."; "error_failed_loading_map" = "%1$@ could not load the map. Please try again later.";
"error_failed_loading_messages" = "Failed loading messages"; "error_failed_loading_messages" = "Failed loading messages";
"error_failed_locating_user" = "%1$@ could not access your location. Please try again later."; "error_failed_locating_user" = "%1$@ could not access your location. Please try again later.";
"error_missing_location_auth" = "%1$@ does not have permission to access your location. You can enable access in Settings > Location"; "error_missing_location_auth_ios" = "%1$@ does not have permission to access your location. You can enable access in Settings > Location";
"error_no_compatible_app_found" = "No compatible app was found to handle this action."; "error_no_compatible_app_found" = "No compatible app was found to handle this action.";
"error_some_messages_have_not_been_sent" = "Some messages have not been sent"; "error_some_messages_have_not_been_sent" = "Some messages have not been sent";
"error_unknown" = "Sorry, an error occurred"; "error_unknown" = "Sorry, an error occurred";
ElementX/Sources/Generated/Strings.swift
+2 -2
View File
@@ -319,8 +319,8 @@ public enum L10n {
return L10n.tr("Localizable", "error_failed_locating_user", String(describing: p1)) return L10n.tr("Localizable", "error_failed_locating_user", String(describing: p1))
} }
/// %1$@ does not have permission to access your location. You can enable access in Settings > Location /// %1$@ does not have permission to access your location. You can enable access in Settings > Location
public static func errorMissingLocationAuth(_ p1: Any) -> String { public static func errorMissingLocationAuthIos(_ p1: Any) -> String {
return L10n.tr("Localizable", "error_missing_location_auth", String(describing: p1)) return L10n.tr("Localizable", "error_missing_location_auth_ios", String(describing: p1))
} }
/// No compatible app was found to handle this action. /// No compatible app was found to handle this action.
public static var errorNoCompatibleAppFound: String { return L10n.tr("Localizable", "error_no_compatible_app_found") } public static var errorNoCompatibleAppFound: String { return L10n.tr("Localizable", "error_no_compatible_app_found") }
ElementX/Sources/Screens/LocationSharing/LocationSharingScreenModels.swift
+1 -1
View File
@@ -149,7 +149,7 @@ extension AlertInfo where T == LocationSharingViewError {
case .missingAuthorization: case .missingAuthorization:
self.init(id: error, self.init(id: error,
title: "", title: "",
message: L10n.errorMissingLocationAuth(InfoPlistReader.main.bundleDisplayName), message: L10n.errorMissingLocationAuthIos(InfoPlistReader.main.bundleDisplayName),
primaryButton: primaryButton, primaryButton: primaryButton,
secondaryButton: secondaryButton) secondaryButton: secondaryButton)
case .mapError(.failedLoadingMap): case .mapError(.failedLoadingMap):
UnitTests/Sources/StaticLocationScreenViewModelTests.swift
+1 -1
View File
@@ -74,7 +74,7 @@ class StaticLocationScreenViewModelTests: XCTestCase {
let locationError = AlertInfo(locationSharingViewError: .mapError(.failedLocatingUser)) let locationError = AlertInfo(locationSharingViewError: .mapError(.failedLocatingUser))
XCTAssertEqual(locationError.message, L10n.errorFailedLocatingUser(InfoPlistReader.main.bundleDisplayName)) XCTAssertEqual(locationError.message, L10n.errorFailedLocatingUser(InfoPlistReader.main.bundleDisplayName))
let authorizationError = AlertInfo(locationSharingViewError: .missingAuthorization) let authorizationError = AlertInfo(locationSharingViewError: .missingAuthorization)
XCTAssertEqual(authorizationError.message, L10n.errorMissingLocationAuth(InfoPlistReader.main.bundleDisplayName)) XCTAssertEqual(authorizationError.message, L10n.errorMissingLocationAuthIos(InfoPlistReader.main.bundleDisplayName))
} }
func testSendUserLocation() async throws { func testSendUserLocation() async throws {