Swift Testing for Unit Tests PART 1 (#5119)

* migrated a lot of unit tests to Swift Testing and added a new implementation for deferred fulfillment

more tests migration

Cleaned the code manually to establish some good patterns

more code improvements

some more code improvements

removed empty tests

update project

* more pr suggestions and cleanups

* removed the TestSetup pattern

* fixing claude not reusing tests

* pr suggestion + added indent rule to swiftformat so that we can prevent AIs to change that

UnitTests/Sources/UserAgentBuilderTests.swift

@@ -7,20 +7,24 @@
 //
 
 @testable import ElementX
-import XCTest
+import Testing
 
-class UserAgentBuilderTests: XCTestCase {
-    func testIsNotNil() {
-        XCTAssertNotNil(UserAgentBuilder.makeASCIIUserAgent())
+@Suite
+struct UserAgentBuilderTests {
+    @Test
+    func isNotUnknow() {
+        #expect(UserAgentBuilder.makeASCIIUserAgent() != "unknown")
     }
     
-    func testContainsClientName() {
+    @Test
+    func containsClientName() {
         let userAgent = UserAgentBuilder.makeASCIIUserAgent()
-        XCTAssert(userAgent.contains(InfoPlistReader.main.bundleDisplayName) == true, "\(userAgent) does not contain client name")
+        #expect(userAgent.contains(InfoPlistReader.main.bundleDisplayName) == true, "\(userAgent) does not contain client name")
     }
     
-    func testContainsClientVersion() {
+    @Test
+    func containsClientVersion() {
         let userAgent = UserAgentBuilder.makeASCIIUserAgent()
-        XCTAssert(userAgent.contains(InfoPlistReader.main.bundleShortVersionString) == true, "\(userAgent) does not contain client version")
+        #expect(userAgent.contains(InfoPlistReader.main.bundleShortVersionString) == true, "\(userAgent) does not contain client version")
     }
 }