ehealthsolutions/element-x-ios
3
0
Fork 0
mirror of https://github.com/Novaloop-AG/element-x-ios.git synced 2026-11-02 21:33:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Swift Testing for Unit Tests PART 1 (#5119)

Browse Source 
* migrated a lot of unit tests to Swift Testing and added a new implementation for deferred fulfillment

more tests migration

Cleaned the code manually to establish some good patterns

more code improvements

some more code improvements

removed empty tests

update project

* more pr suggestions and cleanups

* removed the TestSetup pattern

* fixing claude not reusing tests

* pr suggestion + added indent rule to swiftformat so that we can prevent AIs to change that
This commit is contained in:
Mauro
2026-02-19 16:20:47 +01:00
committed by GitHub
parent fc03e05697
commit 7982aef855
118 changed files with 4630 additions and 4129 deletions
Download Patch File Download Diff File Expand all files Collapse all files
UnitTests/Sources/URLComponentsTests.swift
+33 -53
View File
@@ -7,87 +7,67 @@
//
@testable import ElementX
import XCTest
import Foundation
import Testing
class URLComponentsTests: XCTestCase {
func testAddFragmentQueryItems() {
guard let url = URL(string: "https://test.matrix.org"),
var components = URLComponents(url: url, resolvingAgainstBaseURL: true) else {
XCTFail("URL invalid")
return
}
@Suite
struct URLComponentsTests {
@Test
func addFragmentQueryItems() throws {
let url = try #require(URL(string: "https://test.matrix.org"))
var components = try #require(URLComponents(url: url, resolvingAgainstBaseURL: true))
XCTAssertNil(components.fragmentQueryItems)
#expect(components.fragmentQueryItems == nil)
let fragmentQueryItems: [URLQueryItem] = [.init(name: "first", value: "1"), .init(name: "second", value: "2")]
components.fragmentQueryItems = fragmentQueryItems
XCTAssertEqual(components.url?.absoluteString, "https://test.matrix.org#?first=1&second=2")
#expect(components.url?.absoluteString == "https://test.matrix.org#?first=1&second=2")
}
func testRemoveFragmentQueryItem() {
guard let url = URL(string: "https://test.matrix.org#random/data?first=1&second=2"),
var components = URLComponents(url: url, resolvingAgainstBaseURL: true) else {
XCTFail("URL invalid")
return
}
XCTAssertNotNil(components.fragmentQueryItems)
guard var fragmentQueryItems = components.fragmentQueryItems else {
return
}
@Test
func removeFragmentQueryItem() throws {
let url = try #require(URL(string: "https://test.matrix.org#random/data?first=1&second=2"))
var components = try #require(URLComponents(url: url, resolvingAgainstBaseURL: true))
var fragmentQueryItems = try #require(components.fragmentQueryItems)
fragmentQueryItems.removeAll { $0.name == "first" }
components.fragmentQueryItems = fragmentQueryItems
XCTAssertEqual(components.url?.absoluteString, "https://test.matrix.org#random/data?second=2")
#expect(components.url?.absoluteString == "https://test.matrix.org#random/data?second=2")
}
func testAppendFragmentQueryItem() {
guard let url = URL(string: "https://test.matrix.org#/random/data?first=1&second=2"),
var components = URLComponents(url: url, resolvingAgainstBaseURL: true) else {
XCTFail("URL invalid")
return
}
XCTAssertNotNil(components.fragmentQueryItems)
guard var fragmentQueryItems = components.fragmentQueryItems else {
return
}
@Test
func appendFragmentQueryItem() throws {
let url = try #require(URL(string: "https://test.matrix.org#/random/data?first=1&second=2"))
var components = try #require(URLComponents(url: url, resolvingAgainstBaseURL: true))
var fragmentQueryItems = try #require(components.fragmentQueryItems)
fragmentQueryItems.insert(.init(name: "mr in between", value: "hello"), at: 1)
components.fragmentQueryItems = fragmentQueryItems
XCTAssertEqual(components.url?.absoluteString, "https://test.matrix.org#/random/data?first=1&mr%20in%20between=hello&second=2")
#expect(components.url?.absoluteString == "https://test.matrix.org#/random/data?first=1&mr%20in%20between=hello&second=2")
}
func testChangeFragmentQueryItemValue() {
guard let url = URL(string: "https://test.matrix.org#/random/data?first=1&second=2"),
var components = URLComponents(url: url, resolvingAgainstBaseURL: true) else {
XCTFail("URL invalid")
return
}
XCTAssertNotNil(components.fragmentQueryItems)
guard var fragmentQueryItems = components.fragmentQueryItems else {
return
}
@Test
func changeFragmentQueryItemValue() throws {
let url = try #require(URL(string: "https://test.matrix.org#/random/data?first=1&second=2"))
var components = try #require(URLComponents(url: url, resolvingAgainstBaseURL: true))
var fragmentQueryItems = try #require(components.fragmentQueryItems)
fragmentQueryItems[0].value = "last"
components.fragmentQueryItems = fragmentQueryItems
XCTAssertEqual(components.url?.absoluteString, "https://test.matrix.org#/random/data?first=last&second=2")
#expect(components.url?.absoluteString == "https://test.matrix.org#/random/data?first=last&second=2")
}
func testElementCallParameters() {
guard let url = URL(string: "https://call.element.io/room#/callName?appPrompt=true&confineToRoom=false"),
var components = URLComponents(url: url, resolvingAgainstBaseURL: true) else {
XCTFail("URL invalid")
return
}
@Test
func elementCallParameters() throws {
let url = try #require(URL(string: "https://call.element.io/room#/callName?appPrompt=true&confineToRoom=false"))
var components = try #require(URLComponents(url: url, resolvingAgainstBaseURL: true))
components.fragmentQueryItems?.removeAll { $0.name == "appPrompt" }
components.fragmentQueryItems?.removeAll { $0.name == "confineToRoom" }
@@ -97,6 +77,6 @@ class URLComponentsTests: XCTestCase {
components.fragmentQueryItems?.append(.init(name: "appPrompt", value: "false"))
components.fragmentQueryItems?.append(.init(name: "confineToRoom", value: "true"))
XCTAssertEqual(components.url?.absoluteString, "https://call.element.io/room#/callName?skipLobby=true&appPrompt=false&confineToRoom=true")
#expect(components.url?.absoluteString == "https://call.element.io/room#/callName?skipLobby=true&appPrompt=false&confineToRoom=true")
}
}