Swift Testing for Unit Tests PART 1 (#5119)

* migrated a lot of unit tests to Swift Testing and added a new implementation for deferred fulfillment

more tests migration

Cleaned the code manually to establish some good patterns

more code improvements

some more code improvements

removed empty tests

update project

* more pr suggestions and cleanups

* removed the TestSetup pattern

* fixing claude not reusing tests

* pr suggestion + added indent rule to swiftformat so that we can prevent AIs to change that

UnitTests/Sources/SettingsScreenViewModelTests.swift

@@ -8,16 +8,15 @@
 
 import Combine
 @testable import ElementX
-import XCTest
+import Testing
 
 @MainActor
-class SettingsScreenViewModelTests: XCTestCase {
-    var viewModel: SettingsScreenViewModelProtocol!
-    var context: SettingsScreenViewModelType.Context!
-    var cancellables = Set<AnyCancellable>()
+@Suite
+struct SettingsScreenViewModelTests {
+    private var viewModel: SettingsScreenViewModelProtocol
+    private var context: SettingsScreenViewModelType.Context
     
-    @MainActor override func setUpWithError() throws {
-        cancellables.removeAll()
+    init() {
         let userSession = UserSessionMock(.init(clientProxy: ClientProxyMock(.init(userID: ""))))
         viewModel = SettingsScreenViewModel(userSession: userSession,
                                             appSettings: ServiceLocator.shared.settings,
@@ -25,19 +24,22 @@ class SettingsScreenViewModelTests: XCTestCase {
         context = viewModel.context
     }
 
-    @MainActor func testLogout() async throws {
+    @Test
+    func logout() async throws {
         let deferred = deferFulfillment(viewModel.actions) { $0 == .logout }
         context.send(viewAction: .logout)
         try await deferred.fulfill()
     }
 
-    func testReportBug() async throws {
+    @Test
+    func reportBug() async throws {
         let deferred = deferFulfillment(viewModel.actions) { $0 == .reportBug }
         context.send(viewAction: .reportBug)
         try await deferred.fulfill()
     }
     
-    func testAnalytics() async throws {
+    @Test
+    func analytics() async throws {
         let deferred = deferFulfillment(viewModel.actions) { $0 == .analytics }
         context.send(viewAction: .analytics)
         try await deferred.fulfill()