ehealthsolutions/element-x-ios
3
0
Fork 0
mirror of https://github.com/Novaloop-AG/element-x-ios.git synced 2026-11-02 12:07:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Swift Testing for Unit Tests PART 1 (#5119)

Browse Source 
* migrated a lot of unit tests to Swift Testing and added a new implementation for deferred fulfillment

more tests migration

Cleaned the code manually to establish some good patterns

more code improvements

some more code improvements

removed empty tests

update project

* more pr suggestions and cleanups

* removed the TestSetup pattern

* fixing claude not reusing tests

* pr suggestion + added indent rule to swiftformat so that we can prevent AIs to change that
This commit is contained in:
Mauro
2026-02-19 16:20:47 +01:00
committed by GitHub
parent fc03e05697
commit 7982aef855
118 changed files with 4630 additions and 4129 deletions
Download Patch File Download Diff File Expand all files Collapse all files
UnitTests/Sources/RoomRolesAndPermissionsScreenViewModelTests.swift
+47 -39
View File
@@ -7,73 +7,81 @@
//
@testable import ElementX
import XCTest
import Testing
@MainActor
class RoomRolesAndPermissionsScreenViewModelTests: XCTestCase {
@Suite
struct RoomRolesAndPermissionsScreenViewModelTests {
var viewModel: RoomRolesAndPermissionsScreenViewModelProtocol!
var roomProxy: JoinedRoomProxyMock!
var context: RoomRolesAndPermissionsScreenViewModelType.Context {
viewModel.context
}
func testEmptyCounters() {
setupViewModel(members: .allMembers)
XCTAssertEqual(context.viewState.administratorCount, 0)
XCTAssertEqual(context.viewState.moderatorCount, 0)
@Test
mutating func emptyCounters() {
setup(members: .allMembers)
#expect(context.viewState.administratorCount == 0)
#expect(context.viewState.moderatorCount == 0)
}
func testFilledCounters() {
setupViewModel(members: .allMembersAsAdmin)
XCTAssertEqual(context.viewState.administratorCount, 2)
XCTAssertEqual(context.viewState.moderatorCount, 1)
@Test
mutating func filledCounters() {
setup(members: .allMembersAsAdmin)
#expect(context.viewState.administratorCount == 2)
#expect(context.viewState.moderatorCount == 1)
}
func testResetPermissions() async throws {
setupViewModel(members: .allMembersAsAdmin)
@Test
mutating func resetPermissions() async throws {
setup(members: .allMembersAsAdmin)
context.send(viewAction: .reset)
XCTAssertNotNil(context.alertInfo)
#expect(context.alertInfo != nil)
context.alertInfo?.primaryButton.action?()
try await Task.sleep(for: .milliseconds(100))
XCTAssertTrue(roomProxy.resetPowerLevelsCalled)
#expect(roomProxy.resetPowerLevelsCalled)
}
func testDemoteToModerator() async throws {
setupViewModel(members: .allMembersAsAdmin)
@Test
mutating func demoteToModerator() async throws {
setup(members: .allMembersAsAdmin)
context.send(viewAction: .editOwnUserRole)
XCTAssertNotNil(context.alertInfo)
#expect(context.alertInfo != nil)
context.alertInfo?.verticalButtons?.first { $0.title.localizedStandardContains("moderator") }?.action?()
try await Task.sleep(for: .milliseconds(100))
XCTAssertTrue(roomProxy.updatePowerLevelsForUsersCalled)
XCTAssertEqual(roomProxy.updatePowerLevelsForUsersReceivedUpdates?.first?.powerLevel,
RoomRole.moderator.powerLevelValue)
#expect(roomProxy.updatePowerLevelsForUsersCalled)
#expect(roomProxy.updatePowerLevelsForUsersReceivedUpdates?.first?.powerLevel == RoomRole.moderator.powerLevelValue)
}
func testDemoteToMember() async throws {
setupViewModel(members: .allMembersAsAdmin)
@Test
mutating func demoteToMember() async throws {
setup(members: .allMembersAsAdmin)
context.send(viewAction: .editOwnUserRole)
XCTAssertNotNil(context.alertInfo)
#expect(context.alertInfo != nil)
context.alertInfo?.verticalButtons?.first { $0.title.localizedStandardContains("member") }?.action?()
try await Task.sleep(for: .milliseconds(100))
XCTAssertTrue(roomProxy.updatePowerLevelsForUsersCalled)
XCTAssertEqual(roomProxy.updatePowerLevelsForUsersReceivedUpdates?.first?.powerLevel,
RoomRole.user.powerLevelValue)
#expect(roomProxy.updatePowerLevelsForUsersCalled)
#expect(roomProxy.updatePowerLevelsForUsersReceivedUpdates?.first?.powerLevel == RoomRole.user.powerLevelValue)
}
private func setupViewModel(members: [RoomMemberProxyMock]) {
// MARK: - Helpers
private mutating func setup(members: [RoomMemberProxyMock]) {
roomProxy = JoinedRoomProxyMock(.init(members: members))
viewModel = RoomRolesAndPermissionsScreenViewModel(roomProxy: roomProxy,
userIndicatorController: UserIndicatorControllerMock(),